From acc2fcd8b99cfb1f5bdb760f6adde8777c24285e Mon Sep 17 00:00:00 2001 From: Karol Latecki Date: Wed, 25 Jan 2023 16:04:52 +0100 Subject: [PATCH] scripts/nvmf_perf: do not overwrite extra_params Do not overwrite extra_params when io_uring fio engine is selected; append number of poll queues to params list instead. Signed-off-by: Karol Latecki Change-Id: I5609e3ad4009df74bc2b02b5c5407548d1d69f3b Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16507 Reviewed-by: Aleksey Marchuk Reviewed-by: Jim Harris Tested-by: SPDK CI Jenkins --- scripts/perf/nvmf/run_nvmf.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/perf/nvmf/run_nvmf.py b/scripts/perf/nvmf/run_nvmf.py index 90b3cf02b..908bd82ac 100755 --- a/scripts/perf/nvmf/run_nvmf.py +++ b/scripts/perf/nvmf/run_nvmf.py @@ -1346,7 +1346,7 @@ class KernelInitiator(Initiator): if "kernel_engine" in initiator_config: self.ioengine = initiator_config["kernel_engine"] if "io_uring" in self.ioengine: - self.extra_params = "--nr-poll-queues=8" + self.extra_params += ' --nr-poll-queues=8' def configure_adq(self): self.log.warning("WARNING: ADQ setup not yet supported for Kernel mode. Skipping configuration.")