From ab696ae1cfb9c4263870ad2b2fef879fe420bc71 Mon Sep 17 00:00:00 2001
From: Jim Harris <james.r.harris@intel.com>
Date: Tue, 29 Jan 2019 13:49:23 -0700
Subject: [PATCH] bdevperf: remove extra blockdev_heads_destroy() in failure
 path

The stop handler already calls blockdev_heads_destroy(), so we
don't need to call it if bdevperf_construct_targets_tasks()
fails.  Calling it twice actually results in double-frees and
other types of memory corruption.

Fixes #592.

Signed-off-by: Jim Harris <james.r.harris@intel.com>
Change-Id: Iba92b1ae64453036829a67ab6f3dad970a368af0

Reviewed-on: https://review.gerrithub.io/c/442628
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
---
 test/bdev/bdevperf/bdevperf.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/test/bdev/bdevperf/bdevperf.c b/test/bdev/bdevperf/bdevperf.c
index 30eb1fe27..68374518c 100644
--- a/test/bdev/bdevperf/bdevperf.c
+++ b/test/bdev/bdevperf/bdevperf.c
@@ -758,7 +758,6 @@ bdevperf_run(void *arg1, void *arg2)
 
 	rc = bdevperf_construct_targets_tasks();
 	if (rc) {
-		blockdev_heads_destroy();
 		spdk_app_stop(1);
 		return;
 	}