From ab356d40795dafe85f6051e8c52104f5e086f8bf Mon Sep 17 00:00:00 2001 From: Michal Berger Date: Tue, 2 Aug 2022 12:31:41 +0200 Subject: [PATCH] test/setup: Remove the hp_status() test This just verifies a modest setup.sh's output which is of little relevance. On top of that, depending on the system's state, the test itself may be flaky so get rid of it. Signed-off-by: Michal Berger Change-Id: Icc918a0dbbb54067c281aa465a097c4e40a32e11 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/13827 Reviewed-by: Pawel Piatek Reviewed-by: Tomasz Zawadzki Reviewed-by: Jim Harris Community-CI: Broadcom CI Tested-by: SPDK CI Jenkins --- test/setup/hugepages.sh | 24 ------------------------ 1 file changed, 24 deletions(-) diff --git a/test/setup/hugepages.sh b/test/setup/hugepages.sh index b64e211b4..d66216bb5 100755 --- a/test/setup/hugepages.sh +++ b/test/setup/hugepages.sh @@ -186,29 +186,6 @@ custom_alloc() { nr_hugepages=$_nr_hugepages verify_nr_hugepages } -hp_status() { - # Parse status from last verification - - local node - local size free total - - ((${#nodes_sys[@]} > 0)) - - while read -r node size free _ total; do - size=${size/kB/} node=${node#node} - ((size == default_hugepages)) || continue - ((total == nodes_test[node])) - # If something grabbed hugepages we can't really do anything about it. Just skip the free check and leave - # a big warning. - if ((free != total)); then - printf '* %u free != %u total hugepages. Something is using hugepages, this may affect the test\n' \ - "$free" "$total" >&2 - continue - fi - ((free == nodes_test[node])) - done < <(setup output status |& grep "node[0-9]") -} - get_nodes clear_hp @@ -217,6 +194,5 @@ run_test "per_node_2G_alloc" per_node_2G_alloc run_test "even_2G_alloc" even_2G_alloc run_test "odd_alloc" odd_alloc run_test "custom_alloc" custom_alloc -run_test "hp_status" hp_status clear_hp