ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

thread: Add a notification callback when threads are created

Browse Source 
Nothing implements the callback just yet, but it will be used for
dynamic thread creation.

Change-Id: I088f2bc40e1405cd5b9973b9110608f49c8abd68
Signed-off-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-on: https://review.gerrithub.io/c/440594
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
This commit is contained in:
Ben Walker 2019-01-15 13:39:06 -07:00 committed by Darek Stojaczyk
parent 7ff602a660
commit aaa9a27851
4 changed files with 25 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
examples/bdev/fio_plugin/fio_plugin.c
View File

@ -280,7 +280,7 @@ spdk_init_thread_poll(void *arg)
} }
spdk_unaffinitize_thread(); spdk_unaffinitize_thread();
spdk_thread_lib_init(); spdk_thread_lib_init(NULL);
/* Create an SPDK thread temporarily */ /* Create an SPDK thread temporarily */
rc = spdk_fio_init_thread(&td); rc = spdk_fio_init_thread(&td);

14
include/spdk/thread.h
View File

@ -50,6 +50,15 @@ struct spdk_thread;
struct spdk_io_channel_iter; struct spdk_io_channel_iter;
struct spdk_poller; struct spdk_poller;
/**
* A function that is called each time a new thread is created.
* The implementor of this function should frequently call
* spdk_thread_poll() on the thread provided.
*
* \param thread The new spdk_thread.
*/
typedef void (*spdk_new_thread_fn)(struct spdk_thread *thread);
/** /**
* A function that will be called on the target thread. * A function that will be called on the target thread.
* *
@ -166,9 +175,12 @@ struct spdk_io_channel {
/** /**
* Initialize the threading library. Must be called once prior to allocating any threads. * Initialize the threading library. Must be called once prior to allocating any threads.
* *
* \param new_thread_fn Called each time a new SPDK thread is created. The implementor
* is expected to frequently call spdk_thread_poll() on the provided thread.
*
* \return 0 on success. Negated errno on failure. * \return 0 on success. Negated errno on failure.
*/ */
int spdk_thread_lib_init(void); int spdk_thread_lib_init(spdk_new_thread_fn new_thread_fn);
/** /**
* Release all resources associated with this library. * Release all resources associated with this library.

2
lib/event/app.c
View File

@ -624,7 +624,7 @@ spdk_app_start(struct spdk_app_opts *opts, spdk_event_fn start_fn,
spdk_log_open(); spdk_log_open();
SPDK_NOTICELOG("Total cores available: %d\n", spdk_env_get_core_count()); SPDK_NOTICELOG("Total cores available: %d\n", spdk_env_get_core_count());
spdk_thread_lib_init(); spdk_thread_lib_init(NULL);
/* /*
* If mask not specified on command line or in configuration file, * If mask not specified on command line or in configuration file,

11
lib/thread/thread.c
View File

@ -54,6 +54,8 @@
static pthread_mutex_t g_devlist_mutex = PTHREAD_MUTEX_INITIALIZER; static pthread_mutex_t g_devlist_mutex = PTHREAD_MUTEX_INITIALIZER;
static spdk_new_thread_fn g_new_thread_fn = NULL;
struct io_device { struct io_device {
void *io_device; void *io_device;
char *name; char *name;
@ -147,10 +149,13 @@ _set_thread_name(const char *thread_name)
} }
int int
spdk_thread_lib_init(void) spdk_thread_lib_init(spdk_new_thread_fn new_thread_fn)
{ {
char mempool_name[SPDK_MAX_MEMZONE_NAME_LEN]; char mempool_name[SPDK_MAX_MEMZONE_NAME_LEN];
assert(g_new_thread_fn == NULL);
g_new_thread_fn = new_thread_fn;
snprintf(mempool_name, sizeof(mempool_name), "msgpool_%d", getpid()); snprintf(mempool_name, sizeof(mempool_name), "msgpool_%d", getpid());
g_spdk_msg_mempool = spdk_mempool_create(mempool_name, g_spdk_msg_mempool = spdk_mempool_create(mempool_name,
262144 - 1, /* Power of 2 minus 1 is optimal for memory consumption */ 262144 - 1, /* Power of 2 minus 1 is optimal for memory consumption */
@ -215,6 +220,10 @@ spdk_allocate_thread(const char *name)
g_thread_count++; g_thread_count++;
pthread_mutex_unlock(&g_devlist_mutex); pthread_mutex_unlock(&g_devlist_mutex);
if (g_new_thread_fn) {
g_new_thread_fn(thread);
}
return thread; return thread;
} }