From aa0dad5730c78e78bb43679d306dc936c4dca7c9 Mon Sep 17 00:00:00 2001 From: Seth Howell Date: Mon, 20 Apr 2020 18:20:53 -0700 Subject: [PATCH] module/delay_bdev: remove unreachable code. Fixing kw warning 10412. Signed-off-by: Seth Howell Change-Id: I947af63e091f56b772db886b2a126dfa3b78ffa4 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1949 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins Reviewed-by: Shuhei Matsumoto Reviewed-by: Aleksey Marchuk --- module/bdev/delay/vbdev_delay_rpc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/module/bdev/delay/vbdev_delay_rpc.c b/module/bdev/delay/vbdev_delay_rpc.c index 511471fea..58162ac7a 100644 --- a/module/bdev/delay/vbdev_delay_rpc.c +++ b/module/bdev/delay/vbdev_delay_rpc.c @@ -37,6 +37,7 @@ #include "spdk/util.h" #include "spdk/string.h" #include "spdk_internal/log.h" +#include "spdk_internal/assert.h" struct rpc_update_latency { char *delay_bdev_name; @@ -100,10 +101,7 @@ spdk_rpc_bdev_delay_update_latency(struct spdk_jsonrpc_request *request, "The requested bdev is not a delay bdev."); goto cleanup; } else if (rc) { - /* currently, only the two error cases are defined. Any new error paths should be handled here. */ - spdk_jsonrpc_send_error_response(request, SPDK_JSONRPC_ERROR_INTERNAL_ERROR, - "An unknown error occured."); - goto cleanup; + SPDK_UNREACHABLE(); } w = spdk_jsonrpc_begin_result(request);