From a9e484a660827b775283ac565782adf306a91341 Mon Sep 17 00:00:00 2001 From: Darek Stojaczyk Date: Thu, 11 Oct 2018 09:49:41 +0200 Subject: [PATCH] memory: lock global mem_map only when necessary Minor cleanup. Change-Id: I9554163ae22836b50b954ec27ed27bcb848cb193 Signed-off-by: Darek Stojaczyk Reviewed-on: https://review.gerrithub.io/428883 Tested-by: SPDK CI Jenkins Chandler-Test-Pool: SPDK Automated Test System Reviewed-by: Ben Walker Reviewed-by: Changpeng Liu --- lib/env_dpdk/memory.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/env_dpdk/memory.c b/lib/env_dpdk/memory.c index a35ea7a41..eaeccb903 100644 --- a/lib/env_dpdk/memory.c +++ b/lib/env_dpdk/memory.c @@ -258,9 +258,8 @@ spdk_mem_map_alloc(uint64_t default_translation, const struct spdk_mem_map_ops * map->ops = *ops; } - pthread_mutex_lock(&g_spdk_mem_map_mutex); - if (ops && ops->notify_cb) { + pthread_mutex_lock(&g_spdk_mem_map_mutex); rc = spdk_mem_map_notify_walk(map, SPDK_MEM_MAP_NOTIFY_REGISTER); if (rc != 0) { pthread_mutex_unlock(&g_spdk_mem_map_mutex); @@ -270,10 +269,9 @@ spdk_mem_map_alloc(uint64_t default_translation, const struct spdk_mem_map_ops * return NULL; } TAILQ_INSERT_TAIL(&g_spdk_mem_maps, map, tailq); + pthread_mutex_unlock(&g_spdk_mem_map_mutex); } - pthread_mutex_unlock(&g_spdk_mem_map_mutex); - return map; }