From a7ff5ff55809461b8686ce8ea770215dc7fc9a78 Mon Sep 17 00:00:00 2001
From: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
Date: Mon, 22 Jul 2019 15:17:03 +0200
Subject: [PATCH] env_dpdk/memory: silence scan-build errors

Scan-build complains that spdk_vtophys_notify() can segfault
on vaddr == 0. We know that and it's not a programming error.
In fact, SPDK with UIO pci driver can segfault upon registering
any non-mapped memory address. The user is just not supposed
to do that.

Assert vaddr != 0 to silence scan-build.

Change-Id: I9a14696361eca0aeea5ede9f9f2956fcbf59bdb5
Signed-off-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/462869
Reviewed-by: yidong0635 <dongx.yi@intel.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
---
 lib/env_dpdk/memory.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/env_dpdk/memory.c b/lib/env_dpdk/memory.c
index f3f3730da..706471ef8 100644
--- a/lib/env_dpdk/memory.c
+++ b/lib/env_dpdk/memory.c
@@ -935,6 +935,8 @@ vtophys_get_paddr_pagemap(uint64_t vaddr)
 {
 	uintptr_t paddr;
 
+	/* Silence static analyzers */
+	assert(vaddr != 0);
 	paddr = rte_mem_virt2iova((void *)vaddr);
 	if (paddr == RTE_BAD_IOVA) {
 		/*