ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ut/scsi/dev: fix memory leak in lun_construct stub

Browse Source 
Check if a LUN already exists before allocating the spdk_scsi_lun
structure - this matches the real implementation of
spdk_scsi_lun_construct().

Fixes: e44731d659 ("scsi: Remove the claimed flag from LUN")

Change-Id: I529648f93cd21e9f19ce82ef571cabe9c7e8c49a
Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
Reviewed-on: https://review.gerrithub.io/390903
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
This commit is contained in:
Daniel Verkamp 2017-12-07 14:28:44 -07:00
parent deddb8d831
commit a7d816bfbe
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
test/unit/lib/scsi/dev.c/dev_ut.c
View File

@ -97,18 +97,18 @@ spdk_scsi_lun_construct(const char *name, struct spdk_bdev *bdev,
struct spdk_scsi_lun *lun; struct spdk_scsi_lun *lun;
struct lun_entry *p; struct lun_entry *p;
lun = calloc(1, sizeof(struct spdk_scsi_lun));
SPDK_CU_ASSERT_FATAL(lun != NULL);
snprintf(lun->name, sizeof(lun->name), "%s", name);
lun->bdev = bdev;
TAILQ_FOREACH(p, &g_lun_head, lun_entries) { TAILQ_FOREACH(p, &g_lun_head, lun_entries) {
CU_ASSERT_FATAL(p->lun != NULL); CU_ASSERT_FATAL(p->lun != NULL);
if (strncmp(p->lun->name, lun->name, sizeof(lun->name)) == 0) if (strcmp(p->lun->name, name) == 0) {
return NULL; return NULL;
}
} }
lun = calloc(1, sizeof(struct spdk_scsi_lun));
SPDK_CU_ASSERT_FATAL(lun != NULL);
snprintf(lun->name, sizeof(lun->name), "%s", name);
lun->bdev = bdev;
p = calloc(1, sizeof(struct lun_entry)); p = calloc(1, sizeof(struct lun_entry));
SPDK_CU_ASSERT_FATAL(p != NULL); SPDK_CU_ASSERT_FATAL(p != NULL);