ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

lib/vfio_user: change the calculation of bar_addr

Browse Source 
When calculating the bar_addr which is used to access SPARSE MMAP area, we should use the
(offset - region->mmaps[i].offset) as the increment to get the valid access address.

Signed-off-by: Jun Zeng <jun1.zeng@intel.com>
Change-Id: Ie5d0c63cf572847d15dc92f0995fddecf35f1cdc
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/13021
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Xiaodong Liu <xiaodong.liu@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Dong Yi <dongx.yi@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
This commit is contained in:
Jun Zeng 2022-06-13 16:47:42 +08:00 committed by Tomasz Zawadzki
parent bc0c0bd009
commit a773ed9a9a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/vfio_user/host/vfio_user_pci.c
View File

@ -38,7 +38,7 @@ spdk_vfio_user_pci_bar_access(struct vfio_device *dev, uint32_t index, uint64_t
if ((offset >= region->mmaps[i].offset) && if ((offset >= region->mmaps[i].offset) &&
(offset + len <= region->mmaps[i].offset + region->mmaps[i].size)) { (offset + len <= region->mmaps[i].offset + region->mmaps[i].size)) {
assert(region->mmaps[i].mem != NULL); assert(region->mmaps[i].mem != NULL);
void *bar_addr = region->mmaps[i].mem + offset; void *bar_addr = region->mmaps[i].mem + offset - region->mmaps[i].offset;
if (is_write) { if (is_write) {
memcpy(bar_addr, buf, len); memcpy(bar_addr, buf, len);
} else { } else {