From a6b0b5b072c75198865fdb2b3e50ad949e464c5a Mon Sep 17 00:00:00 2001 From: Shuhei Matsumoto Date: Tue, 31 Jan 2023 11:54:56 +0900 Subject: [PATCH] bdev: Use error_response() rather than bool_response(false) for JSON RPC For JSON RPC, boolean response with false value may not be regarded as error. Previously many cases were replaced to use spdk_jsonrpc_send_error_response() explicitly. Replace one of the remaining cases in this patch. Signed-off-by: Shuhei Matsumoto Change-Id: I1b4ffe015c2b2e28d411faf7763c2baca81f66f5 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16623 Reviewed-by: Jim Harris Reviewed-by: Aleksey Marchuk Tested-by: SPDK CI Jenkins --- lib/bdev/bdev_rpc.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/bdev/bdev_rpc.c b/lib/bdev/bdev_rpc.c index 339bfce97..a718c856f 100644 --- a/lib/bdev/bdev_rpc.c +++ b/lib/bdev/bdev_rpc.c @@ -1084,7 +1084,11 @@ bdev_histogram_status_cb(void *cb_arg, int status) { struct spdk_jsonrpc_request *request = cb_arg; - spdk_jsonrpc_send_bool_response(request, status == 0); + if (status == 0) { + spdk_jsonrpc_send_bool_response(request, true); + } else { + spdk_jsonrpc_send_error_response(request, status, spdk_strerror(-status)); + } } static void