From a58611d5134e864eb4aff24a5b9f67bdacb67d8d Mon Sep 17 00:00:00 2001 From: Shuhei Matsumoto Date: Mon, 25 Dec 2017 10:11:25 +0900 Subject: [PATCH] iscsi: Remove unused macro constants Remove unused macro constants of iSCSI. MAX_PORTAL, MAX_INITIATOR, MAX_NETMASK are still used to determine buffer size for JSON-RPC and iSCSI.conf and are not removed in this patch yet. Change-Id: I3036dc472eca09eff7fa3f6ea7e8e28b0978358f Signed-off-by: Shuhei Matsumoto Reviewed-on: https://review.gerrithub.io/392912 Tested-by: SPDK Automated Test System Reviewed-by: Daniel Verkamp Reviewed-by: Ben Walker --- etc/spdk/iscsi.conf.in | 2 +- lib/iscsi/iscsi.h | 4 ---- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/etc/spdk/iscsi.conf.in b/etc/spdk/iscsi.conf.in index 32ba448dd..58e1907eb 100644 --- a/etc/spdk/iscsi.conf.in +++ b/etc/spdk/iscsi.conf.in @@ -67,7 +67,7 @@ # PortalGroup sections define which network portals the iSCSI target # will use to listen for incoming connections. These are also used to # determine which targets are accessible over each portal group. -# Up to 1024 Portal directives are allowed. These define the network +# Up to 1024 portal directives are allowed. These define the network # portals of the portal group. The user must specify a IP address # for each network portal, and may optionally specify a port and # a cpumask. If the port is omitted, 3260 will be used. Cpumask will diff --git a/lib/iscsi/iscsi.h b/lib/iscsi/iscsi.h index dcfbbd8e7..a3df3f21c 100644 --- a/lib/iscsi/iscsi.h +++ b/lib/iscsi/iscsi.h @@ -54,13 +54,9 @@ #define MAX_INITIATOR_NAME 256 #define MAX_TARGET_NAME 256 -#define MAX_ISCSI_NAME 256 - #define MAX_PORTAL 1024 #define MAX_INITIATOR 256 #define MAX_NETMASK 256 -#define MAX_PORTAL_GROUP 4096 -#define MAX_INITIATOR_GROUP 4096 #define MAX_SESSIONS 1024 #define MAX_ISCSI_CONNECTIONS MAX_SESSIONS #define MAX_FIRSTBURSTLENGTH 16777215