ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

splite/vbdev_split: Free base part bdev on the error path.

Browse Source 
spdk_bdev_part_base_construct_ext is called by spdk_bdev_part_base_construct.
there's already an example if a base bdev is an abnormal case we need to do
spdk_bdev_part_base_free to close the base bdev.

From constructing a successful part base bdev util finishing vbdev_split_create.
there're except failure cases to exit.

if a bdev is open and when runs into bdev_unregister_unsafe, it's in an EBUSY
state, bdev will not finished from the list. That spdk_io_device_unregister
will no be executed in spdk_bdev_unregister.

That a subsytem with it callback which is app_reactors_stop can't be finished.

Signed-off-by: yidong0635 <dongx.yi@intel.com>
Change-Id: Idc156557f936da5f2618421ede2619f1f2e29c51
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/6599
Community-CI: Broadcom CI
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
This commit is contained in:
yidong0635 2021-02-26 11:51:37 +08:00 committed by Tomasz Zawadzki
parent 81525cc449
commit a497ee9b56
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
module/bdev/split/vbdev_split.c
View File

@ -317,6 +317,7 @@ vbdev_split_create(struct spdk_vbdev_split_config *cfg)
err: err:
split_base_tailq = spdk_bdev_part_base_get_tailq(cfg->split_base); split_base_tailq = spdk_bdev_part_base_get_tailq(cfg->split_base);
spdk_bdev_part_base_hotremove(cfg->split_base, split_base_tailq); spdk_bdev_part_base_hotremove(cfg->split_base, split_base_tailq);
spdk_bdev_part_base_free(cfg->split_base);
return rc; return rc;
} }