From a4881cf82f30af4d8981b4a652f4abaf6e454dbb Mon Sep 17 00:00:00 2001 From: Wojciech Malikowski Date: Tue, 23 Jul 2019 04:34:34 -0400 Subject: [PATCH] lib/ftl: Check if write buffer is empty during shutdown Added assertion to check is there is no any acquired write buffer entries during shutdown. Change-Id: I92be8ff07b2bf338acb65a0e37d0cc6ad6962d81 Signed-off-by: Wojciech Malikowski Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/462934 Tested-by: SPDK CI Jenkins Reviewed-by: Ben Walker Reviewed-by: Jim Harris Reviewed-by: Konrad Sztyber Reviewed-by: Paul Luse Reviewed-by: Mateusz Kozlowski --- lib/ftl/ftl_init.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/ftl/ftl_init.c b/lib/ftl/ftl_init.c index a28a3d1cb..fef7f2f40 100644 --- a/lib/ftl/ftl_init.c +++ b/lib/ftl/ftl_init.c @@ -1221,6 +1221,8 @@ ftl_dev_free_sync(struct spdk_ftl_dev *dev) pthread_mutex_unlock(&g_ftl_queue_lock); assert(LIST_EMPTY(&dev->wptr_list)); + assert(ftl_rwb_num_acquired(dev->rwb, FTL_RWB_TYPE_INTERNAL) == 0); + assert(ftl_rwb_num_acquired(dev->rwb, FTL_RWB_TYPE_USER) == 0); ftl_dev_dump_bands(dev); ftl_dev_dump_stats(dev);