ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

mk: replace [[ command with /dev/null redirection

Browse Source 
make uses /bin/sh as its shell and some distributions set it to shells
that don't support [[ command (e.g. ubuntu and dash).  This causes the
check to fail with the following error:

/bin/sh: 1: [[: not found

So, replaced the [[ command with a redirection to /dev/null, which
should work on all shells.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: Idcae094e8faa3da6faac16754bb0484bd91363d8
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15852
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Mike Gerdts <mgerdts@nvidia.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Community-CI: Mellanox Build Bot
This commit is contained in:
Konrad Sztyber 2022-12-08 11:46:02 +01:00 committed by Tomasz Zawadzki
parent 36f8f8da27
commit a3ec812b09
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
mk/spdk.common.mk
View File

@ -71,7 +71,7 @@ COMMON_CFLAGS += -march=$(TARGET_ARCHITECTURE)
endif endif
ifeq ($(TARGET_MACHINE),x86_64) ifeq ($(TARGET_MACHINE),x86_64)
ifneq (,$(shell [[ $$($(CC) --target-help) == *-mavx512f* ]] && echo 1)) ifneq (,$(shell $(CC) --target-help | grep -e -mavx512f >/dev/null && echo 1))
# Don't use AVX-512 instructions in SPDK code - it breaks Valgrind for # Don't use AVX-512 instructions in SPDK code - it breaks Valgrind for
# some cases where compiler decides to hyper-optimize a relatively # some cases where compiler decides to hyper-optimize a relatively
# simple operation (like int-to-float conversion) using AVX-512 # simple operation (like int-to-float conversion) using AVX-512