ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ftl: verify LBA format is supported

Browse Source 
Verify that the namespace used is formatted with a supported LBA format
(4K block size).

Change-Id: I59e2ed71354e8530d9fa0e3f6b323ded83097afa
Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-on: https://review.gerrithub.io/c/441881
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: Wojciech Malikowski <wojciech.malikowski@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
This commit is contained in:
Konrad Sztyber 2019-01-24 11:14:50 +01:00 committed by Changpeng Liu
parent f2b480cc24
commit a3777e3f11
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
lib/ftl/ftl_init.c
View File

@ -403,9 +403,9 @@ out:
static int static int
ftl_dev_nvme_init(struct spdk_ftl_dev *dev, const struct spdk_ftl_dev_init_opts *opts) ftl_dev_nvme_init(struct spdk_ftl_dev *dev, const struct spdk_ftl_dev_init_opts *opts)
{ {
dev->ctrlr = opts->ctrlr; uint32_t block_size;
assert(dev->ctrlr != NULL); dev->ctrlr = opts->ctrlr;
if (spdk_nvme_ctrlr_get_num_ns(dev->ctrlr) != 1) { if (spdk_nvme_ctrlr_get_num_ns(dev->ctrlr) != 1) {
SPDK_ERRLOG("Unsupported number of namespaces\n"); SPDK_ERRLOG("Unsupported number of namespaces\n");
@ -415,6 +415,13 @@ ftl_dev_nvme_init(struct spdk_ftl_dev *dev, const struct spdk_ftl_dev_init_opts
dev->ns = spdk_nvme_ctrlr_get_ns(dev->ctrlr, FTL_NSID); dev->ns = spdk_nvme_ctrlr_get_ns(dev->ctrlr, FTL_NSID);
dev->trid = opts->trid; dev->trid = opts->trid;
dev->md_size = spdk_nvme_ns_get_md_size(dev->ns); dev->md_size = spdk_nvme_ns_get_md_size(dev->ns);
block_size = spdk_nvme_ns_get_extended_sector_size(dev->ns);
if (block_size != FTL_BLOCK_SIZE) {
SPDK_ERRLOG("Unsupported block size (%"PRIu32")\n", block_size);
return -1;
}
if (dev->md_size % sizeof(uint32_t) != 0) { if (dev->md_size % sizeof(uint32_t) != 0) {
/* Metadata pointer must be dword aligned */ /* Metadata pointer must be dword aligned */
SPDK_ERRLOG("Unsupported metadata size (%zu)\n", dev->md_size); SPDK_ERRLOG("Unsupported metadata size (%zu)\n", dev->md_size);