ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

vhost/nvme: remove cmd and cqe magic numbers

Browse Source 
Replace the hard-coded 64 and 16 constants, which are the size of the
submission queue entry and completion queue entry, with equivalent
sizeof expressions.

Change-Id: I5a9d8fc1ab98276312445f0699aae3d86beee705
Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
Reviewed-on: https://review.gerrithub.io/408762
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
This commit is contained in:
Daniel Verkamp 2018-04-23 15:34:20 -07:00 committed by Changpeng Liu
parent 80e7107811
commit a32ba31665
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/vhost/rte_vhost/vhost_user.c
View File

@ -1185,10 +1185,10 @@ vhost_user_msg_handler(int vid, int fd)
if (!dev->is_nvme) {
dev->is_nvme = 1;
}
memcpy(cmd, &msg.payload.nvme.cmd, 64);
memcpy(cmd, msg.payload.nvme.cmd.req, sizeof(cmd));
ret = vhost_user_nvme_admin_passthrough(dev, cmd, cqe, buf);
memcpy(&msg.payload.nvme.cmd, &cqe, 16);
msg.size = 16;
memcpy(msg.payload.nvme.cmd.cqe, cqe, sizeof(cqe));
msg.size = sizeof(cqe);
/* NVMe Identify Command */
if (cmd[0] == 0x06) {
memcpy(msg.payload.nvme.buf, &buf, 4096);