From a2a29abcfb0aed1fc56ee73dd781a7c80881bc1e Mon Sep 17 00:00:00 2001 From: Jim Harris Date: Tue, 16 Jan 2018 20:50:40 -0700 Subject: [PATCH] blob: remove sequence/batch operations for flush These were unused in blobstore so remove them for now. This reduces number of code changes in some upcoming patches. Signed-off-by: Jim Harris Change-Id: I02e04f7d84fff1d2a70f371d222425f373a5d4ff Reviewed-on: https://review.gerrithub.io/395016 Tested-by: SPDK Automated Test System Reviewed-by: Ben Walker Reviewed-by: Maciej Szwed Reviewed-by: Reviewed-by: Tomasz Zawadzki Reviewed-by: Daniel Verkamp --- lib/blob/request.c | 29 ----------------------------- lib/blob/request.h | 5 ----- 2 files changed, 34 deletions(-) diff --git a/lib/blob/request.c b/lib/blob/request.c index 1f64ddf3b..bce25638f 100644 --- a/lib/blob/request.c +++ b/lib/blob/request.c @@ -213,22 +213,6 @@ spdk_bs_sequence_writev(spdk_bs_sequence_t *seq, struct iovec *iov, int iovcnt, &set->cb_args); } -void -spdk_bs_sequence_flush(spdk_bs_sequence_t *seq, - spdk_bs_sequence_cpl cb_fn, void *cb_arg) -{ - struct spdk_bs_request_set *set = (struct spdk_bs_request_set *)seq; - struct spdk_bs_channel *channel = set->channel; - - SPDK_DEBUGLOG(SPDK_LOG_BLOB_RW, "Flushing\n"); - - set->u.sequence.cb_fn = cb_fn; - set->u.sequence.cb_arg = cb_arg; - - channel->dev->flush(channel->dev, channel->dev_channel, - &set->cb_args); -} - void spdk_bs_sequence_unmap(spdk_bs_sequence_t *seq, uint64_t lba, uint32_t lba_count, @@ -361,19 +345,6 @@ spdk_bs_batch_write(spdk_bs_batch_t *batch, void *payload, &set->cb_args); } -void -spdk_bs_batch_flush(spdk_bs_batch_t *batch) -{ - struct spdk_bs_request_set *set = (struct spdk_bs_request_set *)batch; - struct spdk_bs_channel *channel = set->channel; - - SPDK_DEBUGLOG(SPDK_LOG_BLOB_RW, "Flushing\n"); - - set->u.batch.outstanding_ops++; - channel->dev->flush(channel->dev, channel->dev_channel, - &set->cb_args); -} - void spdk_bs_batch_unmap(spdk_bs_batch_t *batch, uint64_t lba, uint32_t lba_count) diff --git a/lib/blob/request.h b/lib/blob/request.h index 31e5d8f85..95f82d116 100644 --- a/lib/blob/request.h +++ b/lib/blob/request.h @@ -155,9 +155,6 @@ void spdk_bs_sequence_writev(spdk_bs_batch_t *batch, struct iovec *iov, int iovc uint64_t lba, uint32_t lba_count, spdk_bs_sequence_cpl cb_fn, void *cb_arg); -void spdk_bs_sequence_flush(spdk_bs_sequence_t *seq, - spdk_bs_sequence_cpl cb_fn, void *cb_arg); - void spdk_bs_sequence_unmap(spdk_bs_sequence_t *seq, uint64_t lba, uint32_t lba_count, spdk_bs_sequence_cpl cb_fn, void *cb_arg); @@ -180,8 +177,6 @@ void spdk_bs_batch_read(spdk_bs_batch_t *batch, void *payload, void spdk_bs_batch_write(spdk_bs_batch_t *batch, void *payload, uint64_t lba, uint32_t lba_count); -void spdk_bs_batch_flush(spdk_bs_batch_t *batch); - void spdk_bs_batch_unmap(spdk_bs_batch_t *batch, uint64_t lba, uint32_t lba_count);