ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

nvmf/tcp: Fix the error return code

Browse Source 
It should return "NVME_TCP_PDU_FATAL". I think that
this issue is introduced after we move the data
copy from tcp transport layer to the socket
layer. And it should return "NVME_TCP_PDU_FATAL now",
and it will be consistent with the logic in the same
function.

With this patch, it will fix the big I/O size write
from the initiator.

Signed-off-by: Ziye Yang <ziye.yang@intel.com>
Change-Id: Ide018adb603eb13d002fc98886258dd1e2424f7c
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/3122
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Community-CI: Mellanox Build Bot
Community-CI: Broadcom CI
This commit is contained in:
Ziye Yang 2020-07-01 04:15:25 +08:00 committed by Tomasz Zawadzki
parent 65d14fd9dd
commit a213592c89
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/nvmf/tcp.c
View File

@ -1785,7 +1785,7 @@ nvmf_tcp_sock_process(struct spdk_nvmf_tcp_qpair *tqpair)
rc = nvme_tcp_read_payload_data(tqpair->sock, pdu); rc = nvme_tcp_read_payload_data(tqpair->sock, pdu);
if (rc < 0) { if (rc < 0) {
return NVME_TCP_PDU_IN_PROGRESS; return NVME_TCP_PDU_FATAL;
} }
pdu->readv_offset += rc; pdu->readv_offset += rc;