From 9e9cd51f55ad6319f1ce0067f23d3aac2ba8c932 Mon Sep 17 00:00:00 2001 From: Daniel Verkamp Date: Wed, 30 May 2018 14:38:43 -0700 Subject: [PATCH] test/nvme_ns_cmd: zero-initialize ctrlr options A recently-added test now uses a controller option value that was previously uninitialized. Set them to all zeroes to avoid a Valgrind warning about using uninitialized data. Change-Id: I4454b781b7aec27e6d4f4dd8ff5cb059270551e9 Fixes: fbf06aca1a63 ("nvme: fail when request is too long") Signed-off-by: Daniel Verkamp Reviewed-on: https://review.gerrithub.io/413017 Reviewed-by: Jim Harris Reviewed-by: Ben Walker Tested-by: SPDK Automated Test System --- test/unit/lib/nvme/nvme_ns_cmd.c/nvme_ns_cmd_ut.c | 1 + 1 file changed, 1 insertion(+) diff --git a/test/unit/lib/nvme/nvme_ns_cmd.c/nvme_ns_cmd_ut.c b/test/unit/lib/nvme/nvme_ns_cmd.c/nvme_ns_cmd_ut.c index af7b18d01..cceb7de99 100644 --- a/test/unit/lib/nvme/nvme_ns_cmd.c/nvme_ns_cmd_ut.c +++ b/test/unit/lib/nvme/nvme_ns_cmd.c/nvme_ns_cmd_ut.c @@ -212,6 +212,7 @@ prepare_for_test(struct spdk_nvme_ns *ns, struct spdk_nvme_ctrlr *ctrlr, ctrlr->flags = 0; ctrlr->min_page_size = 4096; ctrlr->page_size = 4096; + memset(&ctrlr->opts, 0, sizeof(ctrlr->opts)); memset(ns, 0, sizeof(*ns)); ns->ctrlr = ctrlr; ns->sector_size = sector_size;