From 9e239b1c1eccdaf78c08dbec2b9e919cd634d42b Mon Sep 17 00:00:00 2001
From: John Levon <john.levon@nutanix.com>
Date: Tue, 8 Mar 2022 12:45:49 +0000
Subject: [PATCH] lib/nvme: remove needless check

nvme_pcie_qpair_update_mmio_required() is only called for QPs with
shadow doorbells enabled, so we don't need an additional branch here.

Signed-off-by: John Levon <john.levon@nutanix.com>
Change-Id: Idf65f92deb0c6f93019892ef5a02bc28ba4c0f8c
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/11843
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
---
 lib/nvme/nvme_pcie_internal.h | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/lib/nvme/nvme_pcie_internal.h b/lib/nvme/nvme_pcie_internal.h
index 8cc64559c..e58da1615 100644
--- a/lib/nvme/nvme_pcie_internal.h
+++ b/lib/nvme/nvme_pcie_internal.h
@@ -249,10 +249,6 @@ nvme_pcie_qpair_update_mmio_required(uint16_t value,
 {
 	uint16_t old;
 
-	if (!shadow_db) {
-		return true;
-	}
-
 	spdk_wmb();
 
 	old = *shadow_db;