From 9e03923b95b3362ff51ab7aeff22c376bb316638 Mon Sep 17 00:00:00 2001 From: Konrad Sztyber Date: Mon, 4 Jul 2022 08:49:27 +0200 Subject: [PATCH] rpc: fix zerocopy_threshold in sock_impl_set_options This shouldn't be an on/off option, but should expect an integer value specyfing the number of bytes. Signed-off-by: Konrad Sztyber Change-Id: I888af3253ad619a6c5f86e6d35454dafe8fc09a0 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/13540 Community-CI: Broadcom CI Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins Reviewed-by: Dong Yi Reviewed-by: Changpeng Liu Reviewed-by: Tomasz Zawadzki Reviewed-by: Aleksey Marchuk --- scripts/rpc.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/scripts/rpc.py b/scripts/rpc.py index eeec4b1be..b2b0d7d17 100755 --- a/scripts/rpc.py +++ b/scripts/rpc.py @@ -2826,8 +2826,7 @@ Format: 'user:u1 secret:s1 muser:mu1 msecret:ms1,user:u2 secret:s2 muser:mu2 mse action='store_true', dest='enable_zerocopy_send_client') p.add_argument('--disable-zerocopy-send-client', help='Disable zerocopy on send for client sockets', action='store_false', dest='enable_zerocopy_send_client') - p.add_argument('--zerocopy-threshold', help='Set zerocopy_threshold in bytes', - action='store_true', dest='zerocopy_threshold') + p.add_argument('--zerocopy-threshold', help='Set zerocopy_threshold in bytes', type=int) p.set_defaults(func=sock_impl_set_options, enable_recv_pipe=None, enable_quickack=None, enable_placement_id=None, enable_zerocopy_send_server=None, enable_zerocopy_send_client=None, zerocopy_threshold=None)