ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test/vhost: Vhost scsi hotremove test plan

Browse Source 
Change-Id: I3d6a62499326046bb856ff8ca4d906295f5cd027
Signed-off-by: Pawel Kaminski <pawelx.kaminski@intel.com>
Reviewed-on: https://review.gerrithub.io/401173
Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: Karol Latecki <karol.latecki@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
This commit is contained in:
Pawel Kaminski 2018-02-23 14:05:08 -05:00 committed by Jim Harris
parent 84918cd9fa
commit 9df7fac17f
2 changed files with 68 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/vhost/hotplug/scsi_hotplug.sh
View File

@ -66,6 +66,8 @@ function clear_vhost_config() {
trap 'error_exit "${FUNCNAME}" "${LINENO}"' ERR
gen_config
# Hotremove/hotattach/hotdetach test cases prerequisites
# 1. Run vhost with 2 NVMe disks.
run_vhost
rm $BASE_DIR/vhost.conf.in
if [[ $scsi_hot_remove_test == 0 ]] && [[ $blk_hot_remove_test == 0 ]]; then

66
test/vhost/hotplug/scsi_hotremove.sh
View File

@ -1,5 +1,20 @@
set -xe
# Vhost SCSI hotremove tests
#
# # Objective
# The purpose of these tests is to verify that SPDK vhost remains stable during
# hot-remove operations performed on SCSI controllers devices.
# Hot-remove is a scenario where a NVMe device is removed when already in use.
# Tests consist of 4 test cases.
#
# # Test cases description
# 1. FIO I/O traffic is run during hot-remove operations.
# By default FIO uses default_integrity*.job config files located in
# test/vhost/hotplug/fio_jobs directory.
# 2. FIO mode of operation is random write (randwrite) with verification enabled
# which results in also performing read operations.
function prepare_fio_cmd_tc1() {
print_test_fio_header
@ -19,42 +34,63 @@ function prepare_fio_cmd_tc1() {
done
}
# Vhost SCSI hot-remove test cases.
# Test Case 1
function scsi_hotremove_tc1() {
echo "Scsi hotremove test case 1"
traddr=""
get_traddr "Nvme0"
# 1. Run the command to hot remove NVMe disk.
delete_nvme "Nvme0n1"
# 2. If vhost had crashed then tests would stop running
sleep 1
add_nvme "HotInNvme0" "$traddr"
}
# Test Case 2
function scsi_hotremove_tc2() {
echo "Scsi hotremove test case 2"
# 1. Attach split NVMe bdevs to scsi controller.
$rpc_py add_vhost_scsi_lun naa.Nvme0n1p0.0 0 HotInNvme0n1p0
$rpc_py add_vhost_scsi_lun naa.Nvme0n1p1.0 0 Nvme1n1p0
$rpc_py add_vhost_scsi_lun naa.Nvme0n1p2.1 0 HotInNvme0n1p1
$rpc_py add_vhost_scsi_lun naa.Nvme0n1p3.1 0 Nvme1n1p1
# 2. Run two VMs, attached to scsi controllers.
vms_setup
vm_run_with_arg 0 1
vms_prepare "0 1"
vm_check_scsi_location "0"
local disks="$SCSI_DISK"
traddr=""
get_traddr "Nvme0"
prepare_fio_cmd_tc1 "0 1"
# 3. Run FIO I/O traffic with verification enabled on on both NVMe disks in VM.
$run_fio &
local last_pid=$!
sleep 3
# 4. Run the command to hot remove NVMe disk.
delete_nvme "HotInNvme0n1"
# 5. Check that fio job run on hot-remove device stopped on VM.
# Expected: Fio should return error message and return code != 0.
set +xe
wait $last_pid
check_fio_retcode "Scsi hotremove test case 2: Iteration 1." 1 $?
# 6. Check if removed devices are gone from VM.
vm_check_scsi_location "0"
local new_disks="$SCSI_DISK"
check_disks "$disks" "$new_disks"
# 7. Reboot both VMs.
reboot_all_and_prepare "0 1"
# 8. Run FIO I/O traffic with verification enabled on on both VMs.
$run_fio
# 9. Check that fio job run on hot-remove device stopped on both VMs.
# Expected: Fio should return error message and return code != 0.
check_fio_retcode "Scsi hotremove test case 2: Iteration 2." 1 $?
set -xe
vm_shutdown_all
@ -62,28 +98,40 @@ function scsi_hotremove_tc2() {
sleep 1
}
# Test Case 3
function scsi_hotremove_tc3() {
echo "Scsi hotremove test case 3"
# 1. Attach added NVMe bdev to scsi controller.
$rpc_py add_vhost_scsi_lun naa.Nvme0n1p0.0 0 HotInNvme1n1p0
# 2. Run two VM, attached to scsi controllers.
vm_run_with_arg 0 1
vms_prepare "0 1"
vm_check_scsi_location "0"
local disks="$SCSI_DISK"
traddr=""
get_traddr "Nvme0"
# 3. Run FIO I/O traffic with verification enabled on on both NVMe disks in VMs.
prepare_fio_cmd_tc1 "0"
$run_fio &
local last_pid=$!
sleep 3
# 4. Run the command to hot remove NVMe disk.
delete_nvme "HotInNvme1n1"
# 5. Check that fio job run on hot-remove device stopped on first VM.
# Expected: Fio should return error message and return code != 0.
set +xe
wait $last_pid
check_fio_retcode "Scsi hotremove test case 3: Iteration 1." 1 $?
# 6. Check if removed devices are gone from lsblk.
vm_check_scsi_location "0"
local new_disks="$SCSI_DISK"
check_disks "$disks" "$new_disks"
# 7. Reboot both VMs.
reboot_all_and_prepare "0 1"
# 8. Run FIO I/O traffic with verification enabled on on both VMs.
$run_fio
# 9. Check that fio job run on hot-remove device stopped on both VMs.
# Expected: Fio should return error message and return code != 0.
check_fio_retcode "Scsi hotremove test case 3: Iteration 2." 1 $?
set -xe
vm_shutdown_all
@ -91,18 +139,24 @@ function scsi_hotremove_tc3() {
sleep 1
}
# Test Case 4
function scsi_hotremove_tc4() {
echo "Scsi hotremove test case 4"
# 1. Attach NVMe bdevs to scsi controllers.
$rpc_py add_vhost_scsi_lun naa.Nvme0n1p0.0 0 HotInNvme2n1p0
$rpc_py add_vhost_scsi_lun naa.Nvme0n1p2.1 0 HotInNvme2n1p1
# 2. Run two VMs, attach to scsi controller.
vm_run_with_arg 0 1
vms_prepare "0 1"
# 3. Run FIO I/O traffic with verification enabled on first VM.
vm_check_scsi_location "0"
local disks_vm0="$SCSI_DISK"
# 4. Run FIO I/O traffic with verification enabled on second VM.
prepare_fio_cmd_tc1 "0"
$run_fio &
last_pid_vm0=$!
vm_check_scsi_location "1"
local disks_vm1="$SCSI_DISK"
prepare_fio_cmd_tc1 "1"
@ -110,9 +164,12 @@ function scsi_hotremove_tc4() {
local last_pid_vm1=$!
prepare_fio_cmd_tc1 "0 1"
sleep 3
# 5. Run the command to hot remove NVMe disk.
traddr=""
get_traddr "Nvme0"
delete_nvme "HotInNvme2n1"
# 6. Check that fio job run on hot-removed devices stopped.
# Expected: Fio should return error message and return code != 0.
set +xe
wait $last_pid_vm0
local retcode_vm0=$?
@ -120,6 +177,7 @@ function scsi_hotremove_tc4() {
local retcode_vm1=$?
check_fio_retcode "Scsi hotremove test case 4: Iteration 1." 1 $retcode_vm0
# 7. Check if removed devices are gone from lsblk.
vm_check_scsi_location "0"
local new_disks_vm0="$SCSI_DISK"
check_disks "$disks_vm0" "$new_disks_vm0"
@ -128,11 +186,19 @@ function scsi_hotremove_tc4() {
local new_disks_vm1="$SCSI_DISK"
check_disks "$disks_vm1" "$new_disks_vm1"
# 8. Reboot both VMs.
reboot_all_and_prepare "0 1"
# 9. Run FIO I/O traffic with verification enabled on on not-removed NVMe disk.
$run_fio
# 10. Check that fio job run on hot-removed device stopped.
# Expect: Fio should return error message and return code != 0.
check_fio_retcode "Scsi hotremove test case 4: Iteration 3." 1 $?
prepare_fio_cmd_tc1 "0 1"
# 11. Run FIO I/O traffic with verification enabled on on not-removed NVMe disk.
$run_fio
# 12. Check finished status FIO. Write and read in the not-removed.
# NVMe disk should be successful.
# Expected: Fio should return return code == 0.
check_fio_retcode "Scsi hotremove test case 4: Iteration 4." 0 $?
set -xe
vm_shutdown_all