From 9d3742e0cbb1d86912267b39e57f1c75015048d8 Mon Sep 17 00:00:00 2001 From: Maciej Wawryk Date: Thu, 10 Oct 2019 10:26:32 +0200 Subject: [PATCH] test: Shellcheck - include check SC1001 Remove from shellcheck excluded SC1001: This \o will be a regular 'o' in this context. This warning is not actually present in any of spdk/spdk scripts. Additionally clean up shellcheck exclude list. Signed-off-by: Maciej Wawryk Change-Id: Ia9a9ec9383df02702397072172830fb147effe81 Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/470913 Tested-by: SPDK CI Jenkins Reviewed-by: Tomasz Zawadzki Reviewed-by: Jim Harris Reviewed-by: Ben Walker Reviewed-by: Karol Latecki --- scripts/check_format.sh | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/scripts/check_format.sh b/scripts/check_format.sh index 4f509207a..eb2d4707d 100755 --- a/scripts/check_format.sh +++ b/scripts/check_format.sh @@ -240,11 +240,8 @@ if hash shellcheck 2>/dev/null; then # go to: https://trello.com/c/29Z90j1W # Error descriptions can also be found at: https://github.com/koalaman/shellcheck/wiki # This SHCK_EXCLUDE list is out "to do" and we work to fix all of this errors. - SHCK_EXCLUDE="SC1001,\ -SC1083,SC2002,SC2004,\ -SC2010,SC2012,SC2013,SC2016,\ -SC2034,SC2045,SC2046,\ -SC2068,SC2086,SC2089,SC2090,\ + SHCK_EXCLUDE="SC1083,SC2002,SC2004,\ +SC2010,SC2012,SC2013,SC2016,SC2034,SC2045,SC2046,SC2068,SC2086,SC2089,SC2090,\ SC2097,SC2098,SC2103,SC2115,SC2116,SC2119,SC2120,SC2121,SC2124,SC2126,SC2128,\ SC2129,SC2140,SC2142,SC2143,SC2145,SC2146,SC2148,SC2152,SC2153,SC2154,SC2155,\ SC2162,SC2164,SC2165,SC2166,SC2167,SC2174,\