diff --git a/lib/nvmf/ctrlr.c b/lib/nvmf/ctrlr.c index b66d53b2f..7816d7c3d 100644 --- a/lib/nvmf/ctrlr.c +++ b/lib/nvmf/ctrlr.c @@ -124,7 +124,7 @@ _spdk_nvmf_ctrlr_disconnect_qpairs_on_pg(struct spdk_io_channel_iter *i, bool in group = spdk_io_channel_get_ctx(ch); TAILQ_FOREACH_SAFE(qpair, &group->qpairs, link, temp_qpair) { - if (qpair->ctrlr == ctrlr && (include_admin || !spdk_nvmf_qpair_is_admin_queue(qpair))) { + if (qpair->ctrlr == ctrlr && (include_admin || !nvmf_qpair_is_admin_queue(qpair))) { rc = spdk_nvmf_qpair_disconnect(qpair, NULL, NULL); if (rc) { SPDK_ERRLOG("Qpair disconnect failed\n"); @@ -263,7 +263,7 @@ _spdk_nvmf_subsystem_add_ctrlr(void *ctx) struct spdk_nvmf_fabric_connect_rsp *rsp = &req->rsp->connect_rsp; struct spdk_nvmf_ctrlr *ctrlr = qpair->ctrlr; - if (spdk_nvmf_subsystem_add_ctrlr(ctrlr->subsys, ctrlr)) { + if (nvmf_subsystem_add_ctrlr(ctrlr->subsys, ctrlr)) { SPDK_ERRLOG("Unable to add controller to subsystem\n"); spdk_bit_array_free(&ctrlr->qpair_mask); free(ctrlr); @@ -396,9 +396,9 @@ _spdk_nvmf_ctrlr_destruct(void *ctx) } void -spdk_nvmf_ctrlr_destruct(struct spdk_nvmf_ctrlr *ctrlr) +nvmf_ctrlr_destruct(struct spdk_nvmf_ctrlr *ctrlr) { - spdk_nvmf_subsystem_remove_ctrlr(ctrlr->subsys, ctrlr); + nvmf_subsystem_remove_ctrlr(ctrlr->subsys, ctrlr); spdk_thread_send_msg(ctrlr->thread, _spdk_nvmf_ctrlr_destruct, ctrlr); } @@ -465,7 +465,7 @@ _spdk_nvmf_ctrlr_add_io_qpair(void *ctx) /* We already checked this in spdk_nvmf_ctrlr_connect */ assert(subsystem != NULL); - ctrlr = spdk_nvmf_subsystem_get_ctrlr(subsystem, data->cntlid); + ctrlr = nvmf_subsystem_get_ctrlr(subsystem, data->cntlid); if (ctrlr == NULL) { SPDK_ERRLOG("Unknown controller ID 0x%x\n", data->cntlid); SPDK_NVMF_INVALID_CONNECT_DATA(rsp, cntlid); @@ -1287,7 +1287,7 @@ spdk_nvmf_ctrlr_get_features_reservation_notification_mask(struct spdk_nvmf_requ return SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE; } - ns = _spdk_nvmf_subsystem_get_ns(ctrlr->subsys, cmd->nsid); + ns = _nvmf_subsystem_get_ns(ctrlr->subsys, cmd->nsid); if (ns == NULL) { SPDK_ERRLOG("Set Features - Invalid Namespace ID\n"); rsp->status.sc = SPDK_NVME_SC_INVALID_FIELD; @@ -1317,7 +1317,7 @@ spdk_nvmf_ctrlr_set_features_reservation_notification_mask(struct spdk_nvmf_requ return SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE; } - ns = _spdk_nvmf_subsystem_get_ns(ctrlr->subsys, cmd->nsid); + ns = _nvmf_subsystem_get_ns(ctrlr->subsys, cmd->nsid); if (ns == NULL) { SPDK_ERRLOG("Set Features - Invalid Namespace ID\n"); rsp->status.sc = SPDK_NVME_SC_INVALID_FIELD; @@ -1338,7 +1338,7 @@ spdk_nvmf_ctrlr_get_features_reservation_persistence(struct spdk_nvmf_request *r SPDK_DEBUGLOG(SPDK_LOG_NVMF, "Get Features - Reservation Persistence\n"); - ns = _spdk_nvmf_subsystem_get_ns(ctrlr->subsys, cmd->nsid); + ns = _nvmf_subsystem_get_ns(ctrlr->subsys, cmd->nsid); /* NSID with 0xffffffffu also included */ if (ns == NULL) { SPDK_ERRLOG("Get Features - Invalid Namespace ID\n"); @@ -1365,7 +1365,7 @@ spdk_nvmf_ctrlr_set_features_reservation_persistence(struct spdk_nvmf_request *r SPDK_DEBUGLOG(SPDK_LOG_NVMF, "Set Features - Reservation Persistence\n"); - ns = _spdk_nvmf_subsystem_get_ns(ctrlr->subsys, cmd->nsid); + ns = _nvmf_subsystem_get_ns(ctrlr->subsys, cmd->nsid); ptpl = cmd->cdw11_bits.feat_rsv_persistence.bits.ptpl; if (cmd->nsid != 0xffffffffu && ns && ns->ptpl_file) { @@ -1529,7 +1529,7 @@ spdk_nvmf_get_firmware_slot_log_page(void *buffer, uint64_t offset, uint32_t len } void -spdk_nvmf_ctrlr_ns_changed(struct spdk_nvmf_ctrlr *ctrlr, uint32_t nsid) +nvmf_ctrlr_ns_changed(struct spdk_nvmf_ctrlr *ctrlr, uint32_t nsid) { uint16_t max_changes = SPDK_COUNTOF(ctrlr->changed_ns_list.ns_list); uint16_t i; @@ -1714,8 +1714,8 @@ spdk_nvmf_ctrlr_get_log_page(struct spdk_nvmf_request *req) if (subsystem->subtype == SPDK_NVMF_SUBTYPE_DISCOVERY) { switch (lid) { case SPDK_NVME_LOG_DISCOVERY: - spdk_nvmf_get_discovery_log_page(subsystem->tgt, ctrlr->hostnqn, req->iov, req->iovcnt, offset, - len); + nvmf_get_discovery_log_page(subsystem->tgt, ctrlr->hostnqn, req->iov, req->iovcnt, offset, + len); return SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE; default: goto invalid_log_page; @@ -1767,11 +1767,11 @@ spdk_nvmf_ctrlr_identify_ns(struct spdk_nvmf_ctrlr *ctrlr, return SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE; } - ns = _spdk_nvmf_subsystem_get_ns(subsystem, cmd->nsid); + ns = _nvmf_subsystem_get_ns(subsystem, cmd->nsid); if (ns == NULL || ns->bdev == NULL) { /* * Inactive namespaces should return a zero filled data structure. - * The data buffer is already zeroed by spdk_nvmf_ctrlr_process_admin_cmd(), + * The data buffer is already zeroed by nvmf_ctrlr_process_admin_cmd(), * so we can just return early here. */ SPDK_DEBUGLOG(SPDK_LOG_NVMF, "Identify Namespace for inactive NSID %u\n", cmd->nsid); @@ -1780,7 +1780,7 @@ spdk_nvmf_ctrlr_identify_ns(struct spdk_nvmf_ctrlr *ctrlr, return SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE; } - spdk_nvmf_bdev_ctrlr_identify_ns(ns, nsdata, ctrlr->dif_insert_or_strip); + nvmf_bdev_ctrlr_identify_ns(ns, nsdata, ctrlr->dif_insert_or_strip); /* Due to bug in the Linux kernel NVMe driver we have to set noiob no larger than mdts */ max_num_blocks = ctrlr->admin_qpair->transport->opts.max_io_size / @@ -1885,8 +1885,8 @@ spdk_nvmf_ctrlr_identify_ctrlr(struct spdk_nvmf_ctrlr *ctrlr, struct spdk_nvme_c cdata->nvmf_specific = transport->cdata.nvmf_specific; - cdata->oncs.dsm = spdk_nvmf_ctrlr_dsm_supported(ctrlr); - cdata->oncs.write_zeroes = spdk_nvmf_ctrlr_write_zeroes_supported(ctrlr); + cdata->oncs.dsm = nvmf_ctrlr_dsm_supported(ctrlr); + cdata->oncs.write_zeroes = nvmf_ctrlr_write_zeroes_supported(ctrlr); cdata->oncs.reservations = 1; nvmf_ctrlr_populate_oacs(ctrlr, cdata); @@ -1975,7 +1975,7 @@ spdk_nvmf_ctrlr_identify_ns_id_descriptor_list( size_t buf_remain = id_desc_list_size; void *buf_ptr = id_desc_list; - ns = _spdk_nvmf_subsystem_get_ns(subsystem, cmd->nsid); + ns = _nvmf_subsystem_get_ns(subsystem, cmd->nsid); if (ns == NULL || ns->bdev == NULL) { rsp->status.sct = SPDK_NVME_SCT_GENERIC; rsp->status.sc = SPDK_NVME_SC_INVALID_NAMESPACE_OR_FORMAT; @@ -1995,7 +1995,7 @@ spdk_nvmf_ctrlr_identify_ns_id_descriptor_list( /* * The list is automatically 0-terminated because controller to host buffers in - * admin commands always get zeroed in spdk_nvmf_ctrlr_process_admin_cmd(). + * admin commands always get zeroed in nvmf_ctrlr_process_admin_cmd(). */ #undef ADD_ID_DESC @@ -2054,7 +2054,7 @@ spdk_nvmf_qpair_abort(struct spdk_nvmf_qpair *qpair, uint16_t cid) struct spdk_nvmf_ctrlr *ctrlr = qpair->ctrlr; struct spdk_nvmf_request *req; - if (spdk_nvmf_qpair_is_admin_queue(qpair)) { + if (nvmf_qpair_is_admin_queue(qpair)) { if (ctrlr->aer_req && ctrlr->aer_req->cmd->nvme_cmd.cid == cid) { SPDK_DEBUGLOG(SPDK_LOG_NVMF, "Aborting AER request\n"); req = ctrlr->aer_req; @@ -2261,7 +2261,7 @@ spdk_nvmf_ctrlr_keep_alive(struct spdk_nvmf_request *req) } int -spdk_nvmf_ctrlr_process_admin_cmd(struct spdk_nvmf_request *req) +nvmf_ctrlr_process_admin_cmd(struct spdk_nvmf_request *req) { struct spdk_nvmf_ctrlr *ctrlr = req->qpair->ctrlr; struct spdk_nvme_cmd *cmd = &req->cmd->nvme_cmd; @@ -2341,7 +2341,7 @@ invalid_opcode: } int -spdk_nvmf_ctrlr_process_fabrics_cmd(struct spdk_nvmf_request *req) +nvmf_ctrlr_process_fabrics_cmd(struct spdk_nvmf_request *req) { struct spdk_nvmf_qpair *qpair = req->qpair; struct spdk_nvmf_capsule_cmd *cap_hdr; @@ -2359,7 +2359,7 @@ spdk_nvmf_ctrlr_process_fabrics_cmd(struct spdk_nvmf_request *req) req->rsp->nvme_cpl.status.sc = SPDK_NVME_SC_COMMAND_SEQUENCE_ERROR; return SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE; } - } else if (spdk_nvmf_qpair_is_admin_queue(qpair)) { + } else if (nvmf_qpair_is_admin_queue(qpair)) { /* * Controller session is established, and this is an admin queue. * Disallow Connect and allow other fabrics commands. @@ -2387,7 +2387,7 @@ spdk_nvmf_ctrlr_process_fabrics_cmd(struct spdk_nvmf_request *req) } int -spdk_nvmf_ctrlr_async_event_ns_notice(struct spdk_nvmf_ctrlr *ctrlr) +nvmf_ctrlr_async_event_ns_notice(struct spdk_nvmf_ctrlr *ctrlr) { struct spdk_nvmf_request *req; struct spdk_nvme_cpl *rsp; @@ -2428,7 +2428,7 @@ spdk_nvmf_ctrlr_async_event_ns_notice(struct spdk_nvmf_ctrlr *ctrlr) } void -spdk_nvmf_ctrlr_async_event_reservation_notification(struct spdk_nvmf_ctrlr *ctrlr) +nvmf_ctrlr_async_event_reservation_notification(struct spdk_nvmf_ctrlr *ctrlr) { struct spdk_nvmf_request *req; struct spdk_nvme_cpl *rsp; @@ -2465,11 +2465,11 @@ spdk_nvmf_ctrlr_async_event_reservation_notification(struct spdk_nvmf_ctrlr *ctr } void -spdk_nvmf_qpair_free_aer(struct spdk_nvmf_qpair *qpair) +nvmf_qpair_free_aer(struct spdk_nvmf_qpair *qpair) { struct spdk_nvmf_ctrlr *ctrlr = qpair->ctrlr; - if (!spdk_nvmf_qpair_is_admin_queue(qpair)) { + if (!nvmf_qpair_is_admin_queue(qpair)) { return; } @@ -2480,7 +2480,7 @@ spdk_nvmf_qpair_free_aer(struct spdk_nvmf_qpair *qpair) } void -spdk_nvmf_ctrlr_abort_aer(struct spdk_nvmf_ctrlr *ctrlr) +nvmf_ctrlr_abort_aer(struct spdk_nvmf_ctrlr *ctrlr) { if (!ctrlr->aer_req) { return; @@ -2511,13 +2511,13 @@ _nvmf_ctrlr_add_reservation_log(void *ctx) log->log.num_avail_log_pages = ctrlr->num_avail_log_pages++; TAILQ_INSERT_TAIL(&ctrlr->log_head, log, link); - spdk_nvmf_ctrlr_async_event_reservation_notification(ctrlr); + nvmf_ctrlr_async_event_reservation_notification(ctrlr); } void -spdk_nvmf_ctrlr_reservation_notice_log(struct spdk_nvmf_ctrlr *ctrlr, - struct spdk_nvmf_ns *ns, - enum spdk_nvme_reservation_notification_log_page_type type) +nvmf_ctrlr_reservation_notice_log(struct spdk_nvmf_ctrlr *ctrlr, + struct spdk_nvmf_ns *ns, + enum spdk_nvme_reservation_notification_log_page_type type) { struct spdk_nvmf_reservation_log *log; @@ -2717,7 +2717,7 @@ spdk_nvmf_ctrlr_process_io_fused_cmd(struct spdk_nvmf_request *req, struct spdk_ return SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE; } - rc = spdk_nvmf_bdev_ctrlr_compare_and_write_cmd(bdev, desc, ch, req->first_fused_req, req); + rc = nvmf_bdev_ctrlr_compare_and_write_cmd(bdev, desc, ch, req->first_fused_req, req); if (rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE) { if (spdk_nvme_cpl_is_error(rsp)) { @@ -2736,7 +2736,7 @@ spdk_nvmf_ctrlr_process_io_fused_cmd(struct spdk_nvmf_request *req, struct spdk_ } int -spdk_nvmf_ctrlr_process_io_cmd(struct spdk_nvmf_request *req) +nvmf_ctrlr_process_io_cmd(struct spdk_nvmf_request *req) { uint32_t nsid; struct spdk_nvmf_ns *ns; @@ -2767,7 +2767,7 @@ spdk_nvmf_ctrlr_process_io_cmd(struct spdk_nvmf_request *req) return SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE; } - ns = _spdk_nvmf_subsystem_get_ns(ctrlr->subsys, nsid); + ns = _nvmf_subsystem_get_ns(ctrlr->subsys, nsid); if (ns == NULL || ns->bdev == NULL) { SPDK_ERRLOG("Unsuccessful query for nsid %u\n", cmd->nsid); response->status.sc = SPDK_NVME_SC_INVALID_NAMESPACE_OR_FORMAT; @@ -2804,25 +2804,25 @@ spdk_nvmf_ctrlr_process_io_cmd(struct spdk_nvmf_request *req) switch (cmd->opc) { case SPDK_NVME_OPC_READ: - return spdk_nvmf_bdev_ctrlr_read_cmd(bdev, desc, ch, req); + return nvmf_bdev_ctrlr_read_cmd(bdev, desc, ch, req); case SPDK_NVME_OPC_WRITE: - return spdk_nvmf_bdev_ctrlr_write_cmd(bdev, desc, ch, req); + return nvmf_bdev_ctrlr_write_cmd(bdev, desc, ch, req); case SPDK_NVME_OPC_COMPARE: - return spdk_nvmf_bdev_ctrlr_compare_cmd(bdev, desc, ch, req); + return nvmf_bdev_ctrlr_compare_cmd(bdev, desc, ch, req); case SPDK_NVME_OPC_WRITE_ZEROES: - return spdk_nvmf_bdev_ctrlr_write_zeroes_cmd(bdev, desc, ch, req); + return nvmf_bdev_ctrlr_write_zeroes_cmd(bdev, desc, ch, req); case SPDK_NVME_OPC_FLUSH: - return spdk_nvmf_bdev_ctrlr_flush_cmd(bdev, desc, ch, req); + return nvmf_bdev_ctrlr_flush_cmd(bdev, desc, ch, req); case SPDK_NVME_OPC_DATASET_MANAGEMENT: - return spdk_nvmf_bdev_ctrlr_dsm_cmd(bdev, desc, ch, req); + return nvmf_bdev_ctrlr_dsm_cmd(bdev, desc, ch, req); case SPDK_NVME_OPC_RESERVATION_REGISTER: case SPDK_NVME_OPC_RESERVATION_ACQUIRE: case SPDK_NVME_OPC_RESERVATION_RELEASE: case SPDK_NVME_OPC_RESERVATION_REPORT: - spdk_thread_send_msg(ctrlr->subsys->thread, spdk_nvmf_ns_reservation_request, req); + spdk_thread_send_msg(ctrlr->subsys->thread, nvmf_ns_reservation_request, req); return SPDK_NVMF_REQUEST_EXEC_STATUS_ASYNCHRONOUS; default: - return spdk_nvmf_bdev_ctrlr_nvme_passthru_io(bdev, desc, ch, req); + return nvmf_bdev_ctrlr_nvme_passthru_io(bdev, desc, ch, req); } } @@ -2949,7 +2949,7 @@ _nvmf_request_exec(struct spdk_nvmf_request *req, struct spdk_nvmf_qpair *qpair = req->qpair; enum spdk_nvmf_request_exec_status status; - nvmf_trace_command(req->cmd, spdk_nvmf_qpair_is_admin_queue(qpair)); + nvmf_trace_command(req->cmd, nvmf_qpair_is_admin_queue(qpair)); if (sgroup) { sgroup->io_outstanding++; @@ -2959,11 +2959,11 @@ _nvmf_request_exec(struct spdk_nvmf_request *req, TAILQ_INSERT_TAIL(&qpair->outstanding, req, link); if (spdk_unlikely(req->cmd->nvmf_cmd.opcode == SPDK_NVME_OPC_FABRIC)) { - status = spdk_nvmf_ctrlr_process_fabrics_cmd(req); - } else if (spdk_unlikely(spdk_nvmf_qpair_is_admin_queue(qpair))) { - status = spdk_nvmf_ctrlr_process_admin_cmd(req); + status = nvmf_ctrlr_process_fabrics_cmd(req); + } else if (spdk_unlikely(nvmf_qpair_is_admin_queue(qpair))) { + status = nvmf_ctrlr_process_admin_cmd(req); } else { - status = spdk_nvmf_ctrlr_process_io_cmd(req); + status = nvmf_ctrlr_process_io_cmd(req); } if (status == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE) { @@ -3036,7 +3036,7 @@ spdk_nvmf_ctrlr_get_dif_ctx(struct spdk_nvmf_ctrlr *ctrlr, struct spdk_nvme_cmd return false; } - ns = _spdk_nvmf_subsystem_get_ns(ctrlr->subsys, cmd->nsid); + ns = _nvmf_subsystem_get_ns(ctrlr->subsys, cmd->nsid); if (ns == NULL || ns->bdev == NULL) { return false; } @@ -3047,7 +3047,7 @@ spdk_nvmf_ctrlr_get_dif_ctx(struct spdk_nvmf_ctrlr *ctrlr, struct spdk_nvme_cmd case SPDK_NVME_OPC_READ: case SPDK_NVME_OPC_WRITE: case SPDK_NVME_OPC_COMPARE: - return spdk_nvmf_bdev_ctrlr_get_dif_ctx(bdev, cmd, dif_ctx); + return nvmf_bdev_ctrlr_get_dif_ctx(bdev, cmd, dif_ctx); default: break; } @@ -3073,7 +3073,7 @@ spdk_nvmf_request_get_dif_ctx(struct spdk_nvmf_request *req, struct spdk_dif_ctx return false; } - if (spdk_unlikely(spdk_nvmf_qpair_is_admin_queue(qpair))) { + if (spdk_unlikely(nvmf_qpair_is_admin_queue(qpair))) { return false; } @@ -3132,7 +3132,7 @@ spdk_nvmf_request_get_bdev(uint32_t nsid, struct spdk_nvmf_request *req, *desc = NULL; *ch = NULL; - ns = _spdk_nvmf_subsystem_get_ns(ctrlr->subsys, nsid); + ns = _nvmf_subsystem_get_ns(ctrlr->subsys, nsid); if (ns == NULL || ns->bdev == NULL) { return -EINVAL; } diff --git a/lib/nvmf/ctrlr_bdev.c b/lib/nvmf/ctrlr_bdev.c index 84ccef902..b86dd99b7 100644 --- a/lib/nvmf/ctrlr_bdev.c +++ b/lib/nvmf/ctrlr_bdev.c @@ -76,13 +76,13 @@ spdk_nvmf_subsystem_bdev_io_type_supported(struct spdk_nvmf_subsystem *subsystem } bool -spdk_nvmf_ctrlr_dsm_supported(struct spdk_nvmf_ctrlr *ctrlr) +nvmf_ctrlr_dsm_supported(struct spdk_nvmf_ctrlr *ctrlr) { return spdk_nvmf_subsystem_bdev_io_type_supported(ctrlr->subsys, SPDK_BDEV_IO_TYPE_UNMAP); } bool -spdk_nvmf_ctrlr_write_zeroes_supported(struct spdk_nvmf_ctrlr *ctrlr) +nvmf_ctrlr_write_zeroes_supported(struct spdk_nvmf_ctrlr *ctrlr) { return spdk_nvmf_subsystem_bdev_io_type_supported(ctrlr->subsys, SPDK_BDEV_IO_TYPE_WRITE_ZEROES); } @@ -135,8 +135,8 @@ nvmf_bdev_ctrlr_complete_admin_cmd(struct spdk_bdev_io *bdev_io, bool success, } void -spdk_nvmf_bdev_ctrlr_identify_ns(struct spdk_nvmf_ns *ns, struct spdk_nvme_ns_data *nsdata, - bool dif_insert_or_strip) +nvmf_bdev_ctrlr_identify_ns(struct spdk_nvmf_ns *ns, struct spdk_nvme_ns_data *nsdata, + bool dif_insert_or_strip) { struct spdk_bdev *bdev = ns->bdev; uint64_t num_blocks; @@ -229,7 +229,7 @@ spdk_nvmf_ctrlr_process_io_cmd_resubmit(void *arg) { struct spdk_nvmf_request *req = arg; - spdk_nvmf_ctrlr_process_io_cmd(req); + nvmf_ctrlr_process_io_cmd(req); } static void @@ -237,7 +237,7 @@ spdk_nvmf_ctrlr_process_admin_cmd_resubmit(void *arg) { struct spdk_nvmf_request *req = arg; - spdk_nvmf_ctrlr_process_admin_cmd(req); + nvmf_ctrlr_process_admin_cmd(req); } static void @@ -258,8 +258,8 @@ nvmf_bdev_ctrl_queue_io(struct spdk_nvmf_request *req, struct spdk_bdev *bdev, } int -spdk_nvmf_bdev_ctrlr_read_cmd(struct spdk_bdev *bdev, struct spdk_bdev_desc *desc, - struct spdk_io_channel *ch, struct spdk_nvmf_request *req) +nvmf_bdev_ctrlr_read_cmd(struct spdk_bdev *bdev, struct spdk_bdev_desc *desc, + struct spdk_io_channel *ch, struct spdk_nvmf_request *req) { uint64_t bdev_num_blocks = spdk_bdev_get_num_blocks(bdev); uint32_t block_size = spdk_bdev_get_block_size(bdev); @@ -302,8 +302,8 @@ spdk_nvmf_bdev_ctrlr_read_cmd(struct spdk_bdev *bdev, struct spdk_bdev_desc *des } int -spdk_nvmf_bdev_ctrlr_write_cmd(struct spdk_bdev *bdev, struct spdk_bdev_desc *desc, - struct spdk_io_channel *ch, struct spdk_nvmf_request *req) +nvmf_bdev_ctrlr_write_cmd(struct spdk_bdev *bdev, struct spdk_bdev_desc *desc, + struct spdk_io_channel *ch, struct spdk_nvmf_request *req) { uint64_t bdev_num_blocks = spdk_bdev_get_num_blocks(bdev); uint32_t block_size = spdk_bdev_get_block_size(bdev); @@ -346,8 +346,8 @@ spdk_nvmf_bdev_ctrlr_write_cmd(struct spdk_bdev *bdev, struct spdk_bdev_desc *de } int -spdk_nvmf_bdev_ctrlr_compare_cmd(struct spdk_bdev *bdev, struct spdk_bdev_desc *desc, - struct spdk_io_channel *ch, struct spdk_nvmf_request *req) +nvmf_bdev_ctrlr_compare_cmd(struct spdk_bdev *bdev, struct spdk_bdev_desc *desc, + struct spdk_io_channel *ch, struct spdk_nvmf_request *req) { uint64_t bdev_num_blocks = spdk_bdev_get_num_blocks(bdev); uint32_t block_size = spdk_bdev_get_block_size(bdev); @@ -390,8 +390,8 @@ spdk_nvmf_bdev_ctrlr_compare_cmd(struct spdk_bdev *bdev, struct spdk_bdev_desc * } int -spdk_nvmf_bdev_ctrlr_compare_and_write_cmd(struct spdk_bdev *bdev, struct spdk_bdev_desc *desc, - struct spdk_io_channel *ch, struct spdk_nvmf_request *cmp_req, struct spdk_nvmf_request *write_req) +nvmf_bdev_ctrlr_compare_and_write_cmd(struct spdk_bdev *bdev, struct spdk_bdev_desc *desc, + struct spdk_io_channel *ch, struct spdk_nvmf_request *cmp_req, struct spdk_nvmf_request *write_req) { uint64_t bdev_num_blocks = spdk_bdev_get_num_blocks(bdev); uint32_t block_size = spdk_bdev_get_block_size(bdev); @@ -445,8 +445,8 @@ spdk_nvmf_bdev_ctrlr_compare_and_write_cmd(struct spdk_bdev *bdev, struct spdk_b } int -spdk_nvmf_bdev_ctrlr_write_zeroes_cmd(struct spdk_bdev *bdev, struct spdk_bdev_desc *desc, - struct spdk_io_channel *ch, struct spdk_nvmf_request *req) +nvmf_bdev_ctrlr_write_zeroes_cmd(struct spdk_bdev *bdev, struct spdk_bdev_desc *desc, + struct spdk_io_channel *ch, struct spdk_nvmf_request *req) { uint64_t bdev_num_blocks = spdk_bdev_get_num_blocks(bdev); struct spdk_nvme_cmd *cmd = &req->cmd->nvme_cmd; @@ -480,8 +480,8 @@ spdk_nvmf_bdev_ctrlr_write_zeroes_cmd(struct spdk_bdev *bdev, struct spdk_bdev_d } int -spdk_nvmf_bdev_ctrlr_flush_cmd(struct spdk_bdev *bdev, struct spdk_bdev_desc *desc, - struct spdk_io_channel *ch, struct spdk_nvmf_request *req) +nvmf_bdev_ctrlr_flush_cmd(struct spdk_bdev *bdev, struct spdk_bdev_desc *desc, + struct spdk_io_channel *ch, struct spdk_nvmf_request *req) { struct spdk_nvme_cpl *response = &req->rsp->nvme_cpl; int rc; @@ -633,8 +633,8 @@ nvmf_bdev_ctrlr_unmap(struct spdk_bdev *bdev, struct spdk_bdev_desc *desc, } int -spdk_nvmf_bdev_ctrlr_dsm_cmd(struct spdk_bdev *bdev, struct spdk_bdev_desc *desc, - struct spdk_io_channel *ch, struct spdk_nvmf_request *req) +nvmf_bdev_ctrlr_dsm_cmd(struct spdk_bdev *bdev, struct spdk_bdev_desc *desc, + struct spdk_io_channel *ch, struct spdk_nvmf_request *req) { struct spdk_nvme_cmd *cmd = &req->cmd->nvme_cmd; struct spdk_nvme_cpl *response = &req->rsp->nvme_cpl; @@ -649,8 +649,8 @@ spdk_nvmf_bdev_ctrlr_dsm_cmd(struct spdk_bdev *bdev, struct spdk_bdev_desc *desc } int -spdk_nvmf_bdev_ctrlr_nvme_passthru_io(struct spdk_bdev *bdev, struct spdk_bdev_desc *desc, - struct spdk_io_channel *ch, struct spdk_nvmf_request *req) +nvmf_bdev_ctrlr_nvme_passthru_io(struct spdk_bdev *bdev, struct spdk_bdev_desc *desc, + struct spdk_io_channel *ch, struct spdk_nvmf_request *req) { int rc; @@ -694,8 +694,8 @@ spdk_nvmf_bdev_ctrlr_nvme_passthru_admin(struct spdk_bdev *bdev, struct spdk_bde } bool -spdk_nvmf_bdev_ctrlr_get_dif_ctx(struct spdk_bdev *bdev, struct spdk_nvme_cmd *cmd, - struct spdk_dif_ctx *dif_ctx) +nvmf_bdev_ctrlr_get_dif_ctx(struct spdk_bdev *bdev, struct spdk_nvme_cmd *cmd, + struct spdk_dif_ctx *dif_ctx) { uint32_t init_ref_tag, dif_check_flags = 0; int rc; diff --git a/lib/nvmf/ctrlr_discovery.c b/lib/nvmf/ctrlr_discovery.c index abd546619..1d3adcab9 100644 --- a/lib/nvmf/ctrlr_discovery.c +++ b/lib/nvmf/ctrlr_discovery.c @@ -120,8 +120,8 @@ nvmf_generate_discovery_log(struct spdk_nvmf_tgt *tgt, const char *hostnqn, size } void -spdk_nvmf_get_discovery_log_page(struct spdk_nvmf_tgt *tgt, const char *hostnqn, struct iovec *iov, - uint32_t iovcnt, uint64_t offset, uint32_t length) +nvmf_get_discovery_log_page(struct spdk_nvmf_tgt *tgt, const char *hostnqn, struct iovec *iov, + uint32_t iovcnt, uint64_t offset, uint32_t length) { size_t copy_len = 0; size_t zero_len = 0; diff --git a/lib/nvmf/fc.c b/lib/nvmf/fc.c index 97fd21c2e..16143e95e 100644 --- a/lib/nvmf/fc.c +++ b/lib/nvmf/fc.c @@ -1167,7 +1167,7 @@ nvmf_fc_req_bdev_abort(void *arg1) */ if (ctrlr->aer_req == &fc_req->req) { SPDK_NOTICELOG("Abort AER request\n"); - spdk_nvmf_qpair_free_aer(fc_req->req.qpair); + nvmf_qpair_free_aer(fc_req->req.qpair); } } diff --git a/lib/nvmf/fc_ls.c b/lib/nvmf/fc_ls.c index 45f1d0618..bcc1bced1 100644 --- a/lib/nvmf/fc_ls.c +++ b/lib/nvmf/fc_ls.c @@ -1491,7 +1491,7 @@ nvmf_fc_poller_api_del_connection(void *arg) TAILQ_FOREACH_SAFE(fc_req, &hwqp->in_use_reqs, link, tmp) { if (fc_req->fc_conn->conn_id == fc_conn->conn_id) { - if (spdk_nvmf_qpair_is_admin_queue(&fc_conn->qpair) && + if (nvmf_qpair_is_admin_queue(&fc_conn->qpair) && (fc_req->req.cmd->nvme_cmd.opc == SPDK_NVME_OPC_ASYNC_EVENT_REQUEST)) { /* AER will be cleaned by spdk_nvmf_qpair_disconnect. */ continue; diff --git a/lib/nvmf/nvmf.c b/lib/nvmf/nvmf.c index 2f762e27a..682e9e805 100644 --- a/lib/nvmf/nvmf.c +++ b/lib/nvmf/nvmf.c @@ -119,7 +119,7 @@ spdk_nvmf_tgt_create_poll_group(void *io_device, void *ctx_buf) TAILQ_INIT(&group->qpairs); TAILQ_FOREACH(transport, &tgt->transports, link) { - spdk_nvmf_poll_group_add_transport(group, transport); + nvmf_poll_group_add_transport(group, transport); } group->num_sgroups = tgt->max_subsystems; @@ -136,7 +136,7 @@ spdk_nvmf_tgt_create_poll_group(void *io_device, void *ctx_buf) continue; } - if (spdk_nvmf_poll_group_add_subsystem(group, subsystem, NULL, NULL) != 0) { + if (nvmf_poll_group_add_subsystem(group, subsystem, NULL, NULL) != 0) { spdk_nvmf_tgt_destroy_poll_group(io_device, ctx_buf); return -1; } @@ -284,7 +284,7 @@ spdk_nvmf_tgt_destroy_cb(void *io_device) if (tgt->subsystems) { for (i = 0; i < tgt->max_subsystems; i++) { if (tgt->subsystems[i]) { - spdk_nvmf_subsystem_remove_all_listeners(tgt->subsystems[i], true); + nvmf_subsystem_remove_all_listeners(tgt->subsystems[i], true); spdk_nvmf_subsystem_destroy(tgt->subsystems[i]); } } @@ -628,7 +628,7 @@ _spdk_nvmf_tgt_add_transport(struct spdk_io_channel_iter *i) struct spdk_nvmf_poll_group *group = spdk_io_channel_get_ctx(ch); int rc; - rc = spdk_nvmf_poll_group_add_transport(group, ctx->transport); + rc = nvmf_poll_group_add_transport(group, ctx->transport); spdk_for_each_channel_continue(i, rc); } @@ -775,7 +775,7 @@ void _nvmf_ctrlr_destruct(void *ctx) { struct spdk_nvmf_ctrlr *ctrlr = ctx; - spdk_nvmf_ctrlr_destruct(ctrlr); + nvmf_ctrlr_destruct(ctrlr); } static void @@ -911,7 +911,7 @@ spdk_nvmf_qpair_disconnect(struct spdk_nvmf_qpair *qpair, nvmf_qpair_disconnect_ if (!TAILQ_EMPTY(&qpair->outstanding)) { qpair->state_cb = _spdk_nvmf_qpair_destroy; qpair->state_cb_arg = qpair_ctx; - spdk_nvmf_qpair_free_aer(qpair); + nvmf_qpair_free_aer(qpair); return 0; } @@ -942,8 +942,8 @@ spdk_nvmf_qpair_get_listen_trid(struct spdk_nvmf_qpair *qpair, } int -spdk_nvmf_poll_group_add_transport(struct spdk_nvmf_poll_group *group, - struct spdk_nvmf_transport *transport) +nvmf_poll_group_add_transport(struct spdk_nvmf_poll_group *group, + struct spdk_nvmf_transport *transport) { struct spdk_nvmf_transport_poll_group *tgroup; @@ -1116,7 +1116,7 @@ poll_group_update_subsystem(struct spdk_nvmf_poll_group *group, if (ns_changed) { TAILQ_FOREACH(ctrlr, &subsystem->ctrlrs, link) { if (ctrlr->admin_qpair->group == group) { - spdk_nvmf_ctrlr_async_event_ns_notice(ctrlr); + nvmf_ctrlr_async_event_ns_notice(ctrlr); } } } @@ -1125,16 +1125,16 @@ poll_group_update_subsystem(struct spdk_nvmf_poll_group *group, } int -spdk_nvmf_poll_group_update_subsystem(struct spdk_nvmf_poll_group *group, - struct spdk_nvmf_subsystem *subsystem) +nvmf_poll_group_update_subsystem(struct spdk_nvmf_poll_group *group, + struct spdk_nvmf_subsystem *subsystem) { return poll_group_update_subsystem(group, subsystem); } int -spdk_nvmf_poll_group_add_subsystem(struct spdk_nvmf_poll_group *group, - struct spdk_nvmf_subsystem *subsystem, - spdk_nvmf_poll_group_mod_done cb_fn, void *cb_arg) +nvmf_poll_group_add_subsystem(struct spdk_nvmf_poll_group *group, + struct spdk_nvmf_subsystem *subsystem, + spdk_nvmf_poll_group_mod_done cb_fn, void *cb_arg) { int rc = 0; struct spdk_nvmf_subsystem_poll_group *sgroup = &group->sgroups[subsystem->id]; @@ -1143,7 +1143,7 @@ spdk_nvmf_poll_group_add_subsystem(struct spdk_nvmf_poll_group *group, rc = poll_group_update_subsystem(group, subsystem); if (rc) { - spdk_nvmf_poll_group_remove_subsystem(group, subsystem, NULL, NULL); + nvmf_poll_group_remove_subsystem(group, subsystem, NULL, NULL); goto fini; } @@ -1223,9 +1223,9 @@ _nvmf_subsystem_disconnect_next_qpair(void *ctx) } void -spdk_nvmf_poll_group_remove_subsystem(struct spdk_nvmf_poll_group *group, - struct spdk_nvmf_subsystem *subsystem, - spdk_nvmf_poll_group_mod_done cb_fn, void *cb_arg) +nvmf_poll_group_remove_subsystem(struct spdk_nvmf_poll_group *group, + struct spdk_nvmf_subsystem *subsystem, + spdk_nvmf_poll_group_mod_done cb_fn, void *cb_arg) { struct spdk_nvmf_qpair *qpair; struct spdk_nvmf_subsystem_poll_group *sgroup; @@ -1273,9 +1273,9 @@ fini: } void -spdk_nvmf_poll_group_pause_subsystem(struct spdk_nvmf_poll_group *group, - struct spdk_nvmf_subsystem *subsystem, - spdk_nvmf_poll_group_mod_done cb_fn, void *cb_arg) +nvmf_poll_group_pause_subsystem(struct spdk_nvmf_poll_group *group, + struct spdk_nvmf_subsystem *subsystem, + spdk_nvmf_poll_group_mod_done cb_fn, void *cb_arg) { struct spdk_nvmf_subsystem_poll_group *sgroup; int rc = 0; @@ -1309,9 +1309,9 @@ fini: } void -spdk_nvmf_poll_group_resume_subsystem(struct spdk_nvmf_poll_group *group, - struct spdk_nvmf_subsystem *subsystem, - spdk_nvmf_poll_group_mod_done cb_fn, void *cb_arg) +nvmf_poll_group_resume_subsystem(struct spdk_nvmf_poll_group *group, + struct spdk_nvmf_subsystem *subsystem, + spdk_nvmf_poll_group_mod_done cb_fn, void *cb_arg) { struct spdk_nvmf_request *req, *tmp; struct spdk_nvmf_subsystem_poll_group *sgroup; diff --git a/lib/nvmf/nvmf_internal.h b/lib/nvmf/nvmf_internal.h index 692511f07..65e221fed 100644 --- a/lib/nvmf/nvmf_internal.h +++ b/lib/nvmf/nvmf_internal.h @@ -254,82 +254,82 @@ struct spdk_nvmf_subsystem { TAILQ_ENTRY(spdk_nvmf_subsystem) entries; }; -int spdk_nvmf_poll_group_add_transport(struct spdk_nvmf_poll_group *group, - struct spdk_nvmf_transport *transport); -int spdk_nvmf_poll_group_update_subsystem(struct spdk_nvmf_poll_group *group, - struct spdk_nvmf_subsystem *subsystem); -int spdk_nvmf_poll_group_add_subsystem(struct spdk_nvmf_poll_group *group, - struct spdk_nvmf_subsystem *subsystem, - spdk_nvmf_poll_group_mod_done cb_fn, void *cb_arg); -void spdk_nvmf_poll_group_remove_subsystem(struct spdk_nvmf_poll_group *group, - struct spdk_nvmf_subsystem *subsystem, spdk_nvmf_poll_group_mod_done cb_fn, void *cb_arg); -void spdk_nvmf_poll_group_pause_subsystem(struct spdk_nvmf_poll_group *group, - struct spdk_nvmf_subsystem *subsystem, spdk_nvmf_poll_group_mod_done cb_fn, void *cb_arg); -void spdk_nvmf_poll_group_resume_subsystem(struct spdk_nvmf_poll_group *group, - struct spdk_nvmf_subsystem *subsystem, spdk_nvmf_poll_group_mod_done cb_fn, void *cb_arg); +int nvmf_poll_group_add_transport(struct spdk_nvmf_poll_group *group, + struct spdk_nvmf_transport *transport); +int nvmf_poll_group_update_subsystem(struct spdk_nvmf_poll_group *group, + struct spdk_nvmf_subsystem *subsystem); +int nvmf_poll_group_add_subsystem(struct spdk_nvmf_poll_group *group, + struct spdk_nvmf_subsystem *subsystem, + spdk_nvmf_poll_group_mod_done cb_fn, void *cb_arg); +void nvmf_poll_group_remove_subsystem(struct spdk_nvmf_poll_group *group, + struct spdk_nvmf_subsystem *subsystem, spdk_nvmf_poll_group_mod_done cb_fn, void *cb_arg); +void nvmf_poll_group_pause_subsystem(struct spdk_nvmf_poll_group *group, + struct spdk_nvmf_subsystem *subsystem, spdk_nvmf_poll_group_mod_done cb_fn, void *cb_arg); +void nvmf_poll_group_resume_subsystem(struct spdk_nvmf_poll_group *group, + struct spdk_nvmf_subsystem *subsystem, spdk_nvmf_poll_group_mod_done cb_fn, void *cb_arg); -void spdk_nvmf_get_discovery_log_page(struct spdk_nvmf_tgt *tgt, const char *hostnqn, - struct iovec *iov, - uint32_t iovcnt, uint64_t offset, uint32_t length); +void nvmf_get_discovery_log_page(struct spdk_nvmf_tgt *tgt, const char *hostnqn, + struct iovec *iov, + uint32_t iovcnt, uint64_t offset, uint32_t length); -void spdk_nvmf_ctrlr_destruct(struct spdk_nvmf_ctrlr *ctrlr); -int spdk_nvmf_ctrlr_process_fabrics_cmd(struct spdk_nvmf_request *req); +void nvmf_ctrlr_destruct(struct spdk_nvmf_ctrlr *ctrlr); +int nvmf_ctrlr_process_fabrics_cmd(struct spdk_nvmf_request *req); int spdk_nvmf_ctrlr_connect(struct spdk_nvmf_request *req); -int spdk_nvmf_ctrlr_process_admin_cmd(struct spdk_nvmf_request *req); -int spdk_nvmf_ctrlr_process_io_cmd(struct spdk_nvmf_request *req); -bool spdk_nvmf_ctrlr_dsm_supported(struct spdk_nvmf_ctrlr *ctrlr); -bool spdk_nvmf_ctrlr_write_zeroes_supported(struct spdk_nvmf_ctrlr *ctrlr); -void spdk_nvmf_ctrlr_ns_changed(struct spdk_nvmf_ctrlr *ctrlr, uint32_t nsid); +int nvmf_ctrlr_process_admin_cmd(struct spdk_nvmf_request *req); +int nvmf_ctrlr_process_io_cmd(struct spdk_nvmf_request *req); +bool nvmf_ctrlr_dsm_supported(struct spdk_nvmf_ctrlr *ctrlr); +bool nvmf_ctrlr_write_zeroes_supported(struct spdk_nvmf_ctrlr *ctrlr); +void nvmf_ctrlr_ns_changed(struct spdk_nvmf_ctrlr *ctrlr, uint32_t nsid); -void spdk_nvmf_bdev_ctrlr_identify_ns(struct spdk_nvmf_ns *ns, struct spdk_nvme_ns_data *nsdata, - bool dif_insert_or_strip); -int spdk_nvmf_bdev_ctrlr_read_cmd(struct spdk_bdev *bdev, struct spdk_bdev_desc *desc, - struct spdk_io_channel *ch, struct spdk_nvmf_request *req); -int spdk_nvmf_bdev_ctrlr_write_cmd(struct spdk_bdev *bdev, struct spdk_bdev_desc *desc, - struct spdk_io_channel *ch, struct spdk_nvmf_request *req); -int spdk_nvmf_bdev_ctrlr_compare_cmd(struct spdk_bdev *bdev, struct spdk_bdev_desc *desc, - struct spdk_io_channel *ch, struct spdk_nvmf_request *req); -int spdk_nvmf_bdev_ctrlr_compare_and_write_cmd(struct spdk_bdev *bdev, struct spdk_bdev_desc *desc, +void nvmf_bdev_ctrlr_identify_ns(struct spdk_nvmf_ns *ns, struct spdk_nvme_ns_data *nsdata, + bool dif_insert_or_strip); +int nvmf_bdev_ctrlr_read_cmd(struct spdk_bdev *bdev, struct spdk_bdev_desc *desc, + struct spdk_io_channel *ch, struct spdk_nvmf_request *req); +int nvmf_bdev_ctrlr_write_cmd(struct spdk_bdev *bdev, struct spdk_bdev_desc *desc, + struct spdk_io_channel *ch, struct spdk_nvmf_request *req); +int nvmf_bdev_ctrlr_compare_cmd(struct spdk_bdev *bdev, struct spdk_bdev_desc *desc, + struct spdk_io_channel *ch, struct spdk_nvmf_request *req); +int nvmf_bdev_ctrlr_compare_and_write_cmd(struct spdk_bdev *bdev, struct spdk_bdev_desc *desc, struct spdk_io_channel *ch, struct spdk_nvmf_request *cmp_req, struct spdk_nvmf_request *write_req); -int spdk_nvmf_bdev_ctrlr_write_zeroes_cmd(struct spdk_bdev *bdev, struct spdk_bdev_desc *desc, - struct spdk_io_channel *ch, struct spdk_nvmf_request *req); -int spdk_nvmf_bdev_ctrlr_flush_cmd(struct spdk_bdev *bdev, struct spdk_bdev_desc *desc, - struct spdk_io_channel *ch, struct spdk_nvmf_request *req); -int spdk_nvmf_bdev_ctrlr_dsm_cmd(struct spdk_bdev *bdev, struct spdk_bdev_desc *desc, - struct spdk_io_channel *ch, struct spdk_nvmf_request *req); -int spdk_nvmf_bdev_ctrlr_nvme_passthru_io(struct spdk_bdev *bdev, struct spdk_bdev_desc *desc, - struct spdk_io_channel *ch, struct spdk_nvmf_request *req); -bool spdk_nvmf_bdev_ctrlr_get_dif_ctx(struct spdk_bdev *bdev, struct spdk_nvme_cmd *cmd, - struct spdk_dif_ctx *dif_ctx); +int nvmf_bdev_ctrlr_write_zeroes_cmd(struct spdk_bdev *bdev, struct spdk_bdev_desc *desc, + struct spdk_io_channel *ch, struct spdk_nvmf_request *req); +int nvmf_bdev_ctrlr_flush_cmd(struct spdk_bdev *bdev, struct spdk_bdev_desc *desc, + struct spdk_io_channel *ch, struct spdk_nvmf_request *req); +int nvmf_bdev_ctrlr_dsm_cmd(struct spdk_bdev *bdev, struct spdk_bdev_desc *desc, + struct spdk_io_channel *ch, struct spdk_nvmf_request *req); +int nvmf_bdev_ctrlr_nvme_passthru_io(struct spdk_bdev *bdev, struct spdk_bdev_desc *desc, + struct spdk_io_channel *ch, struct spdk_nvmf_request *req); +bool nvmf_bdev_ctrlr_get_dif_ctx(struct spdk_bdev *bdev, struct spdk_nvme_cmd *cmd, + struct spdk_dif_ctx *dif_ctx); -int spdk_nvmf_subsystem_add_ctrlr(struct spdk_nvmf_subsystem *subsystem, - struct spdk_nvmf_ctrlr *ctrlr); -void spdk_nvmf_subsystem_remove_ctrlr(struct spdk_nvmf_subsystem *subsystem, - struct spdk_nvmf_ctrlr *ctrlr); -void spdk_nvmf_subsystem_remove_all_listeners(struct spdk_nvmf_subsystem *subsystem, +int nvmf_subsystem_add_ctrlr(struct spdk_nvmf_subsystem *subsystem, + struct spdk_nvmf_ctrlr *ctrlr); +void nvmf_subsystem_remove_ctrlr(struct spdk_nvmf_subsystem *subsystem, + struct spdk_nvmf_ctrlr *ctrlr); +void nvmf_subsystem_remove_all_listeners(struct spdk_nvmf_subsystem *subsystem, bool stop); -struct spdk_nvmf_ctrlr *spdk_nvmf_subsystem_get_ctrlr(struct spdk_nvmf_subsystem *subsystem, +struct spdk_nvmf_ctrlr *nvmf_subsystem_get_ctrlr(struct spdk_nvmf_subsystem *subsystem, uint16_t cntlid); -struct spdk_nvmf_subsystem_listener *spdk_nvmf_subsystem_find_listener( +struct spdk_nvmf_subsystem_listener *nvmf_subsystem_find_listener( struct spdk_nvmf_subsystem *subsystem, const struct spdk_nvme_transport_id *trid); -struct spdk_nvmf_listener *spdk_nvmf_transport_find_listener( +struct spdk_nvmf_listener *nvmf_transport_find_listener( struct spdk_nvmf_transport *transport, const struct spdk_nvme_transport_id *trid); -int spdk_nvmf_ctrlr_async_event_ns_notice(struct spdk_nvmf_ctrlr *ctrlr); -void spdk_nvmf_ctrlr_async_event_reservation_notification(struct spdk_nvmf_ctrlr *ctrlr); -void spdk_nvmf_ns_reservation_request(void *ctx); -void spdk_nvmf_ctrlr_reservation_notice_log(struct spdk_nvmf_ctrlr *ctrlr, - struct spdk_nvmf_ns *ns, - enum spdk_nvme_reservation_notification_log_page_type type); +int nvmf_ctrlr_async_event_ns_notice(struct spdk_nvmf_ctrlr *ctrlr); +void nvmf_ctrlr_async_event_reservation_notification(struct spdk_nvmf_ctrlr *ctrlr); +void nvmf_ns_reservation_request(void *ctx); +void nvmf_ctrlr_reservation_notice_log(struct spdk_nvmf_ctrlr *ctrlr, + struct spdk_nvmf_ns *ns, + enum spdk_nvme_reservation_notification_log_page_type type); /* * Abort aer is sent on a per controller basis and sends a completion for the aer to the host. * This function should be called when attempting to recover in error paths when it is OK for * the host to send a subsequent AER. */ -void spdk_nvmf_ctrlr_abort_aer(struct spdk_nvmf_ctrlr *ctrlr); +void nvmf_ctrlr_abort_aer(struct spdk_nvmf_ctrlr *ctrlr); /* * Free aer simply frees the rdma resources for the aer without informing the host. @@ -337,10 +337,10 @@ void spdk_nvmf_ctrlr_abort_aer(struct spdk_nvmf_ctrlr *ctrlr); * the qpair is completely empty before freeing the request. The reason we free the * AER without sending a completion is to prevent the host from sending another AER. */ -void spdk_nvmf_qpair_free_aer(struct spdk_nvmf_qpair *qpair); +void nvmf_qpair_free_aer(struct spdk_nvmf_qpair *qpair); static inline struct spdk_nvmf_ns * -_spdk_nvmf_subsystem_get_ns(struct spdk_nvmf_subsystem *subsystem, uint32_t nsid) +_nvmf_subsystem_get_ns(struct spdk_nvmf_subsystem *subsystem, uint32_t nsid) { /* NOTE: This implicitly also checks for 0, since 0 - 1 wraps around to UINT32_MAX. */ if (spdk_unlikely(nsid - 1 >= subsystem->max_nsid)) { @@ -351,7 +351,7 @@ _spdk_nvmf_subsystem_get_ns(struct spdk_nvmf_subsystem *subsystem, uint32_t nsid } static inline bool -spdk_nvmf_qpair_is_admin_queue(struct spdk_nvmf_qpair *qpair) +nvmf_qpair_is_admin_queue(struct spdk_nvmf_qpair *qpair) { return qpair->qid == 0; } diff --git a/lib/nvmf/nvmf_rpc.c b/lib/nvmf/nvmf_rpc.c index bd22cae7d..e7af8ca53 100644 --- a/lib/nvmf/nvmf_rpc.c +++ b/lib/nvmf/nvmf_rpc.c @@ -472,7 +472,7 @@ spdk_rpc_nvmf_subsystem_stopped(struct spdk_nvmf_subsystem *subsystem, struct spdk_jsonrpc_request *request = cb_arg; struct spdk_json_write_ctx *w; - spdk_nvmf_subsystem_remove_all_listeners(subsystem, true); + nvmf_subsystem_remove_all_listeners(subsystem, true); spdk_nvmf_subsystem_destroy(subsystem); w = spdk_jsonrpc_begin_result(request); @@ -666,7 +666,7 @@ nvmf_rpc_listen_paused(struct spdk_nvmf_subsystem *subsystem, int rc; if (ctx->op == NVMF_RPC_LISTEN_ADD) { - if (!spdk_nvmf_subsystem_find_listener(subsystem, &ctx->trid)) { + if (!nvmf_subsystem_find_listener(subsystem, &ctx->trid)) { rc = spdk_nvmf_tgt_listen(ctx->tgt, &ctx->trid); if (rc == 0) { spdk_nvmf_subsystem_add_listener(ctx->subsystem, &ctx->trid, nvmf_rpc_subsystem_listen, ctx); diff --git a/lib/nvmf/subsystem.c b/lib/nvmf/subsystem.c index 9615384f9..264199aa1 100644 --- a/lib/nvmf/subsystem.c +++ b/lib/nvmf/subsystem.c @@ -345,14 +345,14 @@ spdk_nvmf_subsystem_destroy(struct spdk_nvmf_subsystem *subsystem) SPDK_DEBUGLOG(SPDK_LOG_NVMF, "subsystem is %p\n", subsystem); - spdk_nvmf_subsystem_remove_all_listeners(subsystem, false); + nvmf_subsystem_remove_all_listeners(subsystem, false); TAILQ_FOREACH_SAFE(host, &subsystem->hosts, link, host_tmp) { _spdk_nvmf_subsystem_remove_host(subsystem, host); } TAILQ_FOREACH_SAFE(ctrlr, &subsystem->ctrlrs, link, ctrlr_tmp) { - spdk_nvmf_ctrlr_destruct(ctrlr); + nvmf_ctrlr_destruct(ctrlr); } ns = spdk_nvmf_subsystem_get_first_ns(subsystem); @@ -473,17 +473,17 @@ subsystem_state_change_on_pg(struct spdk_io_channel_iter *i) switch (ctx->requested_state) { case SPDK_NVMF_SUBSYSTEM_INACTIVE: - spdk_nvmf_poll_group_remove_subsystem(group, ctx->subsystem, subsystem_state_change_continue, i); + nvmf_poll_group_remove_subsystem(group, ctx->subsystem, subsystem_state_change_continue, i); break; case SPDK_NVMF_SUBSYSTEM_ACTIVE: if (ctx->subsystem->state == SPDK_NVMF_SUBSYSTEM_ACTIVATING) { - spdk_nvmf_poll_group_add_subsystem(group, ctx->subsystem, subsystem_state_change_continue, i); + nvmf_poll_group_add_subsystem(group, ctx->subsystem, subsystem_state_change_continue, i); } else if (ctx->subsystem->state == SPDK_NVMF_SUBSYSTEM_RESUMING) { - spdk_nvmf_poll_group_resume_subsystem(group, ctx->subsystem, subsystem_state_change_continue, i); + nvmf_poll_group_resume_subsystem(group, ctx->subsystem, subsystem_state_change_continue, i); } break; case SPDK_NVMF_SUBSYSTEM_PAUSED: - spdk_nvmf_poll_group_pause_subsystem(group, ctx->subsystem, subsystem_state_change_continue, i); + nvmf_poll_group_pause_subsystem(group, ctx->subsystem, subsystem_state_change_continue, i); break; default: assert(false); @@ -733,8 +733,8 @@ spdk_nvmf_host_get_nqn(const struct spdk_nvmf_host *host) } struct spdk_nvmf_subsystem_listener * -spdk_nvmf_subsystem_find_listener(struct spdk_nvmf_subsystem *subsystem, - const struct spdk_nvme_transport_id *trid) +nvmf_subsystem_find_listener(struct spdk_nvmf_subsystem *subsystem, + const struct spdk_nvme_transport_id *trid) { struct spdk_nvmf_subsystem_listener *listener; @@ -787,7 +787,7 @@ spdk_nvmf_subsystem_add_listener(struct spdk_nvmf_subsystem *subsystem, return; } - if (spdk_nvmf_subsystem_find_listener(subsystem, trid)) { + if (nvmf_subsystem_find_listener(subsystem, trid)) { /* Listener already exists in this subsystem */ cb_fn(cb_arg, 0); return; @@ -800,7 +800,7 @@ spdk_nvmf_subsystem_add_listener(struct spdk_nvmf_subsystem *subsystem, return; } - tr_listener = spdk_nvmf_transport_find_listener(transport, trid); + tr_listener = nvmf_transport_find_listener(transport, trid); if (!tr_listener) { SPDK_ERRLOG("Cannot find transport listener for %s\n", trid->traddr); cb_fn(cb_arg, -EINVAL); @@ -839,7 +839,7 @@ spdk_nvmf_subsystem_remove_listener(struct spdk_nvmf_subsystem *subsystem, return -EAGAIN; } - listener = spdk_nvmf_subsystem_find_listener(subsystem, trid); + listener = nvmf_subsystem_find_listener(subsystem, trid); if (listener == NULL) { return -ENOENT; } @@ -850,8 +850,8 @@ spdk_nvmf_subsystem_remove_listener(struct spdk_nvmf_subsystem *subsystem, } void -spdk_nvmf_subsystem_remove_all_listeners(struct spdk_nvmf_subsystem *subsystem, - bool stop) +nvmf_subsystem_remove_all_listeners(struct spdk_nvmf_subsystem *subsystem, + bool stop) { struct spdk_nvmf_subsystem_listener *listener, *listener_tmp; @@ -942,7 +942,7 @@ subsystem_update_ns_on_pg(struct spdk_io_channel_iter *i) group = spdk_io_channel_get_ctx(spdk_io_channel_iter_get_channel(i)); subsystem = ctx->subsystem; - rc = spdk_nvmf_poll_group_update_subsystem(group, subsystem); + rc = nvmf_poll_group_update_subsystem(group, subsystem); spdk_for_each_channel_continue(i, rc); } @@ -964,7 +964,7 @@ spdk_nvmf_subsystem_ns_changed(struct spdk_nvmf_subsystem *subsystem, uint32_t n struct spdk_nvmf_ctrlr *ctrlr; TAILQ_FOREACH(ctrlr, &subsystem->ctrlrs, link) { - spdk_nvmf_ctrlr_ns_changed(ctrlr, nsid); + nvmf_ctrlr_ns_changed(ctrlr, nsid); } } @@ -1138,13 +1138,13 @@ spdk_nvmf_subsystem_add_ns(struct spdk_nvmf_subsystem *subsystem, struct spdk_bd * expand max_nsid if possible. */ for (opts.nsid = 1; opts.nsid <= subsystem->max_nsid; opts.nsid++) { - if (_spdk_nvmf_subsystem_get_ns(subsystem, opts.nsid) == NULL) { + if (_nvmf_subsystem_get_ns(subsystem, opts.nsid) == NULL) { break; } } } - if (_spdk_nvmf_subsystem_get_ns(subsystem, opts.nsid)) { + if (_nvmf_subsystem_get_ns(subsystem, opts.nsid)) { SPDK_ERRLOG("Requested NSID %" PRIu32 " already in use\n", opts.nsid); return 0; } @@ -1252,7 +1252,7 @@ spdk_nvmf_subsystem_get_first_ns(struct spdk_nvmf_subsystem *subsystem) uint32_t first_nsid; first_nsid = spdk_nvmf_subsystem_get_next_allocated_nsid(subsystem, 0); - return _spdk_nvmf_subsystem_get_ns(subsystem, first_nsid); + return _nvmf_subsystem_get_ns(subsystem, first_nsid); } struct spdk_nvmf_ns * @@ -1262,13 +1262,13 @@ spdk_nvmf_subsystem_get_next_ns(struct spdk_nvmf_subsystem *subsystem, uint32_t next_nsid; next_nsid = spdk_nvmf_subsystem_get_next_allocated_nsid(subsystem, prev_ns->opts.nsid); - return _spdk_nvmf_subsystem_get_ns(subsystem, next_nsid); + return _nvmf_subsystem_get_ns(subsystem, next_nsid); } struct spdk_nvmf_ns * spdk_nvmf_subsystem_get_ns(struct spdk_nvmf_subsystem *subsystem, uint32_t nsid) { - return _spdk_nvmf_subsystem_get_ns(subsystem, nsid); + return _nvmf_subsystem_get_ns(subsystem, nsid); } uint32_t @@ -1388,7 +1388,7 @@ spdk_nvmf_subsystem_gen_cntlid(struct spdk_nvmf_subsystem *subsystem) } /* Check if a controller with this cntlid currently exists. */ - if (spdk_nvmf_subsystem_get_ctrlr(subsystem, subsystem->next_cntlid) == NULL) { + if (nvmf_subsystem_get_ctrlr(subsystem, subsystem->next_cntlid) == NULL) { /* Found unused cntlid */ return subsystem->next_cntlid; } @@ -1399,7 +1399,7 @@ spdk_nvmf_subsystem_gen_cntlid(struct spdk_nvmf_subsystem *subsystem) } int -spdk_nvmf_subsystem_add_ctrlr(struct spdk_nvmf_subsystem *subsystem, struct spdk_nvmf_ctrlr *ctrlr) +nvmf_subsystem_add_ctrlr(struct spdk_nvmf_subsystem *subsystem, struct spdk_nvmf_ctrlr *ctrlr) { ctrlr->cntlid = spdk_nvmf_subsystem_gen_cntlid(subsystem); if (ctrlr->cntlid == 0xFFFF) { @@ -1414,15 +1414,15 @@ spdk_nvmf_subsystem_add_ctrlr(struct spdk_nvmf_subsystem *subsystem, struct spdk } void -spdk_nvmf_subsystem_remove_ctrlr(struct spdk_nvmf_subsystem *subsystem, - struct spdk_nvmf_ctrlr *ctrlr) +nvmf_subsystem_remove_ctrlr(struct spdk_nvmf_subsystem *subsystem, + struct spdk_nvmf_ctrlr *ctrlr) { assert(subsystem == ctrlr->subsys); TAILQ_REMOVE(&subsystem->ctrlrs, ctrlr, link); } struct spdk_nvmf_ctrlr * -spdk_nvmf_subsystem_get_ctrlr(struct spdk_nvmf_subsystem *subsystem, uint16_t cntlid) +nvmf_subsystem_get_ctrlr(struct spdk_nvmf_subsystem *subsystem, uint16_t cntlid) { struct spdk_nvmf_ctrlr *ctrlr; @@ -1758,7 +1758,7 @@ nvmf_subsystem_gen_ctrlr_notification(struct spdk_nvmf_subsystem *subsystem, for (i = 0; i < num_hostid; i++) { TAILQ_FOREACH(ctrlr, &subsystem->ctrlrs, link) { if (!spdk_uuid_compare(&ctrlr->hostid, &hostid_list[i])) { - spdk_nvmf_ctrlr_reservation_notice_log(ctrlr, ns, type); + nvmf_ctrlr_reservation_notice_log(ctrlr, ns, type); } } } @@ -2465,7 +2465,7 @@ _nvmf_ns_reservation_update_done(struct spdk_nvmf_subsystem *subsystem, } void -spdk_nvmf_ns_reservation_request(void *ctx) +nvmf_ns_reservation_request(void *ctx) { struct spdk_nvmf_request *req = (struct spdk_nvmf_request *)ctx; struct spdk_nvme_cmd *cmd = &req->cmd->nvme_cmd; @@ -2476,7 +2476,7 @@ spdk_nvmf_ns_reservation_request(void *ctx) bool update_sgroup = false; nsid = cmd->nsid; - ns = _spdk_nvmf_subsystem_get_ns(ctrlr->subsys, nsid); + ns = _nvmf_subsystem_get_ns(ctrlr->subsys, nsid); assert(ns != NULL); switch (cmd->opc) { diff --git a/lib/nvmf/transport.c b/lib/nvmf/transport.c index 78cd288b1..af931bab6 100644 --- a/lib/nvmf/transport.c +++ b/lib/nvmf/transport.c @@ -189,8 +189,8 @@ spdk_nvmf_transport_destroy(struct spdk_nvmf_transport *transport) } struct spdk_nvmf_listener * -spdk_nvmf_transport_find_listener(struct spdk_nvmf_transport *transport, - const struct spdk_nvme_transport_id *trid) +nvmf_transport_find_listener(struct spdk_nvmf_transport *transport, + const struct spdk_nvme_transport_id *trid) { struct spdk_nvmf_listener *listener; @@ -210,7 +210,7 @@ spdk_nvmf_transport_listen(struct spdk_nvmf_transport *transport, struct spdk_nvmf_listener *listener; int rc; - listener = spdk_nvmf_transport_find_listener(transport, trid); + listener = nvmf_transport_find_listener(transport, trid); if (!listener) { listener = calloc(1, sizeof(*listener)); if (!listener) { @@ -240,7 +240,7 @@ spdk_nvmf_transport_stop_listen(struct spdk_nvmf_transport *transport, { struct spdk_nvmf_listener *listener; - listener = spdk_nvmf_transport_find_listener(transport, trid); + listener = nvmf_transport_find_listener(transport, trid); if (!listener) { return -ENOENT; } diff --git a/test/unit/lib/nvmf/ctrlr.c/ctrlr_ut.c b/test/unit/lib/nvmf/ctrlr.c/ctrlr_ut.c index 1a444b31c..bbcdeedc4 100644 --- a/test/unit/lib/nvmf/ctrlr.c/ctrlr_ut.c +++ b/test/unit/lib/nvmf/ctrlr.c/ctrlr_ut.c @@ -85,27 +85,27 @@ DEFINE_STUB(spdk_nvmf_subsystem_host_allowed, (struct spdk_nvmf_subsystem *subsystem, const char *hostnqn), true); -DEFINE_STUB(spdk_nvmf_subsystem_add_ctrlr, +DEFINE_STUB(nvmf_subsystem_add_ctrlr, int, (struct spdk_nvmf_subsystem *subsystem, struct spdk_nvmf_ctrlr *ctrlr), 0); -DEFINE_STUB(spdk_nvmf_subsystem_get_ctrlr, +DEFINE_STUB(nvmf_subsystem_get_ctrlr, struct spdk_nvmf_ctrlr *, (struct spdk_nvmf_subsystem *subsystem, uint16_t cntlid), NULL); -DEFINE_STUB(spdk_nvmf_ctrlr_dsm_supported, +DEFINE_STUB(nvmf_ctrlr_dsm_supported, bool, (struct spdk_nvmf_ctrlr *ctrlr), false); -DEFINE_STUB(spdk_nvmf_ctrlr_write_zeroes_supported, +DEFINE_STUB(nvmf_ctrlr_write_zeroes_supported, bool, (struct spdk_nvmf_ctrlr *ctrlr), false); -DEFINE_STUB_V(spdk_nvmf_get_discovery_log_page, +DEFINE_STUB_V(nvmf_get_discovery_log_page, (struct spdk_nvmf_tgt *tgt, const char *hostnqn, struct iovec *iov, uint32_t iovcnt, uint64_t offset, uint32_t length)); @@ -119,49 +119,49 @@ DEFINE_STUB(spdk_nvmf_subsystem_listener_allowed, (struct spdk_nvmf_subsystem *subsystem, const struct spdk_nvme_transport_id *trid), true); -DEFINE_STUB(spdk_nvmf_bdev_ctrlr_read_cmd, +DEFINE_STUB(nvmf_bdev_ctrlr_read_cmd, int, (struct spdk_bdev *bdev, struct spdk_bdev_desc *desc, struct spdk_io_channel *ch, struct spdk_nvmf_request *req), 0); -DEFINE_STUB(spdk_nvmf_bdev_ctrlr_write_cmd, +DEFINE_STUB(nvmf_bdev_ctrlr_write_cmd, int, (struct spdk_bdev *bdev, struct spdk_bdev_desc *desc, struct spdk_io_channel *ch, struct spdk_nvmf_request *req), 0); -DEFINE_STUB(spdk_nvmf_bdev_ctrlr_compare_cmd, +DEFINE_STUB(nvmf_bdev_ctrlr_compare_cmd, int, (struct spdk_bdev *bdev, struct spdk_bdev_desc *desc, struct spdk_io_channel *ch, struct spdk_nvmf_request *req), 0); -DEFINE_STUB(spdk_nvmf_bdev_ctrlr_compare_and_write_cmd, +DEFINE_STUB(nvmf_bdev_ctrlr_compare_and_write_cmd, int, (struct spdk_bdev *bdev, struct spdk_bdev_desc *desc, struct spdk_io_channel *ch, struct spdk_nvmf_request *cmp_req, struct spdk_nvmf_request *write_req), 0); -DEFINE_STUB(spdk_nvmf_bdev_ctrlr_write_zeroes_cmd, +DEFINE_STUB(nvmf_bdev_ctrlr_write_zeroes_cmd, int, (struct spdk_bdev *bdev, struct spdk_bdev_desc *desc, struct spdk_io_channel *ch, struct spdk_nvmf_request *req), 0); -DEFINE_STUB(spdk_nvmf_bdev_ctrlr_flush_cmd, +DEFINE_STUB(nvmf_bdev_ctrlr_flush_cmd, int, (struct spdk_bdev *bdev, struct spdk_bdev_desc *desc, struct spdk_io_channel *ch, struct spdk_nvmf_request *req), 0); -DEFINE_STUB(spdk_nvmf_bdev_ctrlr_dsm_cmd, +DEFINE_STUB(nvmf_bdev_ctrlr_dsm_cmd, int, (struct spdk_bdev *bdev, struct spdk_bdev_desc *desc, struct spdk_io_channel *ch, struct spdk_nvmf_request *req), 0); -DEFINE_STUB(spdk_nvmf_bdev_ctrlr_nvme_passthru_io, +DEFINE_STUB(nvmf_bdev_ctrlr_nvme_passthru_io, int, (struct spdk_bdev *bdev, struct spdk_bdev_desc *desc, struct spdk_io_channel *ch, struct spdk_nvmf_request *req), @@ -172,9 +172,9 @@ DEFINE_STUB(spdk_nvmf_transport_req_complete, (struct spdk_nvmf_request *req), 0); -DEFINE_STUB_V(spdk_nvmf_ns_reservation_request, (void *ctx)); +DEFINE_STUB_V(nvmf_ns_reservation_request, (void *ctx)); -DEFINE_STUB(spdk_nvmf_bdev_ctrlr_get_dif_ctx, bool, +DEFINE_STUB(nvmf_bdev_ctrlr_get_dif_ctx, bool, (struct spdk_bdev *bdev, struct spdk_nvme_cmd *cmd, struct spdk_dif_ctx *dif_ctx), true); @@ -186,8 +186,8 @@ spdk_nvmf_qpair_disconnect(struct spdk_nvmf_qpair *qpair, nvmf_qpair_disconnect_ } void -spdk_nvmf_bdev_ctrlr_identify_ns(struct spdk_nvmf_ns *ns, struct spdk_nvme_ns_data *nsdata, - bool dif_insert_or_strip) +nvmf_bdev_ctrlr_identify_ns(struct spdk_nvmf_ns *ns, struct spdk_nvme_ns_data *nsdata, + bool dif_insert_or_strip) { uint64_t num_blocks; @@ -283,7 +283,7 @@ test_process_fabrics_cmd(void) /* No ctrlr and invalid command check */ req.cmd->nvmf_cmd.fctype = SPDK_NVMF_FABRIC_COMMAND_PROPERTY_GET; - ret = spdk_nvmf_ctrlr_process_fabrics_cmd(&req); + ret = nvmf_ctrlr_process_fabrics_cmd(&req); CU_ASSERT_EQUAL(req.rsp->nvme_cpl.status.sc, SPDK_NVME_SC_COMMAND_SEQUENCE_ERROR); CU_ASSERT_EQUAL(ret, SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); } @@ -542,7 +542,7 @@ test_connect(void) /* Valid I/O queue connect command */ memset(&rsp, 0, sizeof(rsp)); - MOCK_SET(spdk_nvmf_subsystem_get_ctrlr, &ctrlr); + MOCK_SET(nvmf_subsystem_get_ctrlr, &ctrlr); cmd.connect_cmd.qid = 1; cmd.connect_cmd.sqsize = 63; sgroups[subsystem.id].io_outstanding++; @@ -558,7 +558,7 @@ test_connect(void) /* Non-existent controller */ memset(&rsp, 0, sizeof(rsp)); - MOCK_SET(spdk_nvmf_subsystem_get_ctrlr, NULL); + MOCK_SET(nvmf_subsystem_get_ctrlr, NULL); sgroups[subsystem.id].io_outstanding++; TAILQ_INSERT_TAIL(&qpair.outstanding, &req, link); rc = spdk_nvmf_ctrlr_cmd_connect(&req); @@ -570,7 +570,7 @@ test_connect(void) CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.ipo == 16); CU_ASSERT(qpair.ctrlr == NULL); CU_ASSERT(sgroups[subsystem.id].io_outstanding == 0); - MOCK_SET(spdk_nvmf_subsystem_get_ctrlr, &ctrlr); + MOCK_SET(nvmf_subsystem_get_ctrlr, &ctrlr); /* I/O connect to discovery controller */ memset(&rsp, 0, sizeof(rsp)); @@ -769,14 +769,14 @@ test_get_ns_id_desc_list(void) /* Invalid NSID */ cmd.nvme_cmd.nsid = 0; memset(&rsp, 0, sizeof(rsp)); - CU_ASSERT(spdk_nvmf_ctrlr_process_admin_cmd(&req) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); + CU_ASSERT(nvmf_ctrlr_process_admin_cmd(&req) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_GENERIC); CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVME_SC_INVALID_NAMESPACE_OR_FORMAT); /* Valid NSID, but ns has no IDs defined */ cmd.nvme_cmd.nsid = 1; memset(&rsp, 0, sizeof(rsp)); - CU_ASSERT(spdk_nvmf_ctrlr_process_admin_cmd(&req) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); + CU_ASSERT(nvmf_ctrlr_process_admin_cmd(&req) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_GENERIC); CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVME_SC_SUCCESS); CU_ASSERT(spdk_mem_all_zero(buf, sizeof(buf))); @@ -785,7 +785,7 @@ test_get_ns_id_desc_list(void) ns.opts.eui64[0] = 0x11; ns.opts.eui64[7] = 0xFF; memset(&rsp, 0, sizeof(rsp)); - CU_ASSERT(spdk_nvmf_ctrlr_process_admin_cmd(&req) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); + CU_ASSERT(nvmf_ctrlr_process_admin_cmd(&req) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_GENERIC); CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVME_SC_SUCCESS); CU_ASSERT(buf[0] == SPDK_NVME_NIDT_EUI64); @@ -799,7 +799,7 @@ test_get_ns_id_desc_list(void) ns.opts.nguid[0] = 0x22; ns.opts.nguid[15] = 0xEE; memset(&rsp, 0, sizeof(rsp)); - CU_ASSERT(spdk_nvmf_ctrlr_process_admin_cmd(&req) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); + CU_ASSERT(nvmf_ctrlr_process_admin_cmd(&req) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_GENERIC); CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVME_SC_SUCCESS); CU_ASSERT(buf[0] == SPDK_NVME_NIDT_NGUID); @@ -814,7 +814,7 @@ test_get_ns_id_desc_list(void) ns.opts.nguid[0] = 0x22; ns.opts.nguid[15] = 0xEE; memset(&rsp, 0, sizeof(rsp)); - CU_ASSERT(spdk_nvmf_ctrlr_process_admin_cmd(&req) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); + CU_ASSERT(nvmf_ctrlr_process_admin_cmd(&req) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_GENERIC); CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVME_SC_SUCCESS); CU_ASSERT(buf[0] == SPDK_NVME_NIDT_EUI64); @@ -835,7 +835,7 @@ test_get_ns_id_desc_list(void) ns.opts.uuid.u.raw[0] = 0x33; ns.opts.uuid.u.raw[15] = 0xDD; memset(&rsp, 0, sizeof(rsp)); - CU_ASSERT(spdk_nvmf_ctrlr_process_admin_cmd(&req) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); + CU_ASSERT(nvmf_ctrlr_process_admin_cmd(&req) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_GENERIC); CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVME_SC_SUCCESS); CU_ASSERT(buf[0] == SPDK_NVME_NIDT_EUI64); @@ -1284,12 +1284,12 @@ test_reservation_notification_log_page(void) ns.mask = SPDK_NVME_REGISTRATION_PREEMPTED_MASK | SPDK_NVME_RESERVATION_RELEASED_MASK | SPDK_NVME_RESERVATION_PREEMPTED_MASK; - spdk_nvmf_ctrlr_reservation_notice_log(&ctrlr, &ns, - SPDK_NVME_REGISTRATION_PREEMPTED); - spdk_nvmf_ctrlr_reservation_notice_log(&ctrlr, &ns, - SPDK_NVME_RESERVATION_RELEASED); - spdk_nvmf_ctrlr_reservation_notice_log(&ctrlr, &ns, - SPDK_NVME_RESERVATION_PREEMPTED); + nvmf_ctrlr_reservation_notice_log(&ctrlr, &ns, + SPDK_NVME_REGISTRATION_PREEMPTED); + nvmf_ctrlr_reservation_notice_log(&ctrlr, &ns, + SPDK_NVME_RESERVATION_RELEASED); + nvmf_ctrlr_reservation_notice_log(&ctrlr, &ns, + SPDK_NVME_RESERVATION_PREEMPTED); poll_threads(); SPDK_CU_ASSERT_FATAL(TAILQ_EMPTY(&ctrlr.log_head)); @@ -1307,12 +1307,12 @@ test_reservation_notification_log_page(void) qpair.state = SPDK_NVMF_QPAIR_ACTIVE; TAILQ_INSERT_TAIL(&qpair.outstanding, &req, link); - spdk_nvmf_ctrlr_reservation_notice_log(&ctrlr, &ns, - SPDK_NVME_REGISTRATION_PREEMPTED); - spdk_nvmf_ctrlr_reservation_notice_log(&ctrlr, &ns, - SPDK_NVME_RESERVATION_RELEASED); - spdk_nvmf_ctrlr_reservation_notice_log(&ctrlr, &ns, - SPDK_NVME_RESERVATION_PREEMPTED); + nvmf_ctrlr_reservation_notice_log(&ctrlr, &ns, + SPDK_NVME_REGISTRATION_PREEMPTED); + nvmf_ctrlr_reservation_notice_log(&ctrlr, &ns, + SPDK_NVME_RESERVATION_RELEASED); + nvmf_ctrlr_reservation_notice_log(&ctrlr, &ns, + SPDK_NVME_RESERVATION_PREEMPTED); poll_threads(); event.raw = rsp.nvme_cpl.cdw0; SPDK_CU_ASSERT_FATAL(event.bits.async_event_type == SPDK_NVME_ASYNC_EVENT_TYPE_IO); @@ -1489,7 +1489,7 @@ test_custom_admin_cmd(void) spdk_nvmf_set_custom_admin_cmd_hdlr(cmd.nvme_cmd.opc, custom_admin_cmd_hdlr); /* Ensure that our hdlr is being called */ - rc = spdk_nvmf_ctrlr_process_admin_cmd(&req); + rc = nvmf_ctrlr_process_admin_cmd(&req); CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_GENERIC); CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVME_SC_SUCCESS); diff --git a/test/unit/lib/nvmf/ctrlr_bdev.c/ctrlr_bdev_ut.c b/test/unit/lib/nvmf/ctrlr_bdev.c/ctrlr_bdev_ut.c index 6a17bbe59..0df9c983b 100644 --- a/test/unit/lib/nvmf/ctrlr_bdev.c/ctrlr_bdev_ut.c +++ b/test/unit/lib/nvmf/ctrlr_bdev.c/ctrlr_bdev_ut.c @@ -85,7 +85,7 @@ DEFINE_STUB(spdk_bdev_comparev_and_writev_blocks, int, spdk_bdev_io_completion_cb cb, void *cb_arg), 0); -DEFINE_STUB(spdk_nvmf_ctrlr_process_io_cmd, int, (struct spdk_nvmf_request *req), 0); +DEFINE_STUB(nvmf_ctrlr_process_io_cmd, int, (struct spdk_nvmf_request *req), 0); DEFINE_STUB_V(spdk_bdev_io_get_nvme_fused_status, (const struct spdk_bdev_io *bdev_io, uint32_t *cdw0, int *cmp_sct, int *cmp_sc, int *wr_sct, int *wr_sc)); @@ -247,14 +247,14 @@ test_get_dif_ctx(void) bdev.md_len = 0; - ret = spdk_nvmf_bdev_ctrlr_get_dif_ctx(&bdev, &cmd, &dif_ctx); + ret = nvmf_bdev_ctrlr_get_dif_ctx(&bdev, &cmd, &dif_ctx); CU_ASSERT(ret == false); to_le64(&cmd.cdw10, 0x1234567890ABCDEF); bdev.blocklen = 520; bdev.md_len = 8; - ret = spdk_nvmf_bdev_ctrlr_get_dif_ctx(&bdev, &cmd, &dif_ctx); + ret = nvmf_bdev_ctrlr_get_dif_ctx(&bdev, &cmd, &dif_ctx); CU_ASSERT(ret == true); CU_ASSERT(dif_ctx.block_size = 520); CU_ASSERT(dif_ctx.md_size == 8); @@ -334,7 +334,7 @@ test_spdk_nvmf_bdev_ctrlr_compare_and_write_cmd(void) write_cmd.cdw12 = 1; /* NLB: CDW12 bits 15:00, 0's based */ write_req.length = (write_cmd.cdw12 + 1) * bdev.blocklen; - rc = spdk_nvmf_bdev_ctrlr_compare_and_write_cmd(&bdev, desc, &ch, &cmp_req, &write_req); + rc = nvmf_bdev_ctrlr_compare_and_write_cmd(&bdev, desc, &ch, &cmp_req, &write_req); CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_ASYNCHRONOUS); CU_ASSERT(cmp_rsp.nvme_cpl.status.sct == 0); @@ -350,7 +350,7 @@ test_spdk_nvmf_bdev_ctrlr_compare_and_write_cmd(void) write_cmd.cdw12 = 1; /* NLB: CDW12 bits 15:00, 0's based */ write_req.length = (write_cmd.cdw12 + 1) * bdev.blocklen; - rc = spdk_nvmf_bdev_ctrlr_compare_and_write_cmd(&bdev, desc, &ch, &cmp_req, &write_req); + rc = nvmf_bdev_ctrlr_compare_and_write_cmd(&bdev, desc, &ch, &cmp_req, &write_req); CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); CU_ASSERT(cmp_rsp.nvme_cpl.status.sct == 0); @@ -366,7 +366,7 @@ test_spdk_nvmf_bdev_ctrlr_compare_and_write_cmd(void) write_cmd.cdw12 = 100; /* NLB: CDW12 bits 15:00, 0's based */ write_req.length = (write_cmd.cdw12 + 1) * bdev.blocklen; - rc = spdk_nvmf_bdev_ctrlr_compare_and_write_cmd(&bdev, desc, &ch, &cmp_req, &write_req); + rc = nvmf_bdev_ctrlr_compare_and_write_cmd(&bdev, desc, &ch, &cmp_req, &write_req); CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); CU_ASSERT(cmp_rsp.nvme_cpl.status.sct == 0); @@ -382,7 +382,7 @@ test_spdk_nvmf_bdev_ctrlr_compare_and_write_cmd(void) write_cmd.cdw12 = 1; /* NLB: CDW12 bits 15:00, 0's based */ write_req.length = (write_cmd.cdw12 + 1) * bdev.blocklen - 1; - rc = spdk_nvmf_bdev_ctrlr_compare_and_write_cmd(&bdev, desc, &ch, &cmp_req, &write_req); + rc = nvmf_bdev_ctrlr_compare_and_write_cmd(&bdev, desc, &ch, &cmp_req, &write_req); CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE); CU_ASSERT(cmp_rsp.nvme_cpl.status.sct == 0); diff --git a/test/unit/lib/nvmf/ctrlr_discovery.c/ctrlr_discovery_ut.c b/test/unit/lib/nvmf/ctrlr_discovery.c/ctrlr_discovery_ut.c index 4891d5511..c61686895 100644 --- a/test/unit/lib/nvmf/ctrlr_discovery.c/ctrlr_discovery_ut.c +++ b/test/unit/lib/nvmf/ctrlr_discovery.c/ctrlr_discovery_ut.c @@ -87,8 +87,8 @@ spdk_nvmf_transport_listen(struct spdk_nvmf_transport *transport, static struct spdk_nvmf_listener g_listener = {}; struct spdk_nvmf_listener * -spdk_nvmf_transport_find_listener(struct spdk_nvmf_transport *transport, - const struct spdk_nvme_transport_id *trid) +nvmf_transport_find_listener(struct spdk_nvmf_transport *transport, + const struct spdk_nvme_transport_id *trid) { return &g_listener; } @@ -155,48 +155,48 @@ spdk_nvme_transport_id_compare(const struct spdk_nvme_transport_id *trid1, } void -spdk_nvmf_ctrlr_ns_changed(struct spdk_nvmf_ctrlr *ctrlr, uint32_t nsid) +nvmf_ctrlr_ns_changed(struct spdk_nvmf_ctrlr *ctrlr, uint32_t nsid) { } void -spdk_nvmf_ctrlr_destruct(struct spdk_nvmf_ctrlr *ctrlr) +nvmf_ctrlr_destruct(struct spdk_nvmf_ctrlr *ctrlr) { } int -spdk_nvmf_poll_group_update_subsystem(struct spdk_nvmf_poll_group *group, - struct spdk_nvmf_subsystem *subsystem) +nvmf_poll_group_update_subsystem(struct spdk_nvmf_poll_group *group, + struct spdk_nvmf_subsystem *subsystem) { return 0; } int -spdk_nvmf_poll_group_add_subsystem(struct spdk_nvmf_poll_group *group, - struct spdk_nvmf_subsystem *subsystem, - spdk_nvmf_poll_group_mod_done cb_fn, void *cb_arg) +nvmf_poll_group_add_subsystem(struct spdk_nvmf_poll_group *group, + struct spdk_nvmf_subsystem *subsystem, + spdk_nvmf_poll_group_mod_done cb_fn, void *cb_arg) { return 0; } void -spdk_nvmf_poll_group_remove_subsystem(struct spdk_nvmf_poll_group *group, - struct spdk_nvmf_subsystem *subsystem, - spdk_nvmf_poll_group_mod_done cb_fn, void *cb_arg) +nvmf_poll_group_remove_subsystem(struct spdk_nvmf_poll_group *group, + struct spdk_nvmf_subsystem *subsystem, + spdk_nvmf_poll_group_mod_done cb_fn, void *cb_arg) { } void -spdk_nvmf_poll_group_pause_subsystem(struct spdk_nvmf_poll_group *group, - struct spdk_nvmf_subsystem *subsystem, - spdk_nvmf_poll_group_mod_done cb_fn, void *cb_arg) +nvmf_poll_group_pause_subsystem(struct spdk_nvmf_poll_group *group, + struct spdk_nvmf_subsystem *subsystem, + spdk_nvmf_poll_group_mod_done cb_fn, void *cb_arg) { } void -spdk_nvmf_poll_group_resume_subsystem(struct spdk_nvmf_poll_group *group, - struct spdk_nvmf_subsystem *subsystem, - spdk_nvmf_poll_group_mod_done cb_fn, void *cb_arg) +nvmf_poll_group_resume_subsystem(struct spdk_nvmf_poll_group *group, + struct spdk_nvmf_subsystem *subsystem, + spdk_nvmf_poll_group_mod_done cb_fn, void *cb_arg) { } @@ -240,22 +240,22 @@ test_discovery_log(void) /* Get only genctr (first field in the header) */ memset(buffer, 0xCC, sizeof(buffer)); disc_log = (struct spdk_nvmf_discovery_log_page *)buffer; - spdk_nvmf_get_discovery_log_page(&tgt, "nqn.2016-06.io.spdk:host1", &iov, 1, 0, - sizeof(disc_log->genctr)); + nvmf_get_discovery_log_page(&tgt, "nqn.2016-06.io.spdk:host1", &iov, 1, 0, + sizeof(disc_log->genctr)); CU_ASSERT(disc_log->genctr == 2); /* one added subsystem and listener */ /* Get only the header, no entries */ memset(buffer, 0xCC, sizeof(buffer)); disc_log = (struct spdk_nvmf_discovery_log_page *)buffer; - spdk_nvmf_get_discovery_log_page(&tgt, "nqn.2016-06.io.spdk:host1", &iov, 1, 0, sizeof(*disc_log)); + nvmf_get_discovery_log_page(&tgt, "nqn.2016-06.io.spdk:host1", &iov, 1, 0, sizeof(*disc_log)); CU_ASSERT(disc_log->genctr == 2); CU_ASSERT(disc_log->numrec == 1); /* Offset 0, exact size match */ memset(buffer, 0xCC, sizeof(buffer)); disc_log = (struct spdk_nvmf_discovery_log_page *)buffer; - spdk_nvmf_get_discovery_log_page(&tgt, "nqn.2016-06.io.spdk:host1", &iov, 1, 0, - sizeof(*disc_log) + sizeof(disc_log->entries[0])); + nvmf_get_discovery_log_page(&tgt, "nqn.2016-06.io.spdk:host1", &iov, 1, 0, + sizeof(*disc_log) + sizeof(disc_log->entries[0])); CU_ASSERT(disc_log->genctr != 0); CU_ASSERT(disc_log->numrec == 1); CU_ASSERT(disc_log->entries[0].trtype == 42); @@ -263,7 +263,7 @@ test_discovery_log(void) /* Offset 0, oversize buffer */ memset(buffer, 0xCC, sizeof(buffer)); disc_log = (struct spdk_nvmf_discovery_log_page *)buffer; - spdk_nvmf_get_discovery_log_page(&tgt, "nqn.2016-06.io.spdk:host1", &iov, 1, 0, sizeof(buffer)); + nvmf_get_discovery_log_page(&tgt, "nqn.2016-06.io.spdk:host1", &iov, 1, 0, sizeof(buffer)); CU_ASSERT(disc_log->genctr != 0); CU_ASSERT(disc_log->numrec == 1); CU_ASSERT(disc_log->entries[0].trtype == 42); @@ -273,10 +273,10 @@ test_discovery_log(void) /* Get just the first entry, no header */ memset(buffer, 0xCC, sizeof(buffer)); entry = (struct spdk_nvmf_discovery_log_page_entry *)buffer; - spdk_nvmf_get_discovery_log_page(&tgt, "nqn.2016-06.io.spdk:host1", &iov, - 1, - offsetof(struct spdk_nvmf_discovery_log_page, entries[0]), - sizeof(*entry)); + nvmf_get_discovery_log_page(&tgt, "nqn.2016-06.io.spdk:host1", &iov, + 1, + offsetof(struct spdk_nvmf_discovery_log_page, entries[0]), + sizeof(*entry)); CU_ASSERT(entry->trtype == 42); subsystem->state = SPDK_NVMF_SUBSYSTEM_INACTIVE; spdk_nvmf_subsystem_destroy(subsystem); diff --git a/test/unit/lib/nvmf/fc.c/fc_ut.c b/test/unit/lib/nvmf/fc.c/fc_ut.c index 5f99e6411..011b74ffa 100644 --- a/test/unit/lib/nvmf/fc.c/fc_ut.c +++ b/test/unit/lib/nvmf/fc.c/fc_ut.c @@ -106,12 +106,12 @@ DEFINE_STUB_V(spdk_trace_register_description, const char *arg1_name)); DEFINE_STUB_V(spdk_trace_add_register_fn, (struct spdk_trace_register_fn *reg_fn)); DEFINE_STUB(spdk_bdev_get_name, const char *, (const struct spdk_bdev *bdev), "fc_ut_test"); -DEFINE_STUB_V(spdk_nvmf_ctrlr_destruct, (struct spdk_nvmf_ctrlr *ctrlr)); -DEFINE_STUB_V(spdk_nvmf_qpair_free_aer, (struct spdk_nvmf_qpair *qpair)); +DEFINE_STUB_V(nvmf_ctrlr_destruct, (struct spdk_nvmf_ctrlr *ctrlr)); +DEFINE_STUB_V(nvmf_qpair_free_aer, (struct spdk_nvmf_qpair *qpair)); DEFINE_STUB(spdk_bdev_get_io_channel, struct spdk_io_channel *, (struct spdk_bdev_desc *desc), NULL); DEFINE_STUB_V(spdk_nvmf_request_exec, (struct spdk_nvmf_request *req)); -DEFINE_STUB_V(spdk_nvmf_ctrlr_ns_changed, (struct spdk_nvmf_ctrlr *ctrlr, uint32_t nsid)); +DEFINE_STUB_V(nvmf_ctrlr_ns_changed, (struct spdk_nvmf_ctrlr *ctrlr, uint32_t nsid)); DEFINE_STUB(spdk_bdev_open, int, (struct spdk_bdev *bdev, bool write, spdk_bdev_remove_cb_t remove_cb, void *remove_ctx, struct spdk_bdev_desc **desc), 0); @@ -123,7 +123,7 @@ DEFINE_STUB_V(spdk_bdev_module_release_bdev, (struct spdk_bdev *bdev)); DEFINE_STUB(spdk_bdev_get_block_size, uint32_t, (const struct spdk_bdev *bdev), 512); DEFINE_STUB(spdk_bdev_get_num_blocks, uint64_t, (const struct spdk_bdev *bdev), 1024); -DEFINE_STUB(spdk_nvmf_ctrlr_async_event_ns_notice, int, (struct spdk_nvmf_ctrlr *ctrlr), 0); +DEFINE_STUB(nvmf_ctrlr_async_event_ns_notice, int, (struct spdk_nvmf_ctrlr *ctrlr), 0); DEFINE_STUB_V(spdk_nvme_trid_populate_transport, (struct spdk_nvme_transport_id *trid, enum spdk_nvme_transport_type trtype)); DEFINE_STUB_V(spdk_nvmf_ctrlr_data_init, (struct spdk_nvmf_transport_opts *opts, diff --git a/test/unit/lib/nvmf/rdma.c/rdma_ut.c b/test/unit/lib/nvmf/rdma.c/rdma_ut.c index 3cddc16d1..d479a7e84 100644 --- a/test/unit/lib/nvmf/rdma.c/rdma_ut.c +++ b/test/unit/lib/nvmf/rdma.c/rdma_ut.c @@ -78,7 +78,7 @@ DEFINE_STUB_V(spdk_nvmf_ctrlr_data_init, (struct spdk_nvmf_transport_opts *opts, DEFINE_STUB_V(spdk_nvmf_request_exec, (struct spdk_nvmf_request *req)); DEFINE_STUB(spdk_nvme_transport_id_compare, int, (const struct spdk_nvme_transport_id *trid1, const struct spdk_nvme_transport_id *trid2), 0); -DEFINE_STUB_V(spdk_nvmf_ctrlr_abort_aer, (struct spdk_nvmf_ctrlr *ctrlr)); +DEFINE_STUB_V(nvmf_ctrlr_abort_aer, (struct spdk_nvmf_ctrlr *ctrlr)); DEFINE_STUB(spdk_nvmf_request_get_dif_ctx, bool, (struct spdk_nvmf_request *req, struct spdk_dif_ctx *dif_ctx), false); DEFINE_STUB_V(spdk_nvme_trid_populate_transport, (struct spdk_nvme_transport_id *trid, diff --git a/test/unit/lib/nvmf/subsystem.c/subsystem_ut.c b/test/unit/lib/nvmf/subsystem.c/subsystem_ut.c index f58551427..2a9ebff5c 100644 --- a/test/unit/lib/nvmf/subsystem.c/subsystem_ut.c +++ b/test/unit/lib/nvmf/subsystem.c/subsystem_ut.c @@ -109,38 +109,38 @@ spdk_nvmf_tgt_get_transport(struct spdk_nvmf_tgt *tgt, const char *transport_nam } int -spdk_nvmf_poll_group_update_subsystem(struct spdk_nvmf_poll_group *group, - struct spdk_nvmf_subsystem *subsystem) +nvmf_poll_group_update_subsystem(struct spdk_nvmf_poll_group *group, + struct spdk_nvmf_subsystem *subsystem) { return 0; } int -spdk_nvmf_poll_group_add_subsystem(struct spdk_nvmf_poll_group *group, - struct spdk_nvmf_subsystem *subsystem, - spdk_nvmf_poll_group_mod_done cb_fn, void *cb_arg) +nvmf_poll_group_add_subsystem(struct spdk_nvmf_poll_group *group, + struct spdk_nvmf_subsystem *subsystem, + spdk_nvmf_poll_group_mod_done cb_fn, void *cb_arg) { return 0; } void -spdk_nvmf_poll_group_remove_subsystem(struct spdk_nvmf_poll_group *group, - struct spdk_nvmf_subsystem *subsystem, - spdk_nvmf_poll_group_mod_done cb_fn, void *cb_arg) +nvmf_poll_group_remove_subsystem(struct spdk_nvmf_poll_group *group, + struct spdk_nvmf_subsystem *subsystem, + spdk_nvmf_poll_group_mod_done cb_fn, void *cb_arg) { } void -spdk_nvmf_poll_group_pause_subsystem(struct spdk_nvmf_poll_group *group, - struct spdk_nvmf_subsystem *subsystem, - spdk_nvmf_poll_group_mod_done cb_fn, void *cb_arg) +nvmf_poll_group_pause_subsystem(struct spdk_nvmf_poll_group *group, + struct spdk_nvmf_subsystem *subsystem, + spdk_nvmf_poll_group_mod_done cb_fn, void *cb_arg) { } void -spdk_nvmf_poll_group_resume_subsystem(struct spdk_nvmf_poll_group *group, - struct spdk_nvmf_subsystem *subsystem, - spdk_nvmf_poll_group_mod_done cb_fn, void *cb_arg) +nvmf_poll_group_resume_subsystem(struct spdk_nvmf_poll_group *group, + struct spdk_nvmf_subsystem *subsystem, + spdk_nvmf_poll_group_mod_done cb_fn, void *cb_arg) { } @@ -187,14 +187,14 @@ spdk_nvme_detach(struct spdk_nvme_ctrlr *ctrlr) } void -spdk_nvmf_ctrlr_destruct(struct spdk_nvmf_ctrlr *ctrlr) +nvmf_ctrlr_destruct(struct spdk_nvmf_ctrlr *ctrlr) { } static struct spdk_nvmf_ctrlr *g_ns_changed_ctrlr = NULL; static uint32_t g_ns_changed_nsid = 0; void -spdk_nvmf_ctrlr_ns_changed(struct spdk_nvmf_ctrlr *ctrlr, uint32_t nsid) +nvmf_ctrlr_ns_changed(struct spdk_nvmf_ctrlr *ctrlr, uint32_t nsid) { g_ns_changed_ctrlr = ctrlr; g_ns_changed_nsid = nsid; @@ -453,7 +453,7 @@ static struct spdk_bdev g_bdev; struct spdk_nvmf_subsystem_pg_ns_info g_ns_info; void -spdk_nvmf_ctrlr_async_event_reservation_notification(struct spdk_nvmf_ctrlr *ctrlr) +nvmf_ctrlr_async_event_reservation_notification(struct spdk_nvmf_ctrlr *ctrlr) { } @@ -999,9 +999,9 @@ test_reservation_release(void) } void -spdk_nvmf_ctrlr_reservation_notice_log(struct spdk_nvmf_ctrlr *ctrlr, - struct spdk_nvmf_ns *ns, - enum spdk_nvme_reservation_notification_log_page_type type) +nvmf_ctrlr_reservation_notice_log(struct spdk_nvmf_ctrlr *ctrlr, + struct spdk_nvmf_ns *ns, + enum spdk_nvme_reservation_notification_log_page_type type) { ctrlr->num_avail_log_pages++; } diff --git a/test/unit/lib/nvmf/tcp.c/tcp_ut.c b/test/unit/lib/nvmf/tcp.c/tcp_ut.c index 88e0c2dd2..4aff1f0c5 100644 --- a/test/unit/lib/nvmf/tcp.c/tcp_ut.c +++ b/test/unit/lib/nvmf/tcp.c/tcp_ut.c @@ -63,12 +63,12 @@ DEFINE_STUB(spdk_nvmf_qpair_get_listen_trid, (struct spdk_nvmf_qpair *qpair, struct spdk_nvme_transport_id *trid), 0); -DEFINE_STUB(spdk_nvmf_subsystem_add_ctrlr, +DEFINE_STUB(nvmf_subsystem_add_ctrlr, int, (struct spdk_nvmf_subsystem *subsystem, struct spdk_nvmf_ctrlr *ctrlr), 0); -DEFINE_STUB(spdk_nvmf_subsystem_get_ctrlr, +DEFINE_STUB(nvmf_subsystem_get_ctrlr, struct spdk_nvmf_ctrlr *, (struct spdk_nvmf_subsystem *subsystem, uint16_t cntlid), NULL); @@ -83,11 +83,11 @@ DEFINE_STUB(spdk_nvmf_subsystem_listener_allowed, (struct spdk_nvmf_subsystem *subsystem, const struct spdk_nvme_transport_id *trid), true); -DEFINE_STUB_V(spdk_nvmf_get_discovery_log_page, +DEFINE_STUB_V(nvmf_get_discovery_log_page, (struct spdk_nvmf_tgt *tgt, const char *hostnqn, struct iovec *iov, uint32_t iovcnt, uint64_t offset, uint32_t length)); -DEFINE_STUB_V(spdk_nvmf_subsystem_remove_ctrlr, +DEFINE_STUB_V(nvmf_subsystem_remove_ctrlr, (struct spdk_nvmf_subsystem *subsystem, struct spdk_nvmf_ctrlr *ctrlr)); DEFINE_STUB(spdk_nvmf_subsystem_get_first_ns, @@ -105,65 +105,65 @@ DEFINE_STUB(spdk_nvmf_subsystem_host_allowed, (struct spdk_nvmf_subsystem *subsystem, const char *hostnqn), true); -DEFINE_STUB(spdk_nvmf_ctrlr_dsm_supported, +DEFINE_STUB(nvmf_ctrlr_dsm_supported, bool, (struct spdk_nvmf_ctrlr *ctrlr), false); -DEFINE_STUB(spdk_nvmf_ctrlr_write_zeroes_supported, +DEFINE_STUB(nvmf_ctrlr_write_zeroes_supported, bool, (struct spdk_nvmf_ctrlr *ctrlr), false); -DEFINE_STUB(spdk_nvmf_bdev_ctrlr_read_cmd, +DEFINE_STUB(nvmf_bdev_ctrlr_read_cmd, int, (struct spdk_bdev *bdev, struct spdk_bdev_desc *desc, struct spdk_io_channel *ch, struct spdk_nvmf_request *req), 0); -DEFINE_STUB(spdk_nvmf_bdev_ctrlr_write_cmd, +DEFINE_STUB(nvmf_bdev_ctrlr_write_cmd, int, (struct spdk_bdev *bdev, struct spdk_bdev_desc *desc, struct spdk_io_channel *ch, struct spdk_nvmf_request *req), 0); -DEFINE_STUB(spdk_nvmf_bdev_ctrlr_compare_cmd, +DEFINE_STUB(nvmf_bdev_ctrlr_compare_cmd, int, (struct spdk_bdev *bdev, struct spdk_bdev_desc *desc, struct spdk_io_channel *ch, struct spdk_nvmf_request *req), 0); -DEFINE_STUB(spdk_nvmf_bdev_ctrlr_compare_and_write_cmd, +DEFINE_STUB(nvmf_bdev_ctrlr_compare_and_write_cmd, int, (struct spdk_bdev *bdev, struct spdk_bdev_desc *desc, struct spdk_io_channel *ch, struct spdk_nvmf_request *cmp_req, struct spdk_nvmf_request *write_req), 0); -DEFINE_STUB(spdk_nvmf_bdev_ctrlr_write_zeroes_cmd, +DEFINE_STUB(nvmf_bdev_ctrlr_write_zeroes_cmd, int, (struct spdk_bdev *bdev, struct spdk_bdev_desc *desc, struct spdk_io_channel *ch, struct spdk_nvmf_request *req), 0); -DEFINE_STUB(spdk_nvmf_bdev_ctrlr_flush_cmd, +DEFINE_STUB(nvmf_bdev_ctrlr_flush_cmd, int, (struct spdk_bdev *bdev, struct spdk_bdev_desc *desc, struct spdk_io_channel *ch, struct spdk_nvmf_request *req), 0); -DEFINE_STUB(spdk_nvmf_bdev_ctrlr_dsm_cmd, +DEFINE_STUB(nvmf_bdev_ctrlr_dsm_cmd, int, (struct spdk_bdev *bdev, struct spdk_bdev_desc *desc, struct spdk_io_channel *ch, struct spdk_nvmf_request *req), 0); -DEFINE_STUB(spdk_nvmf_bdev_ctrlr_nvme_passthru_io, +DEFINE_STUB(nvmf_bdev_ctrlr_nvme_passthru_io, int, (struct spdk_bdev *bdev, struct spdk_bdev_desc *desc, struct spdk_io_channel *ch, struct spdk_nvmf_request *req), 0); -DEFINE_STUB(spdk_nvmf_bdev_ctrlr_get_dif_ctx, +DEFINE_STUB(nvmf_bdev_ctrlr_get_dif_ctx, bool, (struct spdk_bdev *bdev, struct spdk_nvme_cmd *cmd, struct spdk_dif_ctx *dif_ctx), false); @@ -192,7 +192,7 @@ DEFINE_STUB(spdk_sock_set_priority, (struct spdk_sock *sock, int priority), 0); -DEFINE_STUB_V(spdk_nvmf_ns_reservation_request, (void *ctx)); +DEFINE_STUB_V(nvmf_ns_reservation_request, (void *ctx)); DEFINE_STUB_V(spdk_nvme_trid_populate_transport, (struct spdk_nvme_transport_id *trid, enum spdk_nvme_transport_type trtype)); @@ -292,8 +292,8 @@ spdk_nvmf_request_get_buffers(struct spdk_nvmf_request *req, void -spdk_nvmf_bdev_ctrlr_identify_ns(struct spdk_nvmf_ns *ns, struct spdk_nvme_ns_data *nsdata, - bool dif_insert_or_strip) +nvmf_bdev_ctrlr_identify_ns(struct spdk_nvmf_ns *ns, struct spdk_nvme_ns_data *nsdata, + bool dif_insert_or_strip) { uint64_t num_blocks;