ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

env: Remove unhelpful const in spdk_mempool_put_bulk

Browse Source 
This const makes the array passed in immutable, but that
isn't helpful or interesting since it just contains
invalid pointer addresses. It may also make sense in the
future to NULL out the addresses in the array in a debug
build. So drop the const.

Change-Id: I921551c7cb1dbf6c765fb301c31906b8b93b7f16
Signed-off-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-on: https://review.gerrithub.io/417362
Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
This commit is contained in:
Ben Walker 2018-06-28 14:03:43 -07:00 committed by Jim Harris
parent ef8dfe1111
commit 9bac3426ae
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/spdk/env.h
View File

@ -370,7 +370,7 @@ void spdk_mempool_put(struct spdk_mempool *mp, void *ele);
* \param ele_arr Array of the elements to put.
* \param count Count of elements to put.
*/
void spdk_mempool_put_bulk(struct spdk_mempool *mp, void *const *ele_arr, size_t count);
void spdk_mempool_put_bulk(struct spdk_mempool *mp, void **ele_arr, size_t count);
/**
* Get the number of entries in the memory pool.

2
lib/env_dpdk/env.c
View File

@ -260,7 +260,7 @@ spdk_mempool_put(struct spdk_mempool *mp, void *ele)
}
void
spdk_mempool_put_bulk(struct spdk_mempool *mp, void *const *ele_arr, size_t count)
spdk_mempool_put_bulk(struct spdk_mempool *mp, void **ele_arr, size_t count)
{
rte_mempool_put_bulk((struct rte_mempool *)mp, ele_arr, count);
}