From 9a7c72e819889577e7554765eae1b2329683dc3c Mon Sep 17 00:00:00 2001 From: Pawel Kaminski Date: Mon, 9 Sep 2019 11:01:46 -0400 Subject: [PATCH] test: Shellcheck - apply rule SC2192. SC2192: This array element has no value. Remove spaces after = or use "" for empty string. Change-Id: I5228df2ac292786a3a62aa06ffb6cd31b7d3b6c4 Signed-off-by: Pawel Kaminski Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/467861 Reviewed-by: Karol Latecki Reviewed-by: Paul Luse Reviewed-by: Jim Harris Reviewed-by: Ben Walker Tested-by: SPDK CI Jenkins --- scripts/check_format.sh | 2 +- test/json_config/json_config.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/check_format.sh b/scripts/check_format.sh index f4df36a52..940e6fbab 100755 --- a/scripts/check_format.sh +++ b/scripts/check_format.sh @@ -246,7 +246,7 @@ SC2027,SC2030,SC2031,SC2034,SC2035,SC2039,SC2043,SC2044,SC2045,SC2046,SC2048,\ SC2059,SC2068,SC2074,SC2086,SC2088,SC2089,SC2090,SC2091,SC2094,\ SC2097,SC2098,SC2103,SC2115,SC2116,SC2119,SC2120,SC2121,SC2124,SC2126,SC2128,\ SC2129,SC2140,SC2142,SC2143,SC2145,SC2146,SC2148,SC2152,SC2153,SC2154,SC2155,\ -SC2162,SC2164,SC2165,SC2166,SC2167,SC2174,SC2178,SC2181,SC2191,SC2192,SC2195,\ +SC2162,SC2164,SC2165,SC2166,SC2167,SC2174,SC2178,SC2181,SC2191,SC2195,\ SC2206,SC2207,SC2214,SC2223,SC2230,SC2231,SC2235" # SPDK fails some error checks which have been deprecated in later versions of shellcheck. # We will not try to fix these error checks, but instead just leave the error types here diff --git a/test/json_config/json_config.sh b/test/json_config/json_config.sh index c481a87b1..268772960 100755 --- a/test/json_config/json_config.sh +++ b/test/json_config/json_config.sh @@ -25,7 +25,7 @@ if (( SPDK_TEST_BLOCKDEV + \ exit 0 fi -declare -A app_pid=([target]= [initiator]=) +declare -A app_pid=([target]="" [initiator]="") declare -A app_socket=([target]='/var/tmp/spdk_tgt.sock' [initiator]='/var/tmp/spdk_initiator.sock') declare -A app_params=([target]='-m 0x1 -s 1024' [initiator]='-m 0x2 -g -u -s 1024') declare -A configs_path=([target]="$rootdir/spdk_tgt_config.json" [initiator]="$rootdir/spdk_initiator_config.json")