From 9a25fc12bb7585c9cbcc8f642e38ecc879313a32 Mon Sep 17 00:00:00 2001 From: Tomasz Zawadzki Date: Thu, 7 Nov 2019 04:06:41 -0500 Subject: [PATCH] test: add SPDK_BUILD_PACKAGE flag Until now the autopackage.sh execution was tied to RUN_NIGHTLY flag. This was useful to check for errors on all jobs/systems during a nightly test. By their nature nightly does not run on per-patch basis. This allows for issues to slip in and be noticed only by the nightly job after merge occurred. Adding separate SPDK_BUILD_PACKAGE flag, allows to explicitly test packaging on single job on per-patch. RUN_NIGHTLY was kept as trigger for autopackage.sh to still test it on all systems by default. Change-Id: I29925fd6256b218e24c24ebcc4974c65a9bd986c Signed-off-by: Tomasz Zawadzki Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/473519 Tested-by: SPDK CI Jenkins Reviewed-by: Ben Walker Reviewed-by: Jim Harris Reviewed-by: Karol Latecki --- autopackage.sh | 2 +- test/common/autotest_common.sh | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/autopackage.sh b/autopackage.sh index eff16daaa..5428cb344 100755 --- a/autopackage.sh +++ b/autopackage.sh @@ -28,7 +28,7 @@ if [ $(git status --porcelain --ignore-submodules | wc -l) -ne 0 ]; then fi timing_exit porcelain_check -if [ $RUN_NIGHTLY -eq 0 ]; then +if [[ $SPDK_BUILD_PACKAGE -eq 0 && $RUN_NIGHTLY -eq 0 ]]; then timing_finish exit 0 fi diff --git a/test/common/autotest_common.sh b/test/common/autotest_common.sh index e3afba6af..4a12d28d6 100644 --- a/test/common/autotest_common.sh +++ b/test/common/autotest_common.sh @@ -28,6 +28,7 @@ export RUN_NIGHTLY_FAILING # Set defaults for missing test config options : ${SPDK_BUILD_DOC=0}; export SPDK_BUILD_DOC +: ${SPDK_BUILD_PACKAGE=0}; export SPDK_BUILD_PACKAGE : ${SPDK_BUILD_SHARED_OBJECT=0}; export SPDK_BUILD_SHARED_OBJECT : ${SPDK_RUN_CHECK_FORMAT=0}; export SPDK_RUN_CHECK_FORMAT : ${SPDK_RUN_SCANBUILD=0}; export SPDK_RUN_SCANBUILD