From 98a99d33fff09d210fb987f12ae4f9a9b03d9abb Mon Sep 17 00:00:00 2001 From: Sergei Trofimovich Date: Tue, 23 Nov 2021 22:48:22 +0000 Subject: [PATCH] spdk_top: fix format warning around `thread_info->core_num` On `ncurses-6.3` format attributes now detect argument mismatch: spdk_top.c:2218:60: warning: format '%lu' expects argument of type 'long unsigned int', but argument 5 has type 'int' [-Wformat=] 2218 | mvwprintw(thread_win, 3, THREAD_WIN_FIRST_COL + 6, "%" PRIu64, | ^~~ 2219 | thread_info->core_num); | ~~~~~~~~~~~~~~~~~~~~~ | int Use '%d" for `thread_info->core_num` (declared as `int`). Signed-off-by: Sergei Trofimovich Change-Id: I99cd4ff41a26917b67199ea8cc1fbf281ce4dd20 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/10375 Community-CI: Broadcom CI Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins Reviewed-by: Tomasz Zawadzki Reviewed-by: John Kariuki Reviewed-by: Ben Walker Reviewed-by: Jim Harris --- app/spdk_top/spdk_top.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/spdk_top/spdk_top.c b/app/spdk_top/spdk_top.c index 41a8ad2a9..8661b93ed 100644 --- a/app/spdk_top/spdk_top.c +++ b/app/spdk_top/spdk_top.c @@ -2215,7 +2215,7 @@ display_thread(struct rpc_thread_info *thread_info) print_left(thread_win, 3, THREAD_WIN_FIRST_COL, THREAD_WIN_WIDTH, "Core: Idle [us]: Busy [us]:", COLOR_PAIR(5)); - mvwprintw(thread_win, 3, THREAD_WIN_FIRST_COL + 6, "%" PRIu64, + mvwprintw(thread_win, 3, THREAD_WIN_FIRST_COL + 6, "%d", thread_info->core_num); if (g_interval_data) {