From 988af676da8b2f85cc538e205df0543b21a8177c Mon Sep 17 00:00:00 2001 From: Ziye Yang Date: Sun, 2 May 2021 20:46:13 +0800 Subject: [PATCH] nvmf/tcp: Remove the unnecessary qpair setting. It is already set by nvmf_tcp_req_pdu_init when we get the pdu. So we do not set it again. Change-Id: I034bbc46e600afd802457c0b152e303f16bafba3 Signed-off-by: Ziye Yang Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/7714 Community-CI: Broadcom CI Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins Reviewed-by: Aleksey Marchuk Reviewed-by: Shuhei Matsumoto --- lib/nvmf/tcp.c | 1 - test/unit/lib/nvmf/tcp.c/tcp_ut.c | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/nvmf/tcp.c b/lib/nvmf/tcp.c index b16ed22a4..57596cc11 100644 --- a/lib/nvmf/tcp.c +++ b/lib/nvmf/tcp.c @@ -901,7 +901,6 @@ nvmf_tcp_qpair_write_pdu(struct spdk_nvmf_tcp_qpair *tqpair, hlen = pdu->hdr.common.hlen; pdu->cb_fn = cb_fn; pdu->cb_arg = cb_arg; - pdu->qpair = tqpair; pdu->iov[0].iov_base = &pdu->hdr.raw; pdu->iov[0].iov_len = hlen; diff --git a/test/unit/lib/nvmf/tcp.c/tcp_ut.c b/test/unit/lib/nvmf/tcp.c/tcp_ut.c index b96f9e854..f6a06ad3c 100644 --- a/test/unit/lib/nvmf/tcp.c/tcp_ut.c +++ b/test/unit/lib/nvmf/tcp.c/tcp_ut.c @@ -559,6 +559,7 @@ test_nvmf_tcp_send_c2h_data(void) tcp_req.pdu = &pdu; tcp_req.req.length = 300; + tcp_req.req.qpair = &tqpair.qpair; tqpair.qpair.transport = &ttransport.transport;