From 97e345002bb676282a1dda07e48f170478505848 Mon Sep 17 00:00:00 2001 From: yidong0635 Date: Wed, 8 Apr 2020 08:01:42 -0400 Subject: [PATCH] test/nvme_poll_group: Fix uninitialized value in unittest. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Compiling with warning: nvme_poll_group_ut.c: In function ‘test_spdk_nvme_poll_group_add_remove’: nvme_poll_group_ut.c:268:8: warning: ‘tgroup’ may be used uninitialized in this function [-Wmaybe-uninitialized] qpair = STAILQ_FIRST(&tgroup->active_qpairs); tgroup may can't be initialized as: if (tmp_tgroup->transport == &t1) { tgroup = tmp_tgroup; } else { CU_ASSERT(STAILQ_EMPTY(&tmp_tgroup->active_qpairs)); } Signed-off-by: yidong0635 Change-Id: Id915e651f73ca3814a7e8d3f95c8793b8b880990 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1738 Tested-by: SPDK CI Jenkins Reviewed-by: Shuhei Matsumoto Reviewed-by: Darek Stojaczyk Reviewed-by: Aleksey Marchuk Reviewed-by: Paul Luse --- test/unit/lib/nvme/nvme_poll_group.c/nvme_poll_group_ut.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/test/unit/lib/nvme/nvme_poll_group.c/nvme_poll_group_ut.c b/test/unit/lib/nvme/nvme_poll_group.c/nvme_poll_group_ut.c index 3c7ee36b4..ff68457f8 100644 --- a/test/unit/lib/nvme/nvme_poll_group.c/nvme_poll_group_ut.c +++ b/test/unit/lib/nvme/nvme_poll_group.c/nvme_poll_group_ut.c @@ -229,8 +229,9 @@ static void test_spdk_nvme_poll_group_add_remove(void) { struct spdk_nvme_poll_group *group; - struct spdk_nvme_transport_poll_group *tgroup, *tmp_tgroup, *tgroup_1 = NULL, *tgroup_2 = NULL, - *tgroup_4 = NULL; + struct spdk_nvme_transport_poll_group *tgroup = NULL, *tmp_tgroup, *tgroup_1 = NULL, + *tgroup_2 = NULL, + *tgroup_4 = NULL; struct spdk_nvme_qpair *qpair; struct spdk_nvme_qpair qpair1_1 = {0}; struct spdk_nvme_qpair qpair1_2 = {0};