From 94d6e332bcfa294a5582dbbf7e62133f07f24f68 Mon Sep 17 00:00:00 2001 From: Shuhei Matsumoto Date: Thu, 15 Oct 2020 09:09:27 +0900 Subject: [PATCH] ut/nvmf_ctrlr_discovery: Remove spdk_bdev_open() stub because it is not used Remove the stub for spdk_bdev_open() and use the DEFINE_STUB_V macro to the stub for spdk_bdev_close(). Signed-off-by: Shuhei Matsumoto Change-Id: I84df06b4b73e1f5af5c2c8854f1613e8a413533b Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/4729 Tested-by: SPDK CI Jenkins Reviewed-by: Jim Harris Reviewed-by: Tomasz Zawadzki Reviewed-by: Aleksey Marchuk --- .../lib/nvmf/ctrlr_discovery.c/ctrlr_discovery_ut.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/test/unit/lib/nvmf/ctrlr_discovery.c/ctrlr_discovery_ut.c b/test/unit/lib/nvmf/ctrlr_discovery.c/ctrlr_discovery_ut.c index 108f0e451..652e6baec 100644 --- a/test/unit/lib/nvmf/ctrlr_discovery.c/ctrlr_discovery_ut.c +++ b/test/unit/lib/nvmf/ctrlr_discovery.c/ctrlr_discovery_ut.c @@ -53,17 +53,7 @@ DEFINE_STUB(spdk_nvmf_transport_stop_listen, (struct spdk_nvmf_transport *transport, const struct spdk_nvme_transport_id *trid), 0); -int -spdk_bdev_open(struct spdk_bdev *bdev, bool write, spdk_bdev_remove_cb_t remove_cb, - void *remove_ctx, struct spdk_bdev_desc **desc) -{ - return 0; -} - -void -spdk_bdev_close(struct spdk_bdev_desc *desc) -{ -} +DEFINE_STUB_V(spdk_bdev_close, (struct spdk_bdev_desc *desc)); const char * spdk_bdev_get_name(const struct spdk_bdev *bdev)