From 933868afe588430eb7b7ede8ec33d44ac4bbd2a3 Mon Sep 17 00:00:00 2001
From: Jim Harris <james.r.harris@intel.com>
Date: Mon, 8 Feb 2021 21:09:08 +0000
Subject: [PATCH] spdk_top: fix -h option handling

-H is not specified to getopt, so there's no reason
to have a case statement for it.

We should also return 0 when -h is specified. spdk_top
-h should not return error status to the shell since
this is valid usage.

Signed-off-by: Jim Harris <james.r.harris@intel.com>
Change-Id: Ifa24c93661648c61de6925bea4b4071cd53013d4
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/6327
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Paul Luse <paul.e.luse@intel.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: <dongx.yi@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Community-CI: Mellanox Build Bot
---
 app/spdk_top/spdk_top.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/app/spdk_top/spdk_top.c b/app/spdk_top/spdk_top.c
index 157d8f7a6..f0ffb32a1 100644
--- a/app/spdk_top/spdk_top.c
+++ b/app/spdk_top/spdk_top.c
@@ -2468,10 +2468,9 @@ int main(int argc, char **argv)
 		case 'r':
 			socket = optarg;
 			break;
-		case 'H':
 		default:
 			usage(argv[0]);
-			return 1;
+			return op == 'h' ? 0 : 1;
 		}
 	}