From 92a390347897cc00ff844a0bb64ae498b8ad6a2c Mon Sep 17 00:00:00 2001 From: yidong0635 Date: Fri, 22 Jul 2022 16:57:01 +0800 Subject: [PATCH] subsystem: Gather list changed conditions. Just remove the duplicated Code and make the Conditions for g_subsystems list to subsystems_list together. Signed-off-by: yidong0635 Change-Id: I011b550b83d32580bfd25130dab9e44bcbdc1daf Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/13753 Reviewed-by: Changpeng Liu Reviewed-by: Jim Harris Tested-by: SPDK CI Jenkins --- lib/init/subsystem.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/lib/init/subsystem.c b/lib/init/subsystem.c index f850e6d7a..abf31b3a1 100644 --- a/lib/init/subsystem.c +++ b/lib/init/subsystem.c @@ -111,14 +111,9 @@ subsystem_sort(void) } } - if (depends_on == false) { + if (!depends_on || depends_on_sorted) { TAILQ_REMOVE(&g_subsystems, subsystem, tailq); TAILQ_INSERT_TAIL(&subsystems_list, subsystem, tailq); - } else { - if (depends_on_sorted == true) { - TAILQ_REMOVE(&g_subsystems, subsystem, tailq); - TAILQ_INSERT_TAIL(&subsystems_list, subsystem, tailq); - } } } }