From 928db416265e645330f8536359676787f298ded2 Mon Sep 17 00:00:00 2001 From: yidong0635 Date: Thu, 17 Jun 2021 09:17:20 +0800 Subject: [PATCH] rpc: Fix raid strip size method not consistent. Fix json config file using strip_size error, and The strip_size parameter was changed to strip_size_kb in `bdev_raid_create` rpc function in order to make it more meaningful to users. Unify the coding style in rpc help file. using --strip-size-kb --raid-level ... instead of --strip-size_kb. Signed-off-by: yidong0635 Change-Id: I341af1034c7ea6716ff839bb524ee733c9e0cd34 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/8401 Tested-by: SPDK CI Jenkins Community-CI: Mellanox Build Bot Reviewed-by: Changpeng Liu Reviewed-by: Ziye Yang Reviewed-by: Shuhei Matsumoto Reviewed-by: Jim Harris --- CHANGELOG.md | 3 +++ doc/jsonrpc.md | 2 +- scripts/rpc.py | 2 +- 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index dff701b84..e95e360ff 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -72,6 +72,9 @@ to create a rbd bdev with an already registered Rados Cluster Object. New RPC `bdev_rbd_get_clusters_info` was added, it allows to get the info of the registered Rados Cluster names. +Revised a parameter `--stripe-size_kb` to `--stripe-size-kb` of `bdev_raid_create` method +provided in `scripts/rpc.py` for consistency. + ### bdev Removed ZCOPY emulation: The bdev module can be checked to see if it supports ZCOPY diff --git a/doc/jsonrpc.md b/doc/jsonrpc.md index adef650cf..021a45658 100644 --- a/doc/jsonrpc.md +++ b/doc/jsonrpc.md @@ -7866,7 +7866,7 @@ Example request: "Malloc2", "Malloc3" ], - "strip_size": 4096 + "strip_size_kb": 4 } } ~~~ diff --git a/scripts/rpc.py b/scripts/rpc.py index 706d65710..438de7c2a 100755 --- a/scripts/rpc.py +++ b/scripts/rpc.py @@ -1724,7 +1724,7 @@ Format: 'user:u1 secret:s1 muser:mu1 msecret:ms1,user:u2 secret:s2 muser:mu2 mse p = subparsers.add_parser('bdev_raid_create', aliases=['construct_raid_bdev'], help='Create new raid bdev') p.add_argument('-n', '--name', help='raid bdev name', required=True) - p.add_argument('-z', '--strip-size_kb', help='strip size in KB', type=int) + p.add_argument('-z', '--strip-size-kb', help='strip size in KB', type=int) p.add_argument('-r', '--raid-level', help='raid level, only raid level 0 is supported', required=True) p.add_argument('-b', '--base-bdevs', help='base bdevs name, whitespace separated list in quotes', required=True) p.set_defaults(func=bdev_raid_create)