From 912ad8e3aa328bd909e5c9c82851c787c3a5a884 Mon Sep 17 00:00:00 2001 From: Changpeng Liu Date: Tue, 17 Dec 2019 23:03:05 -0500 Subject: [PATCH] nvme: use macro defintion instead of magic number for queue priority setting Change-Id: I7f37478a459db1652a12262a29ca95d88ede1045 Signed-off-by: Changpeng Liu Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/478261 Community-CI: Broadcom SPDK FC-NVMe CI Tested-by: SPDK CI Jenkins Reviewed-by: Jim Harris Reviewed-by: Shuhei Matsumoto --- lib/nvme/nvme_ctrlr.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/nvme/nvme_ctrlr.c b/lib/nvme/nvme_ctrlr.c index a43a70fa2..45e2ae157 100644 --- a/lib/nvme/nvme_ctrlr.c +++ b/lib/nvme/nvme_ctrlr.c @@ -333,8 +333,7 @@ spdk_nvme_ctrlr_alloc_io_qpair(struct spdk_nvme_ctrlr *ctrlr, return NULL; } - /* Only the low 2 bits (values 0, 1, 2, 3) of QPRIO are valid. */ - if ((opts.qprio & 3) != opts.qprio) { + if (opts.qprio & ~SPDK_NVME_CREATE_IO_SQ_QPRIO_MASK) { nvme_robust_mutex_unlock(&ctrlr->ctrlr_lock); return NULL; }