From 90513d3c5fd1bb9050bc566d525b905821f03780 Mon Sep 17 00:00:00 2001 From: yidong0635 Date: Mon, 1 Jul 2019 13:02:10 -0400 Subject: [PATCH] bdev_ut.c: Fix scanbuild issue about potential memory leak. Issue reports: bdev_ut.c:1486:2: warning: Potential leak of memory pointed to by 'histogram' poll_threads(); ^~~~~~~~~~~~~~ 1 warning generated. Add Tear down the channels like other tests in this file. Change-Id: Iaeff93ec6f17716dfb7638cf4dd5f6cfe2c2de06 Signed-off-by: yidong0635 Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/459939 Tested-by: SPDK CI Jenkins Reviewed-by: Hailiang Wang Reviewed-by: Shuhei Matsumoto Reviewed-by: Tomasz Zawadzki Reviewed-by: Changpeng Liu --- test/unit/lib/bdev/mt/bdev.c/bdev_ut.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/test/unit/lib/bdev/mt/bdev.c/bdev_ut.c b/test/unit/lib/bdev/mt/bdev.c/bdev_ut.c index 211a10a84..e2c1b1ab9 100644 --- a/test/unit/lib/bdev/mt/bdev.c/bdev_ut.c +++ b/test/unit/lib/bdev/mt/bdev.c/bdev_ut.c @@ -1499,6 +1499,16 @@ bdev_histograms_mt(void) CU_ASSERT(g_bdev.bdev.internal.histogram_enabled == false); spdk_histogram_data_free(g_histogram); + + /* Tear down the channels */ + set_thread(0); + spdk_put_io_channel(ch[0]); + set_thread(1); + spdk_put_io_channel(ch[1]); + poll_threads(); + set_thread(0); + teardown_test(); + } int