From 8dd1cd2104ea4001e4a0da2a4851ccd62c82f8e8 Mon Sep 17 00:00:00 2001 From: Ben Walker Date: Wed, 22 Jun 2022 14:35:04 -0700 Subject: [PATCH] check_format: For C files only, fix return type breaks In SPDK, declarations have the return type on the same line. Definitions have the return type on a separate line. Astyle has an option for enforcing this. Unfortunately, it seems to have two bugs: 1) It doesn't work correctly at all on C++ files. 2) It often fails on functions that return enums, or long type names Deal with 1) by adjusting the check_format.sh script to only tell astyle to fix return type line breaks for C files and not C++. Deal with 2) by adding a few typedefs to work around the problem. Change-Id: Idf28281466cab8411ce252d5f02ab384166790c6 Signed-off-by: Ben Walker Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/13437 Tested-by: SPDK CI Jenkins Reviewed-by: Jim Harris Reviewed-by: Dong Yi Reviewed-by: Tomasz Zawadzki Community-CI: Broadcom CI --- app/iscsi_top/iscsi_top.c | 6 +- app/spdk_dd/spdk_dd.c | 3 +- app/spdk_top/spdk_top.c | 3 +- app/trace/trace.cpp | 6 +- app/trace_record/trace_record.c | 6 +- examples/bdev/fio_plugin/fio_plugin.c | 11 +- examples/bdev/hello_world/hello_bdev.c | 3 +- examples/ioat/verify/verify.c | 3 +- examples/nvme/abort/abort.c | 3 +- examples/nvme/cmb_copy/cmb_copy.c | 3 +- examples/nvme/discovery_aer/discovery_aer.c | 6 +- examples/nvme/fio_plugin/fio_plugin.c | 55 ++-- examples/nvme/hello_world/hello_world.c | 3 +- examples/nvme/hotplug/hotplug.c | 14 +- examples/nvme/identify/identify.c | 3 +- examples/nvme/nvme_manage/nvme_manage.c | 6 +- examples/nvme/perf/perf.c | 9 +- .../nvme/pmr_persistence/pmr_persistence.c | 3 +- examples/nvme/reconnect/reconnect.c | 9 +- examples/nvmf/nvmf/nvmf.c | 3 +- examples/sock/hello_world/hello_sock.c | 3 +- examples/vmd/lsvmd/lsvmd.c | 3 +- include/linux/virtio_ring.h | 11 +- include/spdk/nvmf_transport.h | 3 +- include/spdk_internal/rdma.h | 10 +- include/spdk_internal/virtio.h | 3 +- lib/accel/accel_engine.c | 6 +- lib/bdev/bdev.c | 74 ++--- lib/blob/blobstore.c | 107 ++++--- lib/dma/dma.c | 6 +- lib/env_dpdk/env.c | 12 +- lib/env_ocf/mpool.c | 16 +- lib/env_ocf/ocf_env.c | 15 +- lib/env_ocf/ocf_env.h | 300 ++++++++++++------ lib/env_ocf/ocf_env_list.h | 22 +- lib/ftl/ftl_io.c | 3 +- lib/ftl/ftl_restore.c | 9 +- lib/ioat/ioat.c | 3 +- lib/iscsi/conn.c | 3 +- lib/iscsi/iscsi.c | 18 +- lib/iscsi/iscsi_subsystem.c | 3 +- lib/iscsi/md5.c | 9 +- lib/iscsi/param.h | 32 +- lib/iscsi/tgt_node.c | 10 +- lib/json/json_write.c | 43 ++- lib/jsonrpc/jsonrpc_client_tcp.c | 5 +- lib/nbd/nbd.c | 6 +- lib/nvme/nvme_ctrlr.c | 16 +- lib/nvme/nvme_ctrlr_cmd.c | 9 +- lib/nvme/nvme_cuse.c | 6 +- lib/nvme/nvme_ns.c | 15 +- lib/nvme/nvme_opal.c | 3 +- lib/nvme/nvme_pcie.c | 7 +- lib/nvme/nvme_pcie_common.c | 4 +- lib/nvme/nvme_rdma.c | 10 +- lib/nvme/nvme_tcp.c | 10 +- lib/nvme/nvme_transport.c | 6 +- lib/nvmf/ctrlr.c | 9 +- lib/nvmf/ctrlr_bdev.c | 7 +- lib/nvmf/fc.c | 3 +- lib/nvmf/fc_ls.c | 18 +- lib/nvmf/nvmf.c | 9 +- lib/nvmf/nvmf_fc.h | 7 +- lib/nvmf/nvmf_rpc.c | 3 +- lib/nvmf/rdma.c | 28 +- lib/nvmf/subsystem.c | 19 +- lib/nvmf/tcp.c | 3 +- lib/nvmf/transport.c | 7 +- lib/nvmf/vfio_user.c | 17 +- lib/reduce/reduce.c | 3 +- lib/scsi/scsi_pr.c | 3 +- lib/sock/sock.c | 3 +- lib/vhost/vhost_blk.c | 4 +- lib/vhost/vhost_internal.h | 7 +- module/bdev/aio/bdev_aio.c | 9 +- module/bdev/crypto/vbdev_crypto.c | 3 +- module/bdev/delay/vbdev_delay.c | 3 +- module/bdev/gpt/vbdev_gpt.c | 3 +- module/bdev/iscsi/bdev_iscsi.c | 6 +- module/bdev/malloc/bdev_malloc.c | 9 +- module/bdev/nvme/bdev_nvme_rpc.c | 3 +- module/bdev/ocf/ctx.c | 12 +- module/bdev/ocf/volume.h | 3 +- module/bdev/passthru/vbdev_passthru.c | 3 +- module/bdev/raid/bdev_raid.c | 15 +- module/bdev/raid/bdev_raid.h | 13 +- module/bdev/raid/concat.c | 9 +- module/bdev/raid/raid0.c | 9 +- module/bdev/split/vbdev_split.c | 3 +- module/bdev/uring/bdev_uring.c | 14 +- module/bdev/virtio/bdev_virtio.h | 3 +- module/bdev/virtio/bdev_virtio_scsi.c | 6 +- module/event/subsystems/nvmf/nvmf_rpc.c | 3 +- scripts/check_format.sh | 2 +- test/app/fuzz/llvm_nvme_fuzz/llvm_nvme_fuzz.c | 51 ++- test/blobfs/fuse/fuse.c | 3 +- test/blobfs/mkfs/mkfs.c | 3 +- test/dma/test_dma/test_dma.c | 28 +- test/env/pci/pci_ut.c | 6 +- test/event/app_repeat/app_repeat.c | 3 +- test/external_code/passthru/vbdev_passthru.c | 3 +- test/nvme/aer/aer.c | 3 +- test/nvme/boot_partition/boot_partition.c | 3 +- test/nvme/compliance/nvme_compliance.c | 3 +- test/nvme/connect_stress/connect_stress.c | 6 +- test/nvme/cuse/cuse.c | 3 +- .../deallocated_value/deallocated_value.c | 3 +- test/nvme/e2edp/nvme_dp.c | 42 ++- test/nvme/err_injection/err_injection.c | 3 +- test/nvme/fused_ordering/fused_ordering.c | 3 +- test/nvme/overhead/overhead.c | 6 +- test/nvme/reserve/reserve.c | 3 +- test/nvme/reset/reset.c | 6 +- test/nvme/sgl/sgl.c | 45 ++- test/nvme/simple_copy/simple_copy.c | 3 +- test/nvme/startup/startup.c | 3 +- test/rpc_client/rpc_client_test.c | 3 +- test/unit/lib/accel/accel.c/accel_engine_ut.c | 3 +- test/unit/lib/bdev/compress.c/compress_ut.c | 22 +- test/unit/lib/bdev/crypto.c/crypto_ut.c | 14 +- .../lib/bdev/nvme/bdev_nvme.c/bdev_nvme_ut.c | 5 +- .../lib/bdev/raid/bdev_raid.c/bdev_raid_ut.c | 9 +- .../lib/bdev/vbdev_lvol.c/vbdev_lvol_ut.c | 3 +- .../vbdev_zone_block.c/vbdev_zone_block_ut.c | 6 +- test/unit/lib/blob/blob.c/blob_ut.c | 3 +- .../blobfs/blobfs_async_ut/blobfs_async_ut.c | 3 +- .../lib/blobfs/blobfs_bdev.c/blobfs_bdev_ut.c | 3 +- .../blobfs/blobfs_sync_ut/blobfs_sync_ut.c | 3 +- test/unit/lib/blobfs/tree.c/tree_ut.c | 3 +- .../lib/env_dpdk/pci_event.c/pci_event_ut.c | 3 +- test/unit/lib/idxd/idxd_user.c/idxd_user_ut.c | 3 +- test/unit/lib/ioat/ioat.c/ioat_ut.c | 6 +- test/unit/lib/iscsi/conn.c/conn_ut.c | 3 +- .../lib/json/json_parse.c/json_parse_ut.c | 3 +- test/unit/lib/json/json_util.c/json_util_ut.c | 3 +- .../lib/json/json_write.c/json_write_ut.c | 3 +- .../jsonrpc_server.c/jsonrpc_server_ut.c | 3 +- test/unit/lib/log/log.c/log_ut.c | 3 +- test/unit/lib/lvol/lvol.c/lvol_ut.c | 28 +- test/unit/lib/nvme/nvme.c/nvme_ut.c | 3 +- .../lib/nvme/nvme_ctrlr.c/nvme_ctrlr_ut.c | 18 +- .../nvme/nvme_ctrlr_cmd.c/nvme_ctrlr_cmd_ut.c | 114 ++++--- .../nvme_ctrlr_ocssd_cmd_ut.c | 6 +- test/unit/lib/nvme/nvme_cuse.c/nvme_cuse_ut.c | 3 +- .../lib/nvme/nvme_fabric.c/nvme_fabric_ut.c | 3 +- .../lib/nvme/nvme_io_msg.c/nvme_io_msg_ut.c | 3 +- test/unit/lib/nvme/nvme_ns.c/nvme_ns_ut.c | 3 +- .../lib/nvme/nvme_ns_cmd.c/nvme_ns_cmd_ut.c | 12 +- .../nvme_ns_ocssd_cmd_ut.c | 3 +- test/unit/lib/nvme/nvme_opal.c/nvme_opal_ut.c | 3 +- test/unit/lib/nvme/nvme_pcie.c/nvme_pcie_ut.c | 6 +- .../nvme_pcie_common.c/nvme_pcie_common_ut.c | 12 +- .../lib/nvme/nvme_qpair.c/nvme_qpair_ut.c | 12 +- .../lib/nvme/nvme_quirks.c/nvme_quirks_ut.c | 3 +- test/unit/lib/nvme/nvme_rdma.c/nvme_rdma_ut.c | 9 +- test/unit/lib/nvme/nvme_tcp.c/nvme_tcp_ut.c | 3 +- .../nvme/nvme_transport.c/nvme_transport_ut.c | 3 +- test/unit/lib/nvmf/ctrlr.c/ctrlr_ut.c | 3 +- .../lib/nvmf/ctrlr_bdev.c/ctrlr_bdev_ut.c | 17 +- .../ctrlr_discovery.c/ctrlr_discovery_ut.c | 3 +- test/unit/lib/nvmf/fc.c/fc_ut.c | 3 +- test/unit/lib/nvmf/fc_ls.c/fc_ls_ut.c | 3 +- test/unit/lib/nvmf/nvmf.c/nvmf_ut.c | 3 +- test/unit/lib/nvmf/rdma.c/rdma_ut.c | 11 +- test/unit/lib/nvmf/subsystem.c/subsystem_ut.c | 3 +- test/unit/lib/nvmf/tcp.c/tcp_ut.c | 3 +- test/unit/lib/nvmf/transport.c/transport_ut.c | 3 +- test/unit/lib/nvmf/vfio_user.c/vfio_user_ut.c | 3 +- test/unit/lib/reduce/reduce.c/reduce_ut.c | 9 +- test/unit/lib/rpc/rpc.c/rpc_ut.c | 13 +- test/unit/lib/scsi/lun.c/lun_ut.c | 3 +- test/unit/lib/vhost/vhost.c/vhost_ut.c | 5 +- 172 files changed, 1186 insertions(+), 748 deletions(-) diff --git a/app/iscsi_top/iscsi_top.c b/app/iscsi_top/iscsi_top.c index fac216a6d..b78b309c6 100644 --- a/app/iscsi_top/iscsi_top.c +++ b/app/iscsi_top/iscsi_top.c @@ -19,7 +19,8 @@ static int g_shm_id = 0; struct spdk_jsonrpc_client *g_rpc_client; -static void usage(void) +static void +usage(void) { fprintf(stderr, "usage:\n"); fprintf(stderr, " %s