From 8d515e0243da47d461dc052bec706db98aa06ce0 Mon Sep 17 00:00:00 2001 From: Jim Harris Date: Wed, 1 Jun 2022 23:29:13 +0000 Subject: [PATCH] python: remove unneeded deprecated_alias imports We removed all of the existing deprecated aliases recently, but didn't remove the associated imports. Found by lgtm.com. Signed-off-by: Jim Harris Change-Id: I2b8526254da26ad4a9b34eb67b155dacfe9a5e57 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/12862 Community-CI: Broadcom CI Tested-by: SPDK CI Jenkins Reviewed-by: Konrad Sztyber Reviewed-by: Tomasz Zawadzki --- python/spdk/rpc/__init__.py | 1 - python/spdk/rpc/app.py | 3 --- python/spdk/rpc/bdev.py | 3 --- python/spdk/rpc/ioat.py | 3 --- python/spdk/rpc/iscsi.py | 3 --- python/spdk/rpc/log.py | 3 --- python/spdk/rpc/lvol.py | 3 --- python/spdk/rpc/nbd.py | 3 --- python/spdk/rpc/notify.py | 3 --- python/spdk/rpc/nvme.py | 3 --- python/spdk/rpc/nvmf.py | 1 - python/spdk/rpc/pmem.py | 3 --- python/spdk/rpc/subsystem.py | 3 --- python/spdk/rpc/trace.py | 3 --- python/spdk/rpc/vhost.py | 1 - 15 files changed, 39 deletions(-) diff --git a/python/spdk/rpc/__init__.py b/python/spdk/rpc/__init__.py index d1624e6f9..4a6aff4ff 100644 --- a/python/spdk/rpc/__init__.py +++ b/python/spdk/rpc/__init__.py @@ -25,7 +25,6 @@ from . import vhost from . import vmd from . import sock from . import client as rpc_client -from .helpers import deprecated_alias def framework_start_init(client): diff --git a/python/spdk/rpc/app.py b/python/spdk/rpc/app.py index 13f9d0b9b..891ebc6a0 100644 --- a/python/spdk/rpc/app.py +++ b/python/spdk/rpc/app.py @@ -1,6 +1,3 @@ -from .helpers import deprecated_alias - - def spdk_kill_instance(client, sig_name): """Send a signal to the SPDK process. diff --git a/python/spdk/rpc/bdev.py b/python/spdk/rpc/bdev.py index c722e7d68..b5b656de7 100644 --- a/python/spdk/rpc/bdev.py +++ b/python/spdk/rpc/bdev.py @@ -1,6 +1,3 @@ -from .helpers import deprecated_alias - - def bdev_set_options(client, bdev_io_pool_size=None, bdev_io_cache_size=None, bdev_auto_examine=None, small_buf_pool_size=None, large_buf_pool_size=None): """Set parameters for the bdev subsystem. diff --git a/python/spdk/rpc/ioat.py b/python/spdk/rpc/ioat.py index fc9ca4290..023f4ac5d 100644 --- a/python/spdk/rpc/ioat.py +++ b/python/spdk/rpc/ioat.py @@ -1,6 +1,3 @@ -from .helpers import deprecated_alias - - def ioat_scan_accel_engine(client): """Enable IOAT accel engine. """ diff --git a/python/spdk/rpc/iscsi.py b/python/spdk/rpc/iscsi.py index 3d6c2d5da..cf7f3e5a7 100644 --- a/python/spdk/rpc/iscsi.py +++ b/python/spdk/rpc/iscsi.py @@ -1,6 +1,3 @@ -from .helpers import deprecated_alias - - def iscsi_set_options( client, auth_file=None, diff --git a/python/spdk/rpc/log.py b/python/spdk/rpc/log.py index 22f173da1..f73c115e8 100644 --- a/python/spdk/rpc/log.py +++ b/python/spdk/rpc/log.py @@ -1,6 +1,3 @@ -from .helpers import deprecated_alias - - def log_set_flag(client, flag): """Set log flag. diff --git a/python/spdk/rpc/lvol.py b/python/spdk/rpc/lvol.py index 67b1e9b4b..f7c89e3fd 100644 --- a/python/spdk/rpc/lvol.py +++ b/python/spdk/rpc/lvol.py @@ -1,6 +1,3 @@ -from .helpers import deprecated_alias - - def bdev_lvol_create_lvstore(client, bdev_name, lvs_name, cluster_sz=None, clear_method=None): """Construct a logical volume store. diff --git a/python/spdk/rpc/nbd.py b/python/spdk/rpc/nbd.py index 10b74f6ea..ce2ee6c35 100644 --- a/python/spdk/rpc/nbd.py +++ b/python/spdk/rpc/nbd.py @@ -1,6 +1,3 @@ -from .helpers import deprecated_alias - - def nbd_start_disk(client, bdev_name, nbd_device): params = { 'bdev_name': bdev_name diff --git a/python/spdk/rpc/notify.py b/python/spdk/rpc/notify.py index 3e648f19f..f6288deb1 100644 --- a/python/spdk/rpc/notify.py +++ b/python/spdk/rpc/notify.py @@ -1,6 +1,3 @@ -from .helpers import deprecated_alias - - def notify_get_types(client): return client.call("notify_get_types") diff --git a/python/spdk/rpc/nvme.py b/python/spdk/rpc/nvme.py index f19b9a28e..dad4f02bb 100644 --- a/python/spdk/rpc/nvme.py +++ b/python/spdk/rpc/nvme.py @@ -1,6 +1,3 @@ -from .helpers import deprecated_alias - - def bdev_nvme_send_cmd(client, name, cmd_type, data_direction, cmdbuf, data=None, metadata=None, data_len=None, metadata_len=None, diff --git a/python/spdk/rpc/nvmf.py b/python/spdk/rpc/nvmf.py index c4fc392f3..dfb4bd296 100644 --- a/python/spdk/rpc/nvmf.py +++ b/python/spdk/rpc/nvmf.py @@ -1,4 +1,3 @@ -from .helpers import deprecated_alias from .cmd_parser import * diff --git a/python/spdk/rpc/pmem.py b/python/spdk/rpc/pmem.py index 557da633a..8cb25148d 100644 --- a/python/spdk/rpc/pmem.py +++ b/python/spdk/rpc/pmem.py @@ -1,6 +1,3 @@ -from .helpers import deprecated_alias - - def bdev_pmem_create_pool(client, pmem_file, num_blocks, block_size): """Create pmem pool at specified path. Args: diff --git a/python/spdk/rpc/subsystem.py b/python/spdk/rpc/subsystem.py index 5717ce554..1701d2aff 100644 --- a/python/spdk/rpc/subsystem.py +++ b/python/spdk/rpc/subsystem.py @@ -1,6 +1,3 @@ -from .helpers import deprecated_alias - - def framework_get_subsystems(client): return client.call('framework_get_subsystems') diff --git a/python/spdk/rpc/trace.py b/python/spdk/rpc/trace.py index 075548b24..37c7803d1 100644 --- a/python/spdk/rpc/trace.py +++ b/python/spdk/rpc/trace.py @@ -1,6 +1,3 @@ -from .helpers import deprecated_alias - - def trace_enable_tpoint_group(client, name): """Enable trace on a specific tpoint group. diff --git a/python/spdk/rpc/vhost.py b/python/spdk/rpc/vhost.py index 43e2a4ce9..16bcbd8d9 100644 --- a/python/spdk/rpc/vhost.py +++ b/python/spdk/rpc/vhost.py @@ -1,4 +1,3 @@ -from .helpers import deprecated_alias from .cmd_parser import *