From 8d512770463fb117c429d63a20f14f176c031d16 Mon Sep 17 00:00:00 2001 From: Ziye Yang Date: Fri, 13 Dec 2019 17:29:35 +0800 Subject: [PATCH] nvmf/tcp: remove the unnecessary error info. It will be the expected behavior when the error message will printed if we use asynchrounous I/O. And the real error message for not getting the tcp_req is located in spdk_nvmf_tcp_capsule_cmd_hdr_handle. Change-Id: I1a608fbd3a04050eacb6cb68eafd50e5128925ab Signed-off-by: Ziye Yang Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/477872 Tested-by: SPDK CI Jenkins Reviewed-by: Changpeng Liu Reviewed-by: Jim Harris Reviewed-by: Ben Walker Reviewed-by: Shuhei Matsumoto --- lib/nvmf/tcp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/nvmf/tcp.c b/lib/nvmf/tcp.c index e1639a57f..abeec7383 100644 --- a/lib/nvmf/tcp.c +++ b/lib/nvmf/tcp.c @@ -355,7 +355,6 @@ spdk_nvmf_tcp_req_get(struct spdk_nvmf_tcp_qpair *tqpair) tcp_req = TAILQ_FIRST(&tqpair->state_queue[TCP_REQUEST_STATE_FREE]); if (!tcp_req) { - SPDK_ERRLOG("Cannot allocate tcp_req on tqpair=%p\n", tqpair); return NULL; } @@ -1287,7 +1286,7 @@ spdk_nvmf_tcp_capsule_cmd_hdr_handle(struct spdk_nvmf_tcp_transport *ttransport, } /* The host sent more commands than the maximum queue depth. */ - SPDK_ERRLOG("Cannot allocate tcp_req\n"); + SPDK_ERRLOG("Cannot allocate tcp_req on tqpair=%p\n", tqpair); tqpair->state = NVME_TCP_QPAIR_STATE_EXITING; spdk_nvmf_tcp_qpair_set_recv_state(tqpair, NVME_TCP_PDU_RECV_STATE_ERROR); return;