From 8caf8f5ef782b4a109da6122d6abd818bd57d9ea Mon Sep 17 00:00:00 2001
From: Mike Gerdts <mgerdts@nvidia.com>
Date: Mon, 20 Dec 2021 16:02:42 +0000
Subject: [PATCH] blob: report unexpected descriptor types

When printing blob metadata via blobcli, descriptor types that do not
have full dump support should not be silently ignored. This prints a
message that indicates an unsupported descriptor type was encountered
so that the person debugging with blobcli knows that there is more
metadata present.

Signed-off-by: Mike Gerdts <mgerdts@nvidia.com>
Change-Id: Id30b671fd9dee1ec12e10625eb2af4c1e43eda27
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/11258
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>
Reviewed-by: Paul Luse <paul.e.luse@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
---
 lib/blob/blobstore.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/blob/blobstore.c b/lib/blob/blobstore.c
index 2782d3f1f..259efd489 100644
--- a/lib/blob/blobstore.c
+++ b/lib/blob/blobstore.c
@@ -4788,6 +4788,7 @@ bs_dump_print_md_page(struct spdk_bs_load_ctx *ctx)
 			bs_dump_print_type_flags(ctx, desc);
 		} else {
 			/* Error */
+			fprintf(ctx->fp, "Unknown descriptor type %" PRIu8 "\n", desc->type);
 		}
 		/* Advance to the next descriptor */
 		cur_desc += sizeof(*desc) + desc->length;