From 8caf6b646949e0eee0b452bf8f777871d8320aac Mon Sep 17 00:00:00 2001 From: Seth Howell Date: Tue, 18 Dec 2018 13:29:38 -0700 Subject: [PATCH] test: fix bogus scan-build error in blobfs_async_ut Scan-build :/ Change-Id: Iada0b716457178b3cba2ba90cf375a4011518557 Signed-off-by: Seth Howell Reviewed-on: https://review.gerrithub.io/437737 Tested-by: SPDK CI Jenkins Chandler-Test-Pool: SPDK Automated Test System Reviewed-by: Changpeng Liu Reviewed-by: Jim Harris --- test/unit/lib/blobfs/blobfs_async_ut/blobfs_async_ut.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/test/unit/lib/blobfs/blobfs_async_ut/blobfs_async_ut.c b/test/unit/lib/blobfs/blobfs_async_ut/blobfs_async_ut.c index 669a9cbd5..6cdb92028 100644 --- a/test/unit/lib/blobfs/blobfs_async_ut/blobfs_async_ut.c +++ b/test/unit/lib/blobfs/blobfs_async_ut/blobfs_async_ut.c @@ -268,7 +268,7 @@ static void fs_rename(void) { struct spdk_filesystem *fs; - struct spdk_file *file, *file2; + struct spdk_file *file, *file2, *file_iter; struct spdk_bs_dev *dev; dev = init_dev(); @@ -326,6 +326,11 @@ fs_rename(void) spdk_fs_delete_file_async(fs, "file1", delete_cb, NULL); CU_ASSERT(g_fserrno == -ENOENT); CU_ASSERT(!TAILQ_EMPTY(&fs->files)); + TAILQ_FOREACH(file_iter, &fs->files, tailq) { + if (file_iter == NULL) { + SPDK_CU_ASSERT_FATAL(false); + } + } g_fserrno = 1; spdk_fs_delete_file_async(fs, "file2", delete_cb, NULL);