ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

idxd: Remove unused nop_check callback

Browse Source 
Signed-off-by: Ben Walker <benjamin.walker@intel.com>
Change-Id: Ibda86694edc10a3edec8cb85638b4950647b13eb
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/11435
Reviewed-by: Paul Luse <paul.e.luse@intel.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
This commit is contained in:
Ben Walker 2022-02-02 13:21:50 -07:00 committed by Jim Harris
parent 7ddc75abdb
commit 8c400e494a
2 changed files with 1 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/idxd/idxd.h
View File

@ -162,8 +162,6 @@ struct spdk_idxd_impl {
void (*destruct)(struct spdk_idxd_device *idxd); void (*destruct)(struct spdk_idxd_device *idxd);
void (*dump_sw_error)(struct spdk_idxd_device *idxd, void *portal); void (*dump_sw_error)(struct spdk_idxd_device *idxd, void *portal);
char *(*portal_get_addr)(struct spdk_idxd_device *idxd); char *(*portal_get_addr)(struct spdk_idxd_device *idxd);
/* It is a workaround for simulator */
bool (*nop_check)(struct spdk_idxd_device *idxd);
STAILQ_ENTRY(spdk_idxd_impl) link; STAILQ_ENTRY(spdk_idxd_impl) link;
}; };

16
lib/idxd/idxd_user.c
View File

@ -550,27 +550,13 @@ user_idxd_portal_get_addr(struct spdk_idxd_device *idxd)
return (char *)idxd->portals + idxd->wq_id * WQ_TOTAL_PORTAL_SIZE; return (char *)idxd->portals + idxd->wq_id * WQ_TOTAL_PORTAL_SIZE;
} }
static bool
user_idxd_nop_check(struct spdk_idxd_device *idxd)
{
struct spdk_user_idxd_device *user_idxd = __user_idxd(idxd);
/* TODO: temp workaround for simulator. Remove this function when fixed or w/silicon. */
if (user_idxd->registers.gencap.raw == 0x1833f011f) {
return true;
}
return false;
}
static struct spdk_idxd_impl g_user_idxd_impl = { static struct spdk_idxd_impl g_user_idxd_impl = {
.name = "user", .name = "user",
.set_config = user_idxd_set_config, .set_config = user_idxd_set_config,
.probe = user_idxd_probe, .probe = user_idxd_probe,
.destruct = user_idxd_device_destruct, .destruct = user_idxd_device_destruct,
.dump_sw_error = user_idxd_dump_sw_err, .dump_sw_error = user_idxd_dump_sw_err,
.portal_get_addr = user_idxd_portal_get_addr, .portal_get_addr = user_idxd_portal_get_addr
.nop_check = user_idxd_nop_check,
}; };
/* Caller must hold g_driver_lock */ /* Caller must hold g_driver_lock */