ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

iscsi: Deprecate MinConnectionsPerCore finally

Browse Source 
Parameter 'MinConnectionsPerCore' was removed in last release and marked
as deprecated, now we will deprecate 'MinConnectionsPerCore' finally.

Change-Id: I613a371e8b5352dfb84f8e4293805b792020c643
Signed-off-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/468789
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: Paul Luse <paul.e.luse@intel.com>
This commit is contained in:
Changpeng Liu 2019-09-19 03:29:29 -04:00
parent fbeebab02c
commit 8a857a3b30
4 changed files with 0 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
lib/iscsi/iscsi.h
View File

@ -308,7 +308,6 @@ struct spdk_iscsi_opts {
bool ImmediateData;
uint32_t ErrorRecoveryLevel;
bool AllowDuplicateIsid;
uint32_t min_connections_per_core; /* Deprecated */
};
struct spdk_iscsi_globals {

1
lib/iscsi/iscsi_rpc.c
View File

@ -1520,7 +1520,6 @@ static const struct spdk_json_object_decoder rpc_set_iscsi_opts_decoders[] = {
{"immediate_data", offsetof(struct spdk_iscsi_opts, ImmediateData), spdk_json_decode_bool, true},
{"error_recovery_level", offsetof(struct spdk_iscsi_opts, ErrorRecoveryLevel), spdk_json_decode_uint32, true},
{"allow_duplicated_isid", offsetof(struct spdk_iscsi_opts, AllowDuplicateIsid), spdk_json_decode_bool, true},
{"min_connections_per_core", offsetof(struct spdk_iscsi_opts, min_connections_per_core), spdk_json_decode_uint32, true},
};
static void

11
lib/iscsi/iscsi_subsystem.c
View File

@ -399,7 +399,6 @@ iscsi_opts_init(struct spdk_iscsi_opts *opts)
opts->chap_group = 0;
opts->authfile = NULL;
opts->nodebase = NULL;
opts->min_connections_per_core = 0;
}
struct spdk_iscsi_opts *
@ -472,7 +471,6 @@ spdk_iscsi_opts_copy(struct spdk_iscsi_opts *src)
dst->require_chap = src->require_chap;
dst->mutual_chap = src->mutual_chap;
dst->chap_group = src->chap_group;
dst->min_connections_per_core = 0;
return dst;
}
@ -491,7 +489,6 @@ iscsi_read_config_file_params(struct spdk_conf_section *sp,
int ErrorRecoveryLevel;
int timeout;
int nopininterval;
int min_conn_per_core = 0;
const char *ag_tag;
int ag_tag_i;
int i;
@ -619,10 +616,6 @@ iscsi_read_config_file_params(struct spdk_conf_section *sp,
}
}
}
min_conn_per_core = spdk_conf_section_get_intval(sp, "MinConnectionsPerCore");
if (min_conn_per_core >= 0) {
SPDK_WARNLOG("MinConnectionsPerCore is deprecated and will be ignored.\n");
}
return 0;
}
@ -776,10 +769,6 @@ iscsi_set_global_params(struct spdk_iscsi_opts *opts)
g_spdk_iscsi.mutual_chap = opts->mutual_chap;
g_spdk_iscsi.chap_group = opts->chap_group;
if (opts->min_connections_per_core) {
SPDK_WARNLOG("iSCSI option 'min_connections_per_core' has been deprecated and will be ignored.\n");
}
iscsi_log_globals();
return 0;

1
test/config_converter/config.ini
View File

@ -42,7 +42,6 @@
MaxR2T 256
NopInInterval 10
AllowDuplicateIsid Yes
MinConnectionsPerCore 4
DefaultTime2Wait 2
QueueDepth 128