From 86d7e4dc1834e24108711295ba7b24823e0a0d5a Mon Sep 17 00:00:00 2001 From: Jacek Kalwas Date: Thu, 2 Sep 2021 09:22:40 -0400 Subject: [PATCH] nvmf: add interface to dump transport specific listen opts transport specific options are already introduced however dump was missed Signed-off-by: Jacek Kalwas Change-Id: I2fe533898d82534cc6cb8a3e5de4e2b2c72ae00a Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/9355 Community-CI: Mellanox Build Bot Community-CI: Broadcom CI Tested-by: SPDK CI Jenkins Reviewed-by: Tomasz Zawadzki Reviewed-by: Shuhei Matsumoto --- include/spdk/nvmf_transport.h | 6 ++++++ lib/nvmf/transport.c | 4 ++++ 2 files changed, 10 insertions(+) diff --git a/include/spdk/nvmf_transport.h b/include/spdk/nvmf_transport.h index 8e6c62a62..8cc7c074c 100644 --- a/include/spdk/nvmf_transport.h +++ b/include/spdk/nvmf_transport.h @@ -259,6 +259,12 @@ struct spdk_nvmf_transport_ops { int (*listen)(struct spdk_nvmf_transport *transport, const struct spdk_nvme_transport_id *trid, struct spdk_nvmf_listen_opts *opts); + /** + * Dump transport-specific listen opts into JSON + */ + void (*listen_dump_opts)(struct spdk_nvmf_transport *transport, + const struct spdk_nvme_transport_id *trid, struct spdk_json_write_ctx *w); + /** * Stop accepting new connections at the given address. */ diff --git a/lib/nvmf/transport.c b/lib/nvmf/transport.c index 52c984ced..74d83bed8 100644 --- a/lib/nvmf/transport.c +++ b/lib/nvmf/transport.c @@ -136,6 +136,10 @@ nvmf_transport_listen_dump_opts(struct spdk_nvmf_transport *transport, spdk_json_write_named_string(w, "traddr", trid->traddr); spdk_json_write_named_string(w, "trsvcid", trid->trsvcid); + if (transport->ops->listen_dump_opts) { + transport->ops->listen_dump_opts(transport, trid, w); + } + spdk_json_write_object_end(w); }