ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bdev/nvme: remove NOTICELOGS in update ns path

Browse Source 
We're going to reuse this code in a more common path
which would raise the visibility of these noticelogs
significantly.  These aren't exceptional conditions,
so there's no need to print them when they happen.

Signed-off-by: Jim Harris <james.r.harris@intel.com>
Change-Id: I1b56e3a4e5603e223bae07dc1c9e1ada03ba5901

Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/475793
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
This commit is contained in:
Jim Harris 2019-11-25 14:24:20 -07:00 committed by Tomasz Zawadzki
parent 9a78ffbbc8
commit 85a7f53e69
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
module/bdev/nvme/bdev_nvme.c
View File

@ -1045,7 +1045,6 @@ nvme_ctrlr_update_ns_bdevs(struct nvme_bdev_ctrlr *nvme_bdev_ctrlr)
ns = nvme_bdev_ctrlr->namespaces[i]; ns = nvme_bdev_ctrlr->namespaces[i];
if (!ns->active && spdk_nvme_ctrlr_is_active_ns(ctrlr, nsid)) { if (!ns->active && spdk_nvme_ctrlr_is_active_ns(ctrlr, nsid)) {
SPDK_NOTICELOG("NSID %u to be added\n", nsid);
ns->id = nsid; ns->id = nsid;
ns->ctrlr = nvme_bdev_ctrlr; ns->ctrlr = nvme_bdev_ctrlr;
@ -1060,7 +1059,6 @@ nvme_ctrlr_update_ns_bdevs(struct nvme_bdev_ctrlr *nvme_bdev_ctrlr)
} }
if (ns->active && !spdk_nvme_ctrlr_is_active_ns(ctrlr, nsid)) { if (ns->active && !spdk_nvme_ctrlr_is_active_ns(ctrlr, nsid)) {
SPDK_NOTICELOG("NSID %u is removed\n", nsid);
nvme_ctrlr_deactivate_namespace(ns); nvme_ctrlr_deactivate_namespace(ns);
} }
} }