From 84cec154e815ba7e678c8dc2472a1fa5491a9f34 Mon Sep 17 00:00:00 2001 From: Ben Walker Date: Wed, 4 May 2022 11:25:21 -0700 Subject: [PATCH] spdk_dd: Allow io_uring to use O_NONBLOCK This works fine on recent Linux kernels. Change-Id: If3bf7feb88666d5c3e4b2f3e5071d6be6937fdf8 Signed-off-by: Ben Walker Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/12515 Tested-by: SPDK CI Jenkins Reviewed-by: Dong Yi Reviewed-by: Shuhei Matsumoto Reviewed-by: Jim Harris --- app/spdk_dd/spdk_dd.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/app/spdk_dd/spdk_dd.c b/app/spdk_dd/spdk_dd.c index 841fde431..b2a14c401 100644 --- a/app/spdk_dd/spdk_dd.c +++ b/app/spdk_dd/spdk_dd.c @@ -623,14 +623,6 @@ dd_open_file(struct dd_target *target, const char *fname, int flags, uint64_t sk flags |= O_TRUNC; } -#ifdef SPDK_CONFIG_URING - /* io_uring does not work correctly with O_NONBLOCK flag */ - if (flags & O_NONBLOCK && g_opts.aio == false) { - flags &= ~O_NONBLOCK; - SPDK_WARNLOG("Skipping 'nonblock' flag due to existing issue with uring implementation and this flag\n"); - } -#endif - target->type = DD_TARGET_TYPE_FILE; *fd = open(fname, flags, 0600); if (*fd < 0) {