From 84420e8300bde2b7b2bd737694a5dcd98759aefd Mon Sep 17 00:00:00 2001 From: Darek Stojaczyk Date: Fri, 26 Jul 2019 10:59:39 +0200 Subject: [PATCH] dpdkbuild: fix CONFIG_RTE_BUILD_SHARED_LIB We commented out this build option in our DPDK fork, but DPDK makefiles check its value specifically against 'n' to set linking flags properly. It's currently unset, so it fails both == 'n' and == 'y' checks, which fails the build. Shared lib build has some issues on FreeBSD right now, so to fix the immediate problem, just define the shared lib option to 'n' for now. This matches the original behavior. We've always built DPDK as a static library. Change-Id: I5a880b777153cc169c3a135d412aa2014f4de8e0 Signed-off-by: Darek Stojaczyk Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/463290 Tested-by: SPDK CI Jenkins Reviewed-by: Paul Luse Reviewed-by: Jim Harris Reviewed-by: Ben Walker --- dpdkbuild/Makefile | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/dpdkbuild/Makefile b/dpdkbuild/Makefile index e458af28a..59a2eb3ef 100644 --- a/dpdkbuild/Makefile +++ b/dpdkbuild/Makefile @@ -40,6 +40,12 @@ DPDK_FRAMEWORK = n DPDK_OPTS = DPDK_CFLAGS = +# We commented out this build option in our DPDK fork, but DPDK makefiles check +# its value specifically against 'n' to set linking flags properly. Set it here +# to 'n' for now. +# TODO allow DPDK to be built as shared library +DPDK_OPTS += CONFIG_RTE_BUILD_SHARED_LIB=n + ifeq ($(CONFIG_CRYPTO),y) DPDK_FRAMEWORK = y DPDK_OPTS += CONFIG_RTE_LIBRTE_PMD_AESNI_MB=y