From 8337cc2d0cd0e4ddab7cdd7021096e043d8b26bc Mon Sep 17 00:00:00 2001 From: Lance Hartmann Date: Wed, 10 Oct 2018 11:55:39 -0400 Subject: [PATCH] env_dpdk: Eliminate unneeded start group ld opt The ENV_LINKER_ARGS was employing both the linker --[start|end]-group and --[whole|no-whole]-archive options around the DPDK_LIBs. With the use of whole/no-whole, the start/end bracketing is unnecessary. Change-Id: I97a2ac22df8c6b48ba674b9b292f5eea01823901 Signed-off-by: Lance Hartmann Reviewed-on: https://review.gerrithub.io/428737 Tested-by: SPDK CI Jenkins Reviewed-by: Ben Walker Reviewed-by: Jim Harris Chandler-Test-Pool: SPDK Automated Test System --- lib/env_dpdk/env.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/env_dpdk/env.mk b/lib/env_dpdk/env.mk index 2a8310e36..97c87b459 100644 --- a/lib/env_dpdk/env.mk +++ b/lib/env_dpdk/env.mk @@ -96,7 +96,7 @@ ENV_CFLAGS = $(DPDK_INC) -Wno-deprecated-declarations ENV_CXXFLAGS = $(ENV_CFLAGS) ENV_DPDK_FILE = $(call spdk_lib_list_to_files,env_dpdk) ENV_LIBS = $(ENV_DPDK_FILE) $(DPDK_LIB) -ENV_LINKER_ARGS = $(ENV_DPDK_FILE) -Wl,--start-group -Wl,--whole-archive $(DPDK_LIB) -Wl,--end-group -Wl,--no-whole-archive +ENV_LINKER_ARGS = $(ENV_DPDK_FILE) -Wl,--whole-archive $(DPDK_LIB) -Wl,--no-whole-archive ifneq (,$(wildcard $(DPDK_INC_DIR)/rte_config.h)) ifneq (,$(shell grep -e "define RTE_LIBRTE_VHOST_NUMA 1" -e "define RTE_EAL_NUMA_AWARE_HUGEPAGES 1" $(DPDK_INC_DIR)/rte_config.h))