From 82a54d29f6ef22871006cbd6788390b6e313da90 Mon Sep 17 00:00:00 2001 From: Tomasz Kulasek Date: Thu, 14 Nov 2019 09:51:11 -0500 Subject: [PATCH] lib/nvme: fix nvme_io_msg_ctrlr_unregister with no io_msg_producer Change-Id: If2e0d00560311948570a2d7113dc5f730d937c0c Signed-off-by: Tomasz Kulasek Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/474257 Tested-by: SPDK CI Jenkins Reviewed-by: Shuhei Matsumoto Reviewed-by: Jim Harris Reviewed-by: Tomasz Zawadzki --- lib/nvme/nvme_io_msg.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/nvme/nvme_io_msg.c b/lib/nvme/nvme_io_msg.c index 41a1aee62..f9c084c73 100644 --- a/lib/nvme/nvme_io_msg.c +++ b/lib/nvme/nvme_io_msg.c @@ -163,10 +163,9 @@ void nvme_io_msg_ctrlr_unregister(struct spdk_nvme_ctrlr *ctrlr, struct nvme_io_msg_producer *io_msg_producer) { - if (io_msg_producer != NULL) { - STAILQ_REMOVE(&ctrlr->io_producers, io_msg_producer, nvme_io_msg_producer, link); - } + assert(io_msg_producer != NULL); + STAILQ_REMOVE(&ctrlr->io_producers, io_msg_producer, nvme_io_msg_producer, link); if (STAILQ_EMPTY(&ctrlr->io_producers)) { nvme_io_msg_ctrlr_detach(ctrlr); }