ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

subsystem module: remove support for deprecated RPC names

Browse Source 
These were deprecated in 2019, it's time to remove
support for them now.

Change-Id: I56dbaef56ff793e48441219e07dc6b02dda0b470
Signed-off-by: wanghailiangx <hailiangx.e.wang@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/12777
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
This commit is contained in:
wanghailiangx 2022-05-23 05:22:07 -04:00 committed by Jim Harris
parent 465f99e9ff
commit 81d3cc1b5a
3 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/init/subsystem_rpc.c
View File

@ -79,7 +79,6 @@ rpc_framework_get_subsystems(struct spdk_jsonrpc_request *request,
} }
SPDK_RPC_REGISTER("framework_get_subsystems", rpc_framework_get_subsystems, SPDK_RPC_RUNTIME) SPDK_RPC_REGISTER("framework_get_subsystems", rpc_framework_get_subsystems, SPDK_RPC_RUNTIME)
SPDK_RPC_REGISTER_ALIAS_DEPRECATED(framework_get_subsystems, get_subsystems)
struct rpc_framework_get_config_ctx { struct rpc_framework_get_config_ctx {
char *name; char *name;
@ -119,7 +118,6 @@ rpc_framework_get_config(struct spdk_jsonrpc_request *request,
} }
SPDK_RPC_REGISTER("framework_get_config", rpc_framework_get_config, SPDK_RPC_RUNTIME) SPDK_RPC_REGISTER("framework_get_config", rpc_framework_get_config, SPDK_RPC_RUNTIME)
SPDK_RPC_REGISTER_ALIAS_DEPRECATED(framework_get_config, get_subsystem_config)
static void static void
dump_pci_device(void *ctx, struct spdk_pci_device *dev) dump_pci_device(void *ctx, struct spdk_pci_device *dev)

2
python/spdk/rpc/subsystem.py
View File

@ -1,12 +1,10 @@
from .helpers import deprecated_alias from .helpers import deprecated_alias
@deprecated_alias('get_subsystems')
def framework_get_subsystems(client): def framework_get_subsystems(client):
return client.call('framework_get_subsystems') return client.call('framework_get_subsystems')
@deprecated_alias('get_subsystem_config')
def framework_get_config(client, name): def framework_get_config(client, name):
params = {'name': name} params = {'name': name}
return client.call('framework_get_config', params) return client.call('framework_get_config', params)

5
scripts/rpc.py
View File

@ -2392,7 +2392,7 @@ Format: 'user:u1 secret:s1 muser:mu1 msecret:ms1,user:u2 secret:s2 muser:mu2 mse
def framework_get_subsystems(args): def framework_get_subsystems(args):
print_dict(rpc.subsystem.framework_get_subsystems(args.client)) print_dict(rpc.subsystem.framework_get_subsystems(args.client))
p = subparsers.add_parser('framework_get_subsystems', aliases=['get_subsystems'], p = subparsers.add_parser('framework_get_subsystems',
help="""Print subsystems array in initialization order. Each subsystem help="""Print subsystems array in initialization order. Each subsystem
entry contain (unsorted) array of subsystems it depends on.""") entry contain (unsorted) array of subsystems it depends on.""")
p.set_defaults(func=framework_get_subsystems) p.set_defaults(func=framework_get_subsystems)
@ -2400,8 +2400,7 @@ Format: 'user:u1 secret:s1 muser:mu1 msecret:ms1,user:u2 secret:s2 muser:mu2 mse
def framework_get_config(args): def framework_get_config(args):
print_dict(rpc.subsystem.framework_get_config(args.client, args.name)) print_dict(rpc.subsystem.framework_get_config(args.client, args.name))
p = subparsers.add_parser('framework_get_config', aliases=['get_subsystem_config'], p = subparsers.add_parser('framework_get_config', help="""Print subsystem configuration""")
help="""Print subsystem configuration""")
p.add_argument('name', help='Name of subsystem to query') p.add_argument('name', help='Name of subsystem to query')
p.set_defaults(func=framework_get_config) p.set_defaults(func=framework_get_config)